handle empty attributes

pull/689/head
Rich Harris 8 years ago
parent d2f5296bd9
commit 74d15ea877

@ -114,8 +114,8 @@ function selectorAppliesTo(parts: Node[], node: Node, stack: Node[]): boolean {
function classMatches(node: Node, className: string) { function classMatches(node: Node, className: string) {
const attr = node.attributes.find((attr: Node) => attr.name === 'class'); const attr = node.attributes.find((attr: Node) => attr.name === 'class');
if (!attr) return false; if (!attr || attr.value === true) return false;
if (isDynamic(attr)) return true; if (isDynamic(attr.value)) return true;
const value = attr.value[0].data; const value = attr.value[0].data;
@ -125,7 +125,7 @@ function classMatches(node: Node, className: string) {
function attributeMatches(node: Node, selector: Node) { function attributeMatches(node: Node, selector: Node) {
const attr = node.attributes.find((attr: Node) => attr.name === selector.name.name); const attr = node.attributes.find((attr: Node) => attr.name === selector.name.name);
if (!attr) return false; if (!attr) return false;
if (isDynamic(attr)) return true; if (attr.value === true || isDynamic(attr.value)) return true;
const expectedValue = unquote(selector.value.value); const expectedValue = unquote(selector.value.value);
const actualValue = attr.value[0].data; const actualValue = attr.value[0].data;
@ -137,8 +137,8 @@ function attributeMatches(node: Node, selector: Node) {
return true; return true;
} }
function isDynamic(attr: Node) { function isDynamic(value: Node) {
return attr.value.length > 1 || attr.value[0].type !== 'Text'; return value.length > 1 || value[0].type !== 'Text';
} }
function unquote(str: string) { function unquote(str: string) {

@ -0,0 +1,4 @@
[data-foo][svelte-2966013849] {
color: red;
}

@ -0,0 +1,2 @@
<div><p svelte-2966013849="" data-foo="true">this is styled</p>
<p data-bar="true">this is unstyled</p></div>

@ -0,0 +1,10 @@
<div>
<p data-foo>this is styled</p>
<p data-bar>this is unstyled</p>
</div>
<style>
[data-foo] {
color: red;
}
</style>
Loading…
Cancel
Save