msb-public
/
svelte
mirror of https://github.com/sveltejs/svelte
1
0
Code Issues Projects Releases Wiki Activity

removed size from read properties because it can depend on version signal and doesn't require its own signal

Browse Source
pull/11504/head
godzylinux 2 years ago committed by FoHoOV
parent c6c4f4648c
commit 68dfe7914a
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File

8
packages/svelte/src/reactivity/map.js
Unescape View File

@ -2,14 +2,14 @@ import { make_reactive, NOTIFY_WITH_ALL_PARAMS } from './utils.js';
export const ReactiveMap = make_reactive(Map, { export const ReactiveMap = make_reactive(Map, {
write_properties: ['clear', 'delete', 'set'], write_properties: ['clear', 'delete', 'set'],
read_properties: ['get', 'keys', 'size', 'entries', 'values', 'has'], read_properties: ['get', 'keys', 'entries', 'values', 'has'],
interceptors: { interceptors: {
set: (notify_read_methods, value, property, ...params) => { set: (notify_read_methods, value, property, ...params) => {
if (value.get(params[0]) === params[1]) { if (value.get(params[0]) === params[1]) {
return false; return false;
} }
if (!value.has(params[0])) { if (!value.has(params[0])) {
notify_read_methods(['keys', 'size']); notify_read_methods(['keys']);
} }
notify_read_methods(['entries', 'values']); notify_read_methods(['entries', 'values']);
notify_read_methods(['get', 'has'], params[1]); notify_read_methods(['get', 'has'], params[1]);
@ -19,7 +19,7 @@ export const ReactiveMap = make_reactive(Map, {
if (value.size === 0) { if (value.size === 0) {
return false; return false;
} }
notify_read_methods(['keys', 'size', 'values', 'entries', 'has'], NOTIFY_WITH_ALL_PARAMS); notify_read_methods(['keys', 'values', 'entries', 'has'], NOTIFY_WITH_ALL_PARAMS);
return true; return true;
}, },
delete: (notify_read_methods, value, property, ...params) => { delete: (notify_read_methods, value, property, ...params) => {
@ -27,7 +27,7 @@ export const ReactiveMap = make_reactive(Map, {
return false; return false;
} }
notify_read_methods(['get', 'has'], params[0]); notify_read_methods(['get', 'has'], params[0]);
notify_read_methods(['keys', 'size', 'values', 'entries']); notify_read_methods(['keys', 'values', 'entries']);
return true; return true;
} }
} }

5
packages/svelte/src/reactivity/set.js
Unescape View File

@ -2,14 +2,13 @@ import { make_reactive, NOTIFY_WITH_ALL_PARAMS } from './utils.js';
export const ReactiveSet = make_reactive(Set, { export const ReactiveSet = make_reactive(Set, {
write_properties: ['add', 'clear', 'delete'], write_properties: ['add', 'clear', 'delete'],
read_properties: ['has', 'size'], read_properties: ['has'],
interceptors: { interceptors: {
add: (notify_read_methods, value, property, ...params) => { add: (notify_read_methods, value, property, ...params) => {
if (value.has(params[0])) { if (value.has(params[0])) {
return false; return false;
} }
notify_read_methods(['has'], params[0]); notify_read_methods(['has'], params[0]);
notify_read_methods(['size']);
return true; return true;
}, },
clear: (notify_read_methods, value, property, ...params) => { clear: (notify_read_methods, value, property, ...params) => {
@ -17,7 +16,6 @@ export const ReactiveSet = make_reactive(Set, {
return false; return false;
} }
notify_read_methods(['has'], NOTIFY_WITH_ALL_PARAMS); notify_read_methods(['has'], NOTIFY_WITH_ALL_PARAMS);
notify_read_methods(['size']);
return true; return true;
}, },
delete: (notify_read_methods, value, property, ...params) => { delete: (notify_read_methods, value, property, ...params) => {
@ -25,7 +23,6 @@ export const ReactiveSet = make_reactive(Set, {
return false; return false;
} }
notify_read_methods(['has'], params[0]); notify_read_methods(['has'], params[0]);
notify_read_methods(['size']);
return true; return true;
} }
} }

Write Preview
Loading…
Cancel
Save