fix a few more tests

pull/1864/head
Rich Harris 7 years ago
parent 4041f0e734
commit 64387a2960

@ -270,8 +270,8 @@ function getValueFromDom(
// <select bind:value='selected>
if (node.name === 'select') {
return node.getStaticAttributeValue('multiple') === true ?
`@selectMultipleValue(${element.var})` :
`@selectValue(${element.var})`;
`@selectMultipleValue(this)` :
`@selectValue(this)`;
}
const type = node.getStaticAttributeValue('type');
@ -283,16 +283,16 @@ function getValueFromDom(
return `@getBindingGroupValue(#component.$$bindingGroups[${bindingGroup}])`;
}
return `${element.var}.__value`;
return `this.__value`;
}
// <input type='range|number' bind:value>
if (type === 'range' || type === 'number') {
return `@toNumber(${element.var}.${name})`;
return `@toNumber(this.${name})`;
}
if ((name === 'buffered' || name === 'seekable' || name === 'played')) {
return `@timeRangesToArray(${element.var}.${name})`
return `@timeRangesToArray(this.${name})`
}
// everything else

@ -11,6 +11,6 @@ export default {
const h1 = target.querySelector('h1');
assert.equal(h1, snapshot.h1);
assert.equal(component.refs.h1, h1);
assert.equal(component.h1, h1);
}
};

@ -6,7 +6,7 @@ export default {
},
test(assert, component, target, window) {
component.refs.modal.toggle();
component.modal.toggle();
assert.htmlEqual(target.innerHTML, `
<span>b</span>
@ -41,8 +41,8 @@ export default {
</select>
`);
component.refs.modal.toggle();
component.refs.modal.toggle();
component.modal.toggle();
component.modal.toggle();
assert.deepEqual(Array.from(select.options).map(o => o.selected), [
false,

@ -1,6 +1,7 @@
<script>
import Modal from './Modal.html';
export let modal;
export let letter;
export let letters = ['a', 'b', 'c'];
</script>

@ -1,5 +1,5 @@
export default {
test(assert, component) {
assert.equal(component.refs.one.snapshot, 2);
assert.equal(component.one.snapshot, 2);
}
};

@ -1,6 +1,6 @@
export default {
test(assert, component) {
const { foo, p } = component.refs;
const { foo, p } = component;
const values = [];

@ -1,5 +1,5 @@
export default {
test(assert, component) {
component.refs.l1.destroy();
component.l1.destroy();
}
};

@ -1,7 +1,7 @@
export default {
html: '<div><p>i am a widget</p></div>',
test ( assert, component ) {
const widget = component.refs.widget;
const widget = component.widget;
assert.ok( widget.isWidget );
}
};

@ -4,6 +4,6 @@ export default {
`,
test(assert, component) {
component.refs.nested.set({ foo: 'b' });
component.nested.set({ foo: 'b' });
}
};

@ -2,7 +2,7 @@ export default {
html: '<div><p></p></div>',
test ( assert, component, target ) {
const widget = component.refs.widget;
const widget = component.widget;
assert.equal( widget.get().show, false );

@ -1,8 +1,13 @@
<script>
export let components;
let name;
</script>
<ul>
{#each components as component}
<li>
{#if component.edit}
<input ref:name bind:value={component}.name />
<input ref:name bind:value={component.name} />
{:else}
{component.name}
{/if}

@ -1,5 +0,0 @@
export default {
compileOptions: {
dev: true
}
};

@ -1,14 +0,0 @@
<script>
import { Store } from '../../../../store.js';
const store = new Store({ foo : "foo" });
/*
svelte-upgrade cannot automatically transform this code —
it must be updated manually
store : () => store
*/
</script>
<p>{$foo}</p>

@ -1,7 +0,0 @@
export default {
compileOptions: {
dev: true
},
error: `<Main$> references store properties, but no store was provided`
};

@ -3,7 +3,7 @@ export default {
html: `<div><h3>Called 0 times.</h3></div>`,
test(assert, component, target, window) {
var nested = component.refs.nested;
var nested = component.nested;
nested.on('state', ({ changed }) => {
if (changed.foo) {
nested.set({ count: nested.get().count + 1 });

@ -3,7 +3,7 @@ export default {
html: `<div><h3>Called 0 times.</h3></div>`,
test(assert, component, target, window) {
var nested = component.refs.nested;
var nested = component.nested;
nested.on('state', ({ changed }) => {
if (changed.foo) {
nested.set({ count: nested.get().count + 1 });

@ -13,7 +13,7 @@ export default {
test(assert, component, target, window) {
let triggered = false;
component.refs.nested.on('state', ({ changed }) => {
component.nested.on('state', ({ changed }) => {
if (changed.field2) triggered = true;
});

@ -1,6 +1,6 @@
export default {
test(assert, component, target) {
const top = component.refs.top;
const top = component.top;
const div = target.querySelector('div');
component.visible = false;

@ -6,7 +6,7 @@ export default {
`,
test(assert, component, target) {
component.refs.list.update();
component.list.update();
assert.htmlEqual(target.innerHTML, `
<span>1</span><span>2</span><span>3</span><span>4</span><span>5</span>

@ -1,7 +1,8 @@
export default {
html: '<div><canvas></canvas></div>',
test(assert, component, target) {
const canvas = target.querySelector('canvas');
assert.equal( canvas, component.refs.foo );
assert.equal(canvas, component.foo);
}
};

@ -1 +1,5 @@
<script>
export let foo;
</script>
<div><canvas ref:foo></canvas></div>

@ -7,17 +7,17 @@ export default {
test(assert, component, target) {
let canvas = target.querySelector('canvas');
assert.equal( canvas, component.refs.foo );
assert.equal(canvas, component.foo);
assert.equal(canvas.getAttribute('data-x'), 'true');
component.x = false;
canvas = target.querySelector('canvas');
assert.equal( canvas, component.refs.foo );
assert.equal(canvas, component.foo);
assert.equal(canvas.getAttribute('data-x'), 'false');
component.x = true;
canvas = target.querySelector('canvas');
assert.equal( canvas, component.refs.foo );
assert.equal(canvas, component.foo);
assert.equal(canvas.getAttribute('data-x'), 'true');
}
};

@ -1,3 +1,7 @@
<script>
export let foo;
</script>
{#if x}
<canvas ref:foo data-x='true'></canvas>
{:else}

@ -1,7 +1,8 @@
export default {
html: '<canvas></canvas>',
test(assert, component, target) {
const canvas = target.querySelector('canvas');
assert.equal( canvas, component.refs.foo );
assert.equal(canvas, component.foo);
}
};

@ -1 +1,5 @@
<script>
export let foo;
</script>
<canvas ref:foo></canvas>

@ -1,18 +1,18 @@
export default {
test(assert, component, target, window, raf) {
assert.equal(target.querySelector('div'), component.refs.no);
assert.equal(component.refs.no.foo, 0);
assert.equal(target.querySelector('div'), component.no);
assert.equal(component.no.foo, 0);
raf.tick(200);
assert.equal(component.refs.no.foo, 0.5);
assert.equal(component.no.foo, 0.5);
raf.tick(500);
component.x = true;
assert.equal(component.refs.no, undefined);
assert.equal(component.refs.yes.foo, 0);
assert.equal(component.no, undefined);
assert.equal(component.yes.foo, 0);
raf.tick(700);
assert.equal(component.refs.yes.foo, 0.5);
assert.equal(component.yes.foo, 0.5);
raf.tick(1000);
}

Loading…
Cancel
Save