anchor-is-valid

src/validate/html/a11y.ts

@@ -21,10 +21,18 @@ export default function a11y(
 	});
 
 	if (node.name === 'a') {
-		if (!attributeMap.has('href')) {
+		// anchor-is-valid
+		const href = attributeMap.get('href');
+		if (href) {
+			const value = getValue(href);
+			if (value === '' || value === '#') {
+				validator.warn(`A11y: '${value}' is not a valid href attribute`, href.start);
+			}
+		} else {
 			validator.warn(`A11y: <a> element should have an href attribute`, node.start);
 		}
 
+		// anchor-has-content
 		if (!node.children.length) {
 			validator.warn(`A11y: <a> element should have child content`, node.start);
 		}
@@ -48,3 +56,10 @@ export default function a11y(
 		}
 	}
 }
+
+function getValue(attribute: Node) {
+	if (attribute.value.length === 0) return '';
+	if (attribute.value.length === 1 && attribute.value[0].type === 'Text') return attribute.value[0].data;
+
+	return null;
+}

test/validator/samples/a11y-a-without-href/input.html

@@ -1 +0,0 @@
-<a>not actually a link</a>

test/validator/samples/a11y-a-without-href/warnings.json

@@ -1,8 +0,0 @@
-[{
-	"message": "A11y: <a> element should have an href attribute",
-	"loc": {
-		"line": 1,
-		"column": 0
-	},
-	"pos": 0
-}]

test/validator/samples/a11y-anchor-is-valid/input.html

@@ -0,0 +1,3 @@
+<a>not actually a link</a>
+<a href=''>invalid</a>
+<a href='#'>invalid</a>

test/validator/samples/a11y-anchor-is-valid/warnings.json

@@ -0,0 +1,26 @@
+[
+	{
+		"message": "A11y: <a> element should have an href attribute",
+		"loc": {
+			"line": 1,
+			"column": 0
+		},
+		"pos": 0
+	},
+	{
+		"message": "A11y: '' is not a valid href attribute",
+		"loc": {
+			"line": 2,
+			"column": 3
+		},
+		"pos": 30
+	},
+	{
+		"message": "A11y: '#' is not a valid href attribute",
+		"loc": {
+			"line": 3,
+			"column": 3
+		},
+		"pos": 53
+	}
+]