throw if default export is not an object literal

pull/190/head
Rich-Harris 8 years ago
parent 161473a918
commit 4a610f7073

@ -17,42 +17,44 @@ export default function validateJs ( validator, js ) {
if ( node.type === 'ExportDefaultDeclaration' ) { if ( node.type === 'ExportDefaultDeclaration' ) {
if ( validator.defaultExport ) { if ( validator.defaultExport ) {
validator.error( `Duplicate default export`, node.start ); return validator.error( `Duplicate default export`, node.start );
} }
validator.defaultExport = node; if ( node.declaration.type !== 'ObjectExpression' ) {
} return validator.error( `Default export must be an object literal`, node.declaration.start );
}); }
checkForComputedKeys( validator, node.declaration.properties );
checkForDupes( validator, node.declaration.properties );
// ensure all exported props are valid node.declaration.properties.forEach( prop => {
if ( validator.defaultExport ) { validator.templateProperties[ prop.key.name ] = prop;
checkForComputedKeys( validator, validator.defaultExport.declaration.properties ); });
checkForDupes( validator, validator.defaultExport.declaration.properties );
// ensure all exported props are valid
validator.defaultExport.declaration.properties.forEach( prop => { node.declaration.properties.forEach( prop => {
validator.templateProperties[ prop.key.name ] = prop; const propValidator = propValidators[ prop.key.name ];
});
if ( propValidator ) {
validator.defaultExport.declaration.properties.forEach( prop => { propValidator( validator, prop );
const propValidator = propValidators[ prop.key.name ];
if ( propValidator ) {
propValidator( validator, prop );
} else {
const matches = fuzzySet.get( prop.key.name );
if ( matches && matches[0] && matches[0][0] > 0.7 ) {
validator.error( `Unexpected property '${prop.key.name}' (did you mean '${matches[0][1]}'?)`, prop.start );
} else if ( /FunctionExpression/.test( prop.value.type ) ) {
validator.error( `Unexpected property '${prop.key.name}' (did you mean to include it in 'methods'?)`, prop.start );
} else { } else {
validator.error( `Unexpected property '${prop.key.name}'`, prop.start ); const matches = fuzzySet.get( prop.key.name );
if ( matches && matches[0] && matches[0][0] > 0.7 ) {
validator.error( `Unexpected property '${prop.key.name}' (did you mean '${matches[0][1]}'?)`, prop.start );
} else if ( /FunctionExpression/.test( prop.value.type ) ) {
validator.error( `Unexpected property '${prop.key.name}' (did you mean to include it in 'methods'?)`, prop.start );
} else {
validator.error( `Unexpected property '${prop.key.name}'`, prop.start );
}
} }
});
if ( validator.templateProperties.namespace ) {
const ns = validator.templateProperties.namespace.value.value;
validator.namespace = namespaces[ ns ] || ns;
} }
});
if ( validator.templateProperties.namespace ) { validator.defaultExport = node;
const ns = validator.templateProperties.namespace.value.value;
validator.namespace = namespaces[ ns ] || ns;
} }
} });
} }

@ -0,0 +1,8 @@
[{
"message": "Default export must be an object literal",
"pos": 25,
"loc": {
"line": 2,
"column": 16
}
}]

@ -0,0 +1,3 @@
<script>
export default potato;
</script>
Loading…
Cancel
Save