msb-public
/
svelte
mirror of https://github.com/sveltejs/svelte
1
0
Code Issues Projects Releases Wiki Activity

Merge pull request #1365 from sveltejs/gh-1354

Browse Source 
set state to blank object on destroy, not null
pull/1370/head
Rich Harris 7 years ago committed by GitHub
parent 4f86820cf0 fd7acedb99
commit 4734382e69
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
35 changed files with 113 additions and 66 deletions
Show Stats Download Patch File Download Diff File

5
src/shared/index.js
Unescape View File

@ -13,11 +13,12 @@ export function blankObject() {
export function destroy(detach) { export function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
export function destroyDev(detach) { export function destroyDev(detach) {

5
test/js/samples/action/expected-bundle.js
Unescape View File

@ -24,11 +24,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/collapses-text-around-comments/expected-bundle.js
Unescape View File

@ -32,11 +32,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/component-static-immutable/expected-bundle.js
Unescape View File

@ -12,11 +12,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/component-static-immutable2/expected-bundle.js
Unescape View File

@ -12,11 +12,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/component-static/expected-bundle.js
Unescape View File

@ -12,11 +12,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/computed-collapsed-if/expected-bundle.js
Unescape View File

@ -12,11 +12,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/css-media-query/expected-bundle.js
Unescape View File

@ -28,11 +28,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/css-shadow-dom-keyframes/expected-bundle.js
Unescape View File

@ -24,11 +24,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/deconflict-builtins/expected-bundle.js
Unescape View File

@ -42,11 +42,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/deconflict-globals/expected-bundle.js
Unescape View File

@ -12,11 +12,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/dev-warning-missing-data-computed/expected-bundle.js
Unescape View File

@ -32,11 +32,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function destroyDev(detach) { function destroyDev(detach) {

5
test/js/samples/do-use-dataset/expected-bundle.js
Unescape View File

@ -28,11 +28,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/dont-use-dataset-in-legacy/expected-bundle.js
Unescape View File

@ -32,11 +32,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/dont-use-dataset-in-svg/expected-bundle.js
Unescape View File

@ -32,11 +32,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/each-block-changed-check/expected-bundle.js
Unescape View File

@ -44,11 +44,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/event-handlers-custom/expected-bundle.js
Unescape View File

@ -24,11 +24,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/head-no-whitespace/expected-bundle.js
Unescape View File

@ -24,11 +24,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/if-block-no-update/expected-bundle.js
Unescape View File

@ -28,11 +28,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/if-block-simple/expected-bundle.js
Unescape View File

@ -28,11 +28,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/inline-style-optimized-multiple/expected-bundle.js
Unescape View File

@ -28,11 +28,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/inline-style-optimized-url/expected-bundle.js
Unescape View File

@ -28,11 +28,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/inline-style-optimized/expected-bundle.js
Unescape View File

@ -28,11 +28,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/inline-style-unoptimized/expected-bundle.js
Unescape View File

@ -28,11 +28,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/input-without-blowback-guard/expected-bundle.js
Unescape View File

@ -36,11 +36,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/legacy-input-type/expected-bundle.js
Unescape View File

@ -30,11 +30,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/media-bindings/expected-bundle.js
Unescape View File

@ -40,11 +40,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/non-imported-component/expected-bundle.js
Unescape View File

@ -26,11 +26,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/setup-method/expected-bundle.js
Unescape View File

@ -12,11 +12,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/svg-title/expected-bundle.js
Unescape View File

@ -32,11 +32,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/title/expected-bundle.js
Unescape View File

@ -12,11 +12,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/use-elements-as-anchors/expected-bundle.js
Unescape View File

@ -36,11 +36,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

5
test/js/samples/window-binding-scroll/expected-bundle.js
Unescape View File

@ -32,11 +32,12 @@ function blankObject() {
function destroy(detach) { function destroy(detach) {
this.destroy = noop; this.destroy = noop;
this.fire('destroy'); this.fire('destroy');
this.set = this.get = noop; this.set = noop;
if (detach !== false) this._fragment.u(); if (detach !== false) this._fragment.u();
this._fragment.d(); this._fragment.d();
this._fragment = this._state = null; this._fragment = null;
this._state = {};
} }
function _differs(a, b) { function _differs(a, b) {

13
test/runtime/samples/get-after-destroy/_config.js
Unescape View File

@ -0,0 +1,13 @@
export default {
data: {
foo: 1
},
html: `<div>1</div>`,
test(assert, component) {
component.destroy();
const { foo } = component.get();
assert.equal(foo, undefined);
}
}

1
test/runtime/samples/get-after-destroy/main.html
Unescape View File

@ -0,0 +1 @@
<div>{foo}</div>
Write Preview
Loading…
Cancel
Save