fix : no update() when tag is non-dynamic

src/compiler/compile/render_dom/wrappers/Element/index.ts

@@ -280,9 +280,7 @@ export default class ElementWrapper extends Wrapper {
 			(x`#nodes` as unknown) as Identifier
 		);
 
-		const previous_tag = block.get_unique_name('previous_tag');
 		const tag = this.node.tag_expr.manipulate(block);
-		block.add_variable(previous_tag, tag);
 
 		block.chunks.init.push(b`
 			${this.renderer.options.dev && b`@validate_dynamic_element(${tag});`}
@@ -304,6 +302,11 @@ export default class ElementWrapper extends Wrapper {
 			if (${this.var}) ${this.var}.m(${parent_node || '#target'}, ${parent_node ? 'null' : '#anchor'});
 		`);
 
+		if (this.node.tag_expr.dynamic_dependencies().length == 0) {
+			block.chunks.update.push(b`if (${this.var}) ${this.var}.p(#ctx, #dirty)`);
+		} else {
+			const previous_tag = block.get_unique_name('previous_tag');
+			block.add_variable(previous_tag, tag);
 			const anchor = this.get_or_create_anchor(block, parent_node, parent_nodes);
 			const has_transitions = !!(this.node.intro || this.node.outro);
 			const not_equal = this.renderer.component.component_options.immutable ? x`@not_equal` : x`@safe_not_equal`;
@@ -312,7 +315,6 @@ export default class ElementWrapper extends Wrapper {
 			if (has_transitions) {
 				block.add_variable(tag_will_be_removed, x`false`);
 			}
-
 			block.chunks.update.push(b`
 				if (${tag}) {
 					if (!${previous_tag}) {
@@ -361,6 +363,7 @@ export default class ElementWrapper extends Wrapper {
 					}
 				}
 			`);
+		}
 
 		if (this.child_dynamic_element_block.has_intros) {
 			block.chunks.intro.push(b`@transition_in(${this.var});`);

test/js/samples/svelte-element-svg/expected.js

@@ -4,7 +4,6 @@ import {
 	append,
 	assign,
 	detach,
-	empty,
 	get_spread_update,
 	init,
 	insert,
@@ -60,44 +59,21 @@ function create_dynamic_element(ctx) {
 }
 
 function create_fragment(ctx) {
-	let previous_tag = "svg";
-	let svelte_element1_anchor;
 	let svelte_element1 = "svg" && create_dynamic_element(ctx);
 
 	return {
 		c() {
 			if (svelte_element1) svelte_element1.c();
-			svelte_element1_anchor = empty();
 		},
 		m(target, anchor) {
 			if (svelte_element1) svelte_element1.m(target, anchor);
-			insert(target, svelte_element1_anchor, anchor);
 		},
 		p(ctx, [dirty]) {
-			if ("svg") {
+			if (svelte_element1) svelte_element1.p(ctx, dirty);
-				if (!previous_tag) {
-					svelte_element1 = create_dynamic_element(ctx);
-					svelte_element1.c();
-					svelte_element1.m(svelte_element1_anchor.parentNode, svelte_element1_anchor);
-				} else if (safe_not_equal(previous_tag, "svg")) {
-					svelte_element1.d(1);
-					svelte_element1 = create_dynamic_element(ctx);
-					svelte_element1.c();
-					svelte_element1.m(svelte_element1_anchor.parentNode, svelte_element1_anchor);
-				} else {
-					svelte_element1.p(ctx, dirty);
-				}
-			} else if (previous_tag) {
-				svelte_element1.d(1);
-				svelte_element1 = null;
-			}
-
-			previous_tag = "svg";
 		},
 		i: noop,
 		o: noop,
 		d(detaching) {
-			if (detaching) detach(svelte_element1_anchor);
 			if (svelte_element1) svelte_element1.d(detaching);
 		}
 	};