Revert "chore: bring back recursive processing of effects" (#12880)

* Revert "chore: bring back recursive processing of effects (#12861)"

This reverts commit cb124315be.

* apply tweak

packages/svelte/src/internal/client/runtime.js

@@ -572,71 +572,81 @@ export function schedule_effect(signal) {
 }
 
 /**
+ *
+ * This function both runs render effects and collects user effects in topological order
+ * from the starting effect passed in. Effects will be collected when they match the filtered
+ * bitwise flag passed in only. The collected effects array will be populated with all the user
+ * effects to be flushed.
+ *
  * @param {Effect} effect
- * @param {Effect[]} effects
+ * @param {Effect[]} collected_effects
+ * @returns {void}
  */
-function process_effect_children(effect, effects) {
+function process_effects(effect, collected_effects) {
-	var current = effect.first;
+	var current_effect = effect.first;
-
+	var effects = [];
-	while (current !== null) {
-		var next = current.next;
-		process_effect(current, effects);
-		current = next;
-	}
-}
 
-/**
+	main_loop: while (current_effect !== null) {
- * @param {Effect} effect
+		var flags = current_effect.f;
- * @param {Effect[]} effects
- */
-function process_effect(effect, effects) {
-	var flags = effect.f;
 		// TODO: we probably don't need to check for destroyed as it shouldn't be encountered?
 		var is_active = (flags & (DESTROYED | INERT)) === 0;
 		var is_branch = (flags & BRANCH_EFFECT) !== 0;
 		var is_clean = (flags & CLEAN) !== 0;
+		var child = current_effect.first;
 
 		// Skip this branch if it's clean
 		if (is_active && (!is_branch || !is_clean)) {
 			if (is_branch) {
-			set_signal_status(effect, CLEAN);
+				set_signal_status(current_effect, CLEAN);
 			}
 
 			if ((flags & RENDER_EFFECT) !== 0) {
-			if (!is_branch && check_dirtiness(effect)) {
+				if (!is_branch && check_dirtiness(current_effect)) {
-				update_effect(effect);
+					update_effect(current_effect);
+					// Child might have been mutated since running the effect
+					child = current_effect.first;
 				}
 
-			process_effect_children(effect, effects);
+				if (child !== null) {
+					current_effect = child;
+					continue;
+				}
 			} else if ((flags & EFFECT) !== 0) {
 				if (is_branch || is_clean) {
-				process_effect_children(effect, effects);
+					if (child !== null) {
+						current_effect = child;
+						continue;
+					}
 				} else {
-				effects.push(effect);
+					effects.push(current_effect);
 				}
 			}
 		}
+		var sibling = current_effect.next;
+
+		if (sibling === null) {
+			let parent = current_effect.parent;
+
+			while (parent !== null) {
+				if (effect === parent) {
+					break main_loop;
+				}
+				var parent_sibling = parent.next;
+				if (parent_sibling !== null) {
+					current_effect = parent_sibling;
+					continue main_loop;
+				}
+				parent = parent.parent;
+			}
+		}
+
+		current_effect = sibling;
 	}
 
-/**
- *
- * This function both runs render effects and collects user effects in topological order
- * from the starting effect passed in. Effects will be collected when they match the filtered
- * bitwise flag passed in only. The collected effects array will be populated with all the user
- * effects to be flushed.
- *
- * @param {Effect} effect
- * @param {Effect[]} collected_effects
- * @returns {void}
- */
-function process_effects(effect, collected_effects) {
-	/** @type {Effect[]} */
-	var effects = [];
-	process_effect_children(effect, effects);
 	// We might be dealing with many effects here, far more than can be spread into
 	// an array push call (callstack overflow). So let's deal with each effect in a loop.
 	for (var i = 0; i < effects.length; i++) {
-		var child = effects[i];
+		child = effects[i];
 		collected_effects.push(child);
 		process_effects(child, collected_effects);
 	}