chore: use `next()` and `snip` instead of walking the AST

packages/svelte/src/compiler/migrate/index.js

@@ -603,42 +603,14 @@ const template = {
 		next();
 	},
 	SvelteComponent(node, { state, next, path }) {
-		let expression = state.str.original.substring(
+		next();
-			/** @type {number} */ (node.expression.start),
-			node.expression.end
-		);
 
-		if (state.analysis.uses_props || state.analysis.uses_rest_props) {
+		let expression = state.str
-			let difference = 0;
+			.snip(
-			// we need to migrate $$props and $$restProps by hand to update all the $$props and $$restProps in the expression
+				/** @type {number} */ (node.expression.start),
-			walk(
+				/** @type {number} */ (node.expression.end)
-				node.expression,
+			)
-				{},
+			.toString();
-				{
-					Identifier(id_node, { path, next }) {
-						const parent = path[path.length - 1];
-						if (id_node.name !== '$$props' && id_node.name !== '$$restProps') return;
-
-						if (parent.type === 'MemberExpression' && parent.object !== id_node) return;
-
-						const props_name =
-							id_node.name === '$$props' || state.analysis.uses_props
-								? state.names.props
-								: state.names.rest;
-						const props_start =
-							/** @type {number} */ (id_node.start) - /** @type {number} */ (node.expression.start);
-
-						expression =
-							expression.substring(0, props_start + difference) +
-							props_name +
-							expression.substring(props_start + id_node.name.length + difference);
-
-						difference += props_name.length - id_node.name.length;
-						next();
-					}
-				}
-			);
-		}
 
 		if (
 			(node.expression.type !== 'Identifier' && node.expression.type !== 'MemberExpression') ||
@@ -687,7 +659,6 @@ const template = {
 		while (!state.str.original.charAt(this_pos - 1).trim()) this_pos--;
 		const end_pos = state.str.original.indexOf('}', node.expression.end) + 1;
 		state.str.remove(this_pos, end_pos);
-		next();
 	},
 	SvelteWindow(node, { state, next }) {
 		handle_events(node, state);
@@ -946,19 +917,6 @@ function get_node_range(source, node) {
 	return { start, end };
 }
 
-/**
- *
- * @param {SvelteNode[]} path
- */
-function is_in_sveltecomponent_expression(path) {
-	for (let i = 0; i < path.length - 1; i++) {
-		const part = path[i];
-		if (part.type === 'SvelteComponent' && part.expression === path[i + 1]) {
-			return true;
-		}
-	}
-}
-
 /**
  * @param {Identifier} node
  * @param {State} state
@@ -966,13 +924,7 @@ function is_in_sveltecomponent_expression(path) {
  */
 function handle_identifier(node, state, path) {
 	const parent = path.at(-1);
-	if (
+	if (parent?.type === 'MemberExpression' && parent.property === node) return;
-		(parent?.type === 'MemberExpression' && parent.property === node) ||
-		// we migrate the expression of svelte:component separately because
-		// it might need to be as an expression in a derived
-		is_in_sveltecomponent_expression(path)
-	)
-		return;
 
 	if (state.analysis.uses_props) {
 		if (node.name === '$$props' || node.name === '$$restProps') {