fix: don't warn on writes to `$state` (#11540)

fixes #10905
pull/11544/head
Simon H 8 months ago committed by GitHub
parent 65223363e9
commit 31f8fea22d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -0,0 +1,5 @@
---
"svelte": patch
---
fix: don't warn on writes to `$state`

@ -1242,6 +1242,7 @@ const common_visitors = {
if ( if (
context.state.analysis.runes && context.state.analysis.runes &&
node !== binding.node && node !== binding.node &&
context.state.function_depth === binding.scope.function_depth &&
// If we have $state that can be proxied or frozen and isn't re-assigned, then that means // If we have $state that can be proxied or frozen and isn't re-assigned, then that means
// it's likely not using a primitive value and thus this warning isn't that helpful. // it's likely not using a primitive value and thus this warning isn't that helpful.
((binding.kind === 'state' && ((binding.kind === 'state' &&
@ -1252,7 +1253,9 @@ const common_visitors = {
!should_proxy_or_freeze(binding.initial.arguments[0], context.state.scope)))) || !should_proxy_or_freeze(binding.initial.arguments[0], context.state.scope)))) ||
binding.kind === 'frozen_state' || binding.kind === 'frozen_state' ||
binding.kind === 'derived') && binding.kind === 'derived') &&
context.state.function_depth === binding.scope.function_depth // We're only concerned with reads here
(parent.type !== 'AssignmentExpression' || parent.left !== node) &&
parent.type !== 'UpdateExpression'
) { ) {
w.state_referenced_locally(node); w.state_referenced_locally(node);
} }

@ -6,6 +6,11 @@
console.log(obj); console.log(obj);
console.log(count); console.log(count);
console.log(doubled); console.log(doubled);
// these are ok because they're writes
count++;
count = 1;
obj.a++;
obj.a = 1;
</script> </script>
<button onclick={() => count += 1}> <button onclick={() => count += 1}>

Loading…
Cancel
Save