rename to snake case

pull/3725/head
Tan Li Hau 6 years ago
parent 1a6fdbe2fe
commit 31e8480cb6

@ -2,15 +2,15 @@ import Attribute from '../../nodes/Attribute';
import fuzzymatch from '../../../utils/fuzzymatch'; import fuzzymatch from '../../../utils/fuzzymatch';
const validators = [ const validators = [
noAutoFocus, no_auto_focus,
unsupportedAriaElement, unsupported_aria_element,
unknownAriaAttribute, unknown_aria_attribute,
noAriaHidden, no_aria_hidden,
noMisplacedRole, no_misplaced_role,
noUnknownRole, no_unknown_role,
noAccessKey, no_access_key,
noMisplacedScope, no_misplaced_scope,
tabindexNoPositive, tabindex_no_positive,
]; ];
export default function validateA11y(attribute: Attribute) { export default function validateA11y(attribute: Attribute) {
@ -25,7 +25,7 @@ export default function validateA11y(attribute: Attribute) {
} }
} }
function noAutoFocus(attribute: Attribute, name: string) { function no_auto_focus(attribute: Attribute, name: string) {
if (name === 'autofocus') { if (name === 'autofocus') {
attribute.parent.component.warn(attribute, { attribute.parent.component.warn(attribute, {
code: `a11y-autofocus`, code: `a11y-autofocus`,
@ -35,7 +35,7 @@ function noAutoFocus(attribute: Attribute, name: string) {
} }
const invisible_elements = new Set(['meta', 'html', 'script', 'style']); const invisible_elements = new Set(['meta', 'html', 'script', 'style']);
function unsupportedAriaElement(attribute: Attribute, name: string) { function unsupported_aria_element(attribute: Attribute, name: string) {
if (name.startsWith('aria-')) { if (name.startsWith('aria-')) {
if (invisible_elements.has(attribute.parent.name)) { if (invisible_elements.has(attribute.parent.name)) {
// aria-unsupported-elements // aria-unsupported-elements
@ -51,7 +51,7 @@ const aria_attributes = 'activedescendant atomic autocomplete busy checked colin
' ' ' '
); );
const aria_attribute_set = new Set(aria_attributes); const aria_attribute_set = new Set(aria_attributes);
function unknownAriaAttribute(attribute: Attribute, name: string) { function unknown_aria_attribute(attribute: Attribute, name: string) {
if (name.startsWith('aria-')) { if (name.startsWith('aria-')) {
const type = name.slice(5); const type = name.slice(5);
if (!aria_attribute_set.has(type)) { if (!aria_attribute_set.has(type)) {
@ -67,7 +67,7 @@ function unknownAriaAttribute(attribute: Attribute, name: string) {
} }
} }
function noAriaHidden(attribute: Attribute, name: string) { function no_aria_hidden(attribute: Attribute, name: string) {
if (name === 'aria-hidden' && /^h[1-6]$/.test(attribute.parent.name)) { if (name === 'aria-hidden' && /^h[1-6]$/.test(attribute.parent.name)) {
attribute.parent.component.warn(attribute, { attribute.parent.component.warn(attribute, {
code: `a11y-hidden`, code: `a11y-hidden`,
@ -76,7 +76,7 @@ function noAriaHidden(attribute: Attribute, name: string) {
} }
} }
function noMisplacedRole(attribute: Attribute, name: string) { function no_misplaced_role(attribute: Attribute, name: string) {
if (name === 'role') { if (name === 'role') {
if (invisible_elements.has(attribute.parent.name)) { if (invisible_elements.has(attribute.parent.name)) {
// aria-unsupported-elements // aria-unsupported-elements
@ -88,9 +88,11 @@ function noMisplacedRole(attribute: Attribute, name: string) {
} }
} }
const aria_roles = 'alert alertdialog application article banner button cell checkbox columnheader combobox command complementary composite contentinfo definition dialog directory document feed figure form grid gridcell group heading img input landmark link list listbox listitem log main marquee math menu menubar menuitem menuitemcheckbox menuitemradio navigation none note option presentation progressbar radio radiogroup range region roletype row rowgroup rowheader scrollbar search searchbox section sectionhead select separator slider spinbutton status structure switch tab table tablist tabpanel term textbox timer toolbar tooltip tree treegrid treeitem widget window'.split(' '); const aria_roles = 'alert alertdialog application article banner button cell checkbox columnheader combobox command complementary composite contentinfo definition dialog directory document feed figure form grid gridcell group heading img input landmark link list listbox listitem log main marquee math menu menubar menuitem menuitemcheckbox menuitemradio navigation none note option presentation progressbar radio radiogroup range region roletype row rowgroup rowheader scrollbar search searchbox section sectionhead select separator slider spinbutton status structure switch tab table tablist tabpanel term textbox timer toolbar tooltip tree treegrid treeitem widget window'.split(
' '
);
const aria_role_set = new Set(aria_roles); const aria_role_set = new Set(aria_roles);
function noUnknownRole(attribute: Attribute, name: string) { function no_unknown_role(attribute: Attribute, name: string) {
if (name === 'role') { if (name === 'role') {
const value = attribute.get_static_value(); const value = attribute.get_static_value();
// @ts-ignore // @ts-ignore
@ -108,7 +110,7 @@ function noUnknownRole(attribute: Attribute, name: string) {
} }
} }
function noAccessKey(attribute: Attribute, name: string) { function no_access_key(attribute: Attribute, name: string) {
// no-access-key // no-access-key
if (name === 'accesskey') { if (name === 'accesskey') {
attribute.parent.component.warn(attribute, { attribute.parent.component.warn(attribute, {
@ -118,8 +120,12 @@ function noAccessKey(attribute: Attribute, name: string) {
} }
} }
function noMisplacedScope(attribute: Attribute, name: string) { function no_misplaced_scope(attribute: Attribute, name: string) {
if (name === 'scope' && attribute.parent.type === 'Element' && attribute.parent.name !== 'th') { if (
name === 'scope' &&
attribute.parent.type === 'Element' &&
attribute.parent.name !== 'th'
) {
attribute.parent.component.warn(attribute, { attribute.parent.component.warn(attribute, {
code: `a11y-misplaced-scope`, code: `a11y-misplaced-scope`,
message: `A11y: The scope attribute should only be used with <th> elements`, message: `A11y: The scope attribute should only be used with <th> elements`,
@ -127,7 +133,7 @@ function noMisplacedScope(attribute: Attribute, name: string) {
} }
} }
function tabindexNoPositive(attribute: Attribute, name: string) { function tabindex_no_positive(attribute: Attribute, name: string) {
// tabindex-no-positive // tabindex-no-positive
if (name === 'tabindex') { if (name === 'tabindex') {
const value = attribute.get_static_value(); const value = attribute.get_static_value();

@ -1,10 +1,10 @@
import Element from '../../nodes/Element'; import Element from '../../nodes/Element';
const validators = [ const validators = [
noDistractingElements, no_distracting_elements,
structure, structure,
noMissingAttribute, no_missing_attribute,
requiredContent, required_content,
]; ];
export default function validateA11y(element: Element) { export default function validateA11y(element: Element) {
@ -14,7 +14,7 @@ export default function validateA11y(element: Element) {
} }
const a11y_distracting_elements = new Set(['blink', 'marquee']); const a11y_distracting_elements = new Set(['blink', 'marquee']);
function noDistractingElements(element: Element) { function no_distracting_elements(element: Element) {
if (a11y_distracting_elements.has(element.name)) { if (a11y_distracting_elements.has(element.name)) {
// no-distracting-elements // no-distracting-elements
element.component.warn(element, { element.component.warn(element, {
@ -80,7 +80,7 @@ const a11y_required_attributes = {
object: ['title', 'aria-label', 'aria-labelledby'], object: ['title', 'aria-label', 'aria-labelledby'],
}; };
function noMissingAttribute(element: Element) { function no_missing_attribute(element: Element) {
const attribute_map = new Map(); const attribute_map = new Map();
element.attributes.forEach(attribute => { element.attributes.forEach(attribute => {
@ -164,7 +164,7 @@ const a11y_required_content = new Set([
'h5', 'h5',
'h6', 'h6',
]); ]);
function requiredContent(element: Element) { function required_content(element: Element) {
if (!a11y_required_content.has(element.name)) return; if (!a11y_required_content.has(element.name)) return;
if (element.children.length === 0) { if (element.children.length === 0) {

Loading…
Cancel
Save