tidy - name convetion. minor refactor extract "is template" check to a variable and replace usages.

pull/7297/head
lidlanca 5 years ago committed by GitHub
parent 403c966da0
commit 257732e238
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -288,11 +288,12 @@ export default class ElementWrapper extends Wrapper {
} }
// insert static children with textContent or innerHTML // insert static children with textContent or innerHTML
// skip textcontent for <template>. append nodes to TemplateElement.content instead
const can_use_textcontent = this.can_use_textcontent(); const can_use_textcontent = this.can_use_textcontent();
const isTemplate = this.node.name == 'template'; const is_template = this.node.name === 'template';
// skip textcontent logic for <template>. should append to the template .content const is_template_with_text_content = is_template && can_use_textcontent;
const isTemplateWithTextContent = isTemplate && can_use_textcontent;
if (!isTemplateWithTextContent && !this.node.namespace && (this.can_use_innerhtml || can_use_textcontent) && this.fragment.nodes.length > 0) { if (!is_template_with_text_content && !this.node.namespace && (this.can_use_innerhtml || can_use_textcontent) && this.fragment.nodes.length > 0) {
if (this.fragment.nodes.length === 1 && this.fragment.nodes[0].node.type === 'Text') { if (this.fragment.nodes.length === 1 && this.fragment.nodes[0].node.type === 'Text') {
block.chunks.create.push( block.chunks.create.push(
b`${node}.textContent = ${string_literal((this.fragment.nodes[0] as TextWrapper).data)};` b`${node}.textContent = ${string_literal((this.fragment.nodes[0] as TextWrapper).data)};`
@ -323,7 +324,7 @@ export default class ElementWrapper extends Wrapper {
this.fragment.nodes.forEach((child: Wrapper) => { this.fragment.nodes.forEach((child: Wrapper) => {
child.render( child.render(
block, block,
this.node.name === 'template' ? x`${node}.content` : node, is_template ? x`${node}.content` : node,
nodes nodes
); );
}); });

Loading…
Cancel
Save