msb-public
/
svelte
mirror of https://github.com/sveltejs/svelte
1
0
Code Issues Projects Releases Wiki Activity

remove hardcoded component reference

Browse Source
pull/468/head
Rich Harris 9 years ago
parent 79b5ce090e
commit 2069372369
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File

12
src/generators/dom/visitors/Element/meta/Window.js
Unescape View File

@ -109,19 +109,19 @@ export default function visitWindow ( generator, block, node ) {
block.builders.create.addBlock( deindent` block.builders.create.addBlock( deindent`
function ${observerCallback} () { function ${observerCallback} () {
if ( ${lock} ) return; if ( ${lock} ) return;
var x = ${bindings.scrollX ? `component.get( '${bindings.scrollX}' )` : `window.scrollX`}; var x = ${bindings.scrollX ? `${block.component}.get( '${bindings.scrollX}' )` : `window.scrollX`};
var y = ${bindings.scrollY ? `component.get( '${bindings.scrollY}' )` : `window.scrollY`}; var y = ${bindings.scrollY ? `${block.component}.get( '${bindings.scrollY}' )` : `window.scrollY`};
window.scrollTo( x, y ); window.scrollTo( x, y );
}; };
` ); ` );
if ( bindings.scrollX ) block.builders.create.addLine( `component.observe( '${bindings.scrollX}', ${observerCallback} );` ); if ( bindings.scrollX ) block.builders.create.addLine( `${block.component}.observe( '${bindings.scrollX}', ${observerCallback} );` );
if ( bindings.scrollY ) block.builders.create.addLine( `component.observe( '${bindings.scrollY}', ${observerCallback} );` ); if ( bindings.scrollY ) block.builders.create.addLine( `${block.component}.observe( '${bindings.scrollY}', ${observerCallback} );` );
} else if ( bindings.scrollX || bindings.scrollY ) { } else if ( bindings.scrollX || bindings.scrollY ) {
const isX = !!bindings.scrollX; const isX = !!bindings.scrollX;
block.builders.create.addBlock( deindent` block.builders.create.addBlock( deindent`
component.observe( '${bindings.scrollX || bindings.scrollY}', function ( ${isX ? 'x' : 'y'} ) { ${block.component}.observe( '${bindings.scrollX || bindings.scrollY}', function ( ${isX ? 'x' : 'y'} ) {
if ( ${lock} ) return; if ( ${lock} ) return;
window.scrollTo( ${isX ? 'x, window.scrollY' : 'window.scrollX, y' } ); window.scrollTo( ${isX ? 'x, window.scrollY' : 'window.scrollX, y' } );
}); });
@ -133,7 +133,7 @@ export default function visitWindow ( generator, block, node ) {
const handlerName = block.getUniqueName( `onlinestatuschanged` ); const handlerName = block.getUniqueName( `onlinestatuschanged` );
block.builders.create.addBlock( deindent` block.builders.create.addBlock( deindent`
function ${handlerName} ( event ) { function ${handlerName} ( event ) {
component.set({ ${bindings.online}: navigator.onLine }); ${block.component}.set({ ${bindings.online}: navigator.onLine });
}; };
window.addEventListener( 'online', ${handlerName} ); window.addEventListener( 'online', ${handlerName} );
window.addEventListener( 'offline', ${handlerName} ); window.addEventListener( 'offline', ${handlerName} );

Write Preview
Loading…
Cancel
Save