[fix] omit a11y warning on <video> when aria-hidden="true" (#7874)

* omit a11y warning on <video> when aria-hidden="true" \ \ * add test
4 years ago · 0dc9b11037
parent 25a05bf952
commit 0dc9b11037
2 changed files with 6 additions and 1 deletions
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@ -686,7 +686,10 @@ export default class Element extends Node {
 		}

 		if (this.name === 'video') {
-			if (attribute_map.has('muted')) {
+			const aria_hidden_attribute = attribute_map.get('aria-hidden');
+			const aria_hidden_exist = aria_hidden_attribute && aria_hidden_attribute.get_static_value();
+
+			if (attribute_map.has('muted') || aria_hidden_exist) {
 				return;
 			}

--- a/test/validator/samples/a11y-media-has-caption/input.svelte
+++ b/test/validator/samples/a11y-media-has-caption/input.svelte
@ -1,4 +1,6 @@
 <video><track kind="captions"/></video>
+<video aria-hidden></video>
+<video aria-hidden="false"></video>
 <video></video>
 <video><track /></video>
 <audio></audio>