chore: remove some todos (#16515)

* chore: remove some todos

* fix

* fix

* doh

* convert `TemplateComment` back to `Comment`

* `Evaluation.has_unknown`

.changeset/happy-countries-dance.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+chore: remove some todos

packages/svelte/src/compiler/migrate/index.js

@@ -1707,14 +1707,14 @@ function extract_type_and_comment(declarator, state, path) {
 }
 
 // Ensure modifiers are applied in the same order as Svelte 4
-const modifier_order = [
+const modifier_order = /** @type {const} */ ([
 	'preventDefault',
 	'stopPropagation',
 	'stopImmediatePropagation',
 	'self',
 	'trusted',
 	'once'
-];
+]);
 
 /**
  * @param {AST.RegularElement | AST.SvelteElement | AST.SvelteWindow | AST.SvelteDocument | AST.SvelteBody} element

packages/svelte/src/compiler/phases/1-parse/index.js

@@ -1,5 +1,4 @@
 /** @import { AST } from '#compiler' */
-/** @import { Comment } from 'estree' */
 // @ts-expect-error acorn type definitions are borked in the release we use
 import { isIdentifierStart, isIdentifierChar } from 'acorn';
 import fragment from './state/fragment.js';

packages/svelte/src/compiler/phases/3-transform/client/visitors/CallExpression.js

@@ -82,7 +82,9 @@ export function CallExpression(node, context) {
 		['debug', 'dir', 'error', 'group', 'groupCollapsed', 'info', 'log', 'trace', 'warn'].includes(
 			node.callee.property.name
 		) &&
-		node.arguments.some((arg) => arg.type !== 'Literal') // TODO more cases?
+		node.arguments.some(
+			(arg) => arg.type === 'SpreadElement' || context.state.scope.evaluate(arg).has_unknown
+		)
 	) {
 		return b.call(
 			node.callee,

packages/svelte/src/compiler/phases/3-transform/client/visitors/OnDirective.js

@@ -3,14 +3,14 @@
 import * as b from '#compiler/builders';
 import { build_event, build_event_handler } from './shared/events.js';
 
-const modifiers = [
+const modifiers = /** @type {const} */ ([
 	'stopPropagation',
 	'stopImmediatePropagation',
 	'preventDefault',
 	'self',
 	'trusted',
 	'once'
-];
+]);
 
 /**
  * @param {AST.OnDirective} node

packages/svelte/src/compiler/phases/scope.js

@@ -180,6 +180,13 @@ class Evaluation {
 	 */
 	is_known = true;
 
+	/**
+	 * True if the possible values contains `UNKNOWN`
+	 * @readonly
+	 * @type {boolean}
+	 */
+	has_unknown = false;
+
 	/**
 	 * True if the value is known to not be null/undefined
 	 * @readonly
@@ -540,6 +547,10 @@ class Evaluation {
 			if (value == null || value === UNKNOWN) {
 				this.is_defined = false;
 			}
+
+			if (value === UNKNOWN) {
+				this.has_unknown = true;
+			}
 		}
 
 		if (this.values.size > 1 || typeof this.value === 'symbol') {

packages/svelte/src/compiler/types/template.d.ts

@@ -247,7 +247,17 @@ export namespace AST {
 		name: string;
 		/** The 'y' in `on:x={y}` */
 		expression: null | Expression;
-		modifiers: string[]; // TODO specify
+		modifiers: Array<
+			| 'capture'
+			| 'nonpassive'
+			| 'once'
+			| 'passive'
+			| 'preventDefault'
+			| 'self'
+			| 'stopImmediatePropagation'
+			| 'stopPropagation'
+			| 'trusted'
+		>;
 		/** @internal */
 		metadata: {
 			expression: ExpressionMetadata;

packages/svelte/types/index.d.ts

@@ -1296,7 +1296,17 @@ declare module 'svelte/compiler' {
 			name: string;
 			/** The 'y' in `on:x={y}` */
 			expression: null | Expression;
-			modifiers: string[];
+			modifiers: Array<
+				| 'capture'
+				| 'nonpassive'
+				| 'once'
+				| 'passive'
+				| 'preventDefault'
+				| 'self'
+				| 'stopImmediatePropagation'
+				| 'stopPropagation'
+				| 'trusted'
+			>;
 		}
 
 		/** A `style:` directive */