ensure onrender and onteardown are not arrow function expressions

src/validate/js/propValidators/onrender.js

@@ -1,3 +1,9 @@
-export default function onrender () {
+import usesThisOrArguments from '../utils/usesThisOrArguments.js';
 
+export default function onrender ( validator, prop ) {
+	if ( prop.value.type === 'ArrowFunctionExpression' ) {
+		if ( usesThisOrArguments( prop.value.body ) ) {
+			validator.error( `'onrender' should be a function expression, not an arrow function expression`, prop.start );
+		}
+	}
 }

src/validate/js/propValidators/onteardown.js

@@ -1,3 +1,9 @@
-export default function onteardown () {
+import usesThisOrArguments from '../utils/usesThisOrArguments.js';
 
+export default function onteardown ( validator, prop ) {
+	if ( prop.value.type === 'ArrowFunctionExpression' ) {
+		if ( usesThisOrArguments( prop.value.body ) ) {
+			validator.error( `'onteardown' should be a function expression, not an arrow function expression`, prop.start );
+		}
+	}
 }

test/validator/onrender-arrow-no-this/errors.json

@@ -0,0 +1 @@
+[]

test/validator/onrender-arrow-no-this/input.html

@@ -0,0 +1,5 @@
+<script>
+	export default {
+		onrender: () => console.log( 'rendering' )
+	};
+</script>

test/validator/onrender-arrow-this/errors.json

@@ -0,0 +1,8 @@
+[{
+	"message": "'onrender' should be a function expression, not an arrow function expression",
+	"pos": 29,
+	"loc": {
+		"line": 3,
+		"column": 2
+	}
+}]

test/validator/onrender-arrow-this/input.html

@@ -0,0 +1,7 @@
+<script>
+	export default {
+		onrender: () => {
+			this.set({ a: 1 });
+		}
+	};
+</script>

test/validator/onteardown-arrow-no-this/errors.json

@@ -0,0 +1 @@
+[]

test/validator/onteardown-arrow-no-this/input.html

@@ -0,0 +1,5 @@
+<script>
+	export default {
+		onteardown: () => console.log( 'tearing down' )
+	};
+</script>

test/validator/onteardown-arrow-this/errors.json

@@ -0,0 +1,8 @@
+[{
+	"message": "'onteardown' should be a function expression, not an arrow function expression",
+	"pos": 29,
+	"loc": {
+		"line": 3,
+		"column": 2
+	}
+}]

test/validator/onteardown-arrow-this/input.html

@@ -0,0 +1,7 @@
+<script>
+	export default {
+		onteardown: () => {
+			this.set({ a: 1 });
+		}
+	};
+</script>