Optimize:optimize SpringValueProcessor (#668)
lingxiao,wu
2 years ago
committed by
GitHub
parent
625f919cf4
commit
61846a3aaf
@ -1,3 +1,4 @@
|
|||||||
# Change Log
|
# Change Log
|
||||||
---
|
---
|
||||||
|
|
||||||
|
- [Optimize:optimize SpringValueProcessor.](https://github.com/Tencent/spring-cloud-tencent/pull/668)
|
||||||
|
|||||||
@ -1,126 +0,0 @@
|
|||||||
/*
|
|
||||||
* Tencent is pleased to support the open source community by making Spring Cloud Tencent available.
|
|
||||||
*
|
|
||||||
* Copyright (C) 2019 THL A29 Limited, a Tencent company. All rights reserved.
|
|
||||||
*
|
|
||||||
* Licensed under the BSD 3-Clause License (the "License");
|
|
||||||
* you may not use this file except in compliance with the License.
|
|
||||||
* You may obtain a copy of the License at
|
|
||||||
*
|
|
||||||
* https://opensource.org/licenses/BSD-3-Clause
|
|
||||||
*
|
|
||||||
* Unless required by applicable law or agreed to in writing, software distributed
|
|
||||||
* under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
|
|
||||||
* CONDITIONS OF ANY KIND, either express or implied. See the License for the
|
|
||||||
* specific language governing permissions and limitations under the License.
|
|
||||||
*/
|
|
||||||
|
|
||||||
package com.tencent.cloud.polaris.config.spring.property;
|
|
||||||
|
|
||||||
import java.util.List;
|
|
||||||
import java.util.Map;
|
|
||||||
import java.util.Set;
|
|
||||||
|
|
||||||
import com.google.common.collect.LinkedListMultimap;
|
|
||||||
import com.google.common.collect.Maps;
|
|
||||||
import com.google.common.collect.Multimap;
|
|
||||||
import com.google.common.collect.Sets;
|
|
||||||
import com.tencent.cloud.polaris.config.config.PolarisConfigProperties;
|
|
||||||
|
|
||||||
import org.springframework.beans.BeansException;
|
|
||||||
import org.springframework.beans.MutablePropertyValues;
|
|
||||||
import org.springframework.beans.PropertyValue;
|
|
||||||
import org.springframework.beans.factory.config.BeanDefinition;
|
|
||||||
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
|
|
||||||
import org.springframework.beans.factory.config.TypedStringValue;
|
|
||||||
import org.springframework.beans.factory.support.BeanDefinitionRegistry;
|
|
||||||
import org.springframework.beans.factory.support.BeanDefinitionRegistryPostProcessor;
|
|
||||||
import org.springframework.lang.NonNull;
|
|
||||||
|
|
||||||
/**
|
|
||||||
* To process xml config placeholders, e.g.
|
|
||||||
*
|
|
||||||
* <pre>
|
|
||||||
* <bean class="com.demo.bean.XmlBean">
|
|
||||||
* <property name="timeout" value="${timeout:200}"/>
|
|
||||||
* <property name="batch" value="${batch:100}"/>
|
|
||||||
* </bean>
|
|
||||||
* </pre>
|
|
||||||
*
|
|
||||||
* This source file was originally from:
|
|
||||||
* <code><a href=https://github.com/apolloconfig/apollo/blob/master/apollo-client/src/main/java/com/ctrip/framework/apollo/spring/property/SpringValueDefinitionProcessor.java>
|
|
||||||
* SpringValueDefinitionProcessor</a></code>
|
|
||||||
*
|
|
||||||
* @author weihubeats 2022-7-10
|
|
||||||
*/
|
|
||||||
public class SpringValueDefinitionProcessor implements BeanDefinitionRegistryPostProcessor {
|
|
||||||
private static final Map<BeanDefinitionRegistry, Multimap<String, SpringValueDefinition>> beanName2SpringValueDefinitions =
|
|
||||||
Maps.newConcurrentMap();
|
|
||||||
private static final Set<BeanDefinitionRegistry> PROPERTY_VALUES_PROCESSED_BEAN_FACTORIES = Sets.newConcurrentHashSet();
|
|
||||||
|
|
||||||
private final PlaceholderHelper placeholderHelper;
|
|
||||||
|
|
||||||
private final PolarisConfigProperties polarisConfigProperties;
|
|
||||||
|
|
||||||
public SpringValueDefinitionProcessor(PlaceholderHelper placeholderHelper, PolarisConfigProperties polarisConfigProperties) {
|
|
||||||
this.polarisConfigProperties = polarisConfigProperties;
|
|
||||||
this.placeholderHelper = placeholderHelper;
|
|
||||||
}
|
|
||||||
|
|
||||||
public static Multimap<String, SpringValueDefinition> getBeanName2SpringValueDefinitions(BeanDefinitionRegistry registry) {
|
|
||||||
Multimap<String, SpringValueDefinition> springValueDefinitions = beanName2SpringValueDefinitions.get(registry);
|
|
||||||
if (springValueDefinitions == null) {
|
|
||||||
springValueDefinitions = LinkedListMultimap.create();
|
|
||||||
}
|
|
||||||
|
|
||||||
return springValueDefinitions;
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
|
||||||
public void postProcessBeanDefinitionRegistry(@NonNull BeanDefinitionRegistry registry) throws BeansException {
|
|
||||||
if (polarisConfigProperties.isAutoRefresh()) {
|
|
||||||
processPropertyValues(registry);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
|
||||||
public void postProcessBeanFactory(@NonNull ConfigurableListableBeanFactory beanFactory) throws BeansException {
|
|
||||||
|
|
||||||
}
|
|
||||||
|
|
||||||
private void processPropertyValues(BeanDefinitionRegistry beanRegistry) {
|
|
||||||
if (!PROPERTY_VALUES_PROCESSED_BEAN_FACTORIES.add(beanRegistry)) {
|
|
||||||
// already initialized
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!beanName2SpringValueDefinitions.containsKey(beanRegistry)) {
|
|
||||||
beanName2SpringValueDefinitions.put(beanRegistry, LinkedListMultimap.create());
|
|
||||||
}
|
|
||||||
|
|
||||||
Multimap<String, SpringValueDefinition> springValueDefinitions = beanName2SpringValueDefinitions.get(beanRegistry);
|
|
||||||
|
|
||||||
String[] beanNames = beanRegistry.getBeanDefinitionNames();
|
|
||||||
for (String beanName : beanNames) {
|
|
||||||
BeanDefinition beanDefinition = beanRegistry.getBeanDefinition(beanName);
|
|
||||||
MutablePropertyValues mutablePropertyValues = beanDefinition.getPropertyValues();
|
|
||||||
List<PropertyValue> propertyValues = mutablePropertyValues.getPropertyValueList();
|
|
||||||
for (PropertyValue propertyValue : propertyValues) {
|
|
||||||
Object value = propertyValue.getValue();
|
|
||||||
if (!(value instanceof TypedStringValue)) {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
String placeholder = ((TypedStringValue) value).getValue();
|
|
||||||
Set<String> keys = placeholderHelper.extractPlaceholderKeys(placeholder);
|
|
||||||
|
|
||||||
if (keys.isEmpty()) {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
for (String key : keys) {
|
|
||||||
springValueDefinitions.put(beanName, new SpringValueDefinition(key, placeholder, propertyValue.getName()));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@ -1,75 +0,0 @@
|
|||||||
/*
|
|
||||||
* Tencent is pleased to support the open source community by making Spring Cloud Tencent available.
|
|
||||||
*
|
|
||||||
* Copyright (C) 2019 THL A29 Limited, a Tencent company. All rights reserved.
|
|
||||||
*
|
|
||||||
* Licensed under the BSD 3-Clause License (the "License");
|
|
||||||
* you may not use this file except in compliance with the License.
|
|
||||||
* You may obtain a copy of the License at
|
|
||||||
*
|
|
||||||
* https://opensource.org/licenses/BSD-3-Clause
|
|
||||||
*
|
|
||||||
* Unless required by applicable law or agreed to in writing, software distributed
|
|
||||||
* under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
|
|
||||||
* CONDITIONS OF ANY KIND, either express or implied. See the License for the
|
|
||||||
* specific language governing permissions and limitations under the License.
|
|
||||||
*
|
|
||||||
*/
|
|
||||||
|
|
||||||
package com.tencent.cloud.polaris.config.spring.property;
|
|
||||||
|
|
||||||
import java.lang.reflect.Method;
|
|
||||||
import java.util.Collection;
|
|
||||||
import java.util.Objects;
|
|
||||||
import java.util.Optional;
|
|
||||||
|
|
||||||
import com.tencent.polaris.api.utils.CollectionUtils;
|
|
||||||
import org.junit.Assert;
|
|
||||||
import org.junit.Test;
|
|
||||||
|
|
||||||
import org.springframework.beans.factory.BeanFactory;
|
|
||||||
import org.springframework.context.support.ClassPathXmlApplicationContext;
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Test for {@link SpringValueDefinitionProcessor}.
|
|
||||||
*
|
|
||||||
* @author lingxiao.wlx
|
|
||||||
*/
|
|
||||||
public class SpringValueDefinitionProcessorTest {
|
|
||||||
|
|
||||||
@Test
|
|
||||||
public void springValueDefinitionProcessorTest() {
|
|
||||||
ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext("bean.xml");
|
|
||||||
Person person = context.getBean(Person.class);
|
|
||||||
|
|
||||||
SpringValueRegistry springValueRegistry = context.getBean(SpringValueRegistry.class);
|
|
||||||
|
|
||||||
BeanFactory beanFactory = person.getBeanFactory();
|
|
||||||
Collection<SpringValue> name = springValueRegistry.get(beanFactory, "name");
|
|
||||||
Assert.assertFalse(CollectionUtils.isEmpty(name));
|
|
||||||
Optional<SpringValue> nameSpringValueOptional = name.stream().findAny();
|
|
||||||
Assert.assertTrue(nameSpringValueOptional.isPresent());
|
|
||||||
|
|
||||||
SpringValue nameSpringValue = nameSpringValueOptional.get();
|
|
||||||
Method method = nameSpringValue.getMethodParameter().getMethod();
|
|
||||||
Assert.assertTrue(Objects.nonNull(method));
|
|
||||||
Assert.assertEquals("setName", method.getName());
|
|
||||||
Assert.assertEquals("${name:test}", nameSpringValue.getPlaceholder());
|
|
||||||
Assert.assertFalse(nameSpringValue.isField());
|
|
||||||
Assert.assertEquals(String.class, nameSpringValue.getTargetType());
|
|
||||||
|
|
||||||
|
|
||||||
Collection<SpringValue> age = springValueRegistry.get(beanFactory, "age");
|
|
||||||
Assert.assertFalse(CollectionUtils.isEmpty(age));
|
|
||||||
Optional<SpringValue> ageSpringValueOptional = age.stream().findAny();
|
|
||||||
Assert.assertTrue(ageSpringValueOptional.isPresent());
|
|
||||||
|
|
||||||
SpringValue ageSpringValue = ageSpringValueOptional.get();
|
|
||||||
Method method1 = ageSpringValue.getMethodParameter().getMethod();
|
|
||||||
Assert.assertTrue(Objects.nonNull(method1));
|
|
||||||
Assert.assertEquals("setAge", method1.getName());
|
|
||||||
Assert.assertEquals("${age:10}", ageSpringValue.getPlaceholder());
|
|
||||||
Assert.assertFalse(ageSpringValue.isField());
|
|
||||||
Assert.assertEquals(String.class, ageSpringValue.getTargetType());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Loading…
Reference in new issue