refactor: optimize log (#1684)

Co-authored-by: shedfreewu <49236872+shedfreewu@users.noreply.github.com>
pull/1685/head
Fishtail 1 month ago committed by GitHub
parent 61aba281e7
commit 5d39d932be
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -10,3 +10,4 @@
- [fix: fix ConfigChangeListener ut bug](https://github.com/Tencent/spring-cloud-tencent/pull/1661) - [fix: fix ConfigChangeListener ut bug](https://github.com/Tencent/spring-cloud-tencent/pull/1661)
- [fix: tsf 2024 related bugfixes](https://github.com/Tencent/spring-cloud-tencent/pull/1682) - [fix: tsf 2024 related bugfixes](https://github.com/Tencent/spring-cloud-tencent/pull/1682)
- [fix: remove conflict dependencies management](https://github.com/Tencent/spring-cloud-tencent/pull/1683) - [fix: remove conflict dependencies management](https://github.com/Tencent/spring-cloud-tencent/pull/1683)
- [refactor: optimize log](https://github.com/Tencent/spring-cloud-tencent/pull/1684)

@ -118,7 +118,7 @@ public class MetadataContext extends com.tencent.polaris.metadata.core.manager.M
.getProperties("spring.application.name", null)); .getProperties("spring.application.name", null));
} }
if (!StringUtils.hasText(serviceName)) { if (!StringUtils.hasText(serviceName)) {
LOG.error("service name should not be blank. please configure spring.cloud.polaris.service or " LOG.warn("service name should not be blank. please configure spring.cloud.polaris.service or "
+ "spring.cloud.polaris.discovery.service or spring.application.name"); + "spring.cloud.polaris.discovery.service or spring.application.name");
} }
serviceName = DiscoveryUtil.rewriteServiceId(serviceName); serviceName = DiscoveryUtil.rewriteServiceId(serviceName);

@ -59,7 +59,7 @@ public class ApplicationContextAwareUtils implements ApplicationContextAware {
if (applicationContext != null) { if (applicationContext != null) {
return applicationContext.getEnvironment().getProperty(key); return applicationContext.getEnvironment().getProperty(key);
} }
LOGGER.warn("applicationContext is null, try to get property from System.getenv or System.getProperty"); LOGGER.warn("applicationContext is null, try to get property({}} from System.getenv or System.getProperty", key);
String property = System.getenv(key); String property = System.getenv(key);
if (StringUtils.isBlank(property)) { if (StringUtils.isBlank(property)) {
property = System.getProperty(key); property = System.getProperty(key);
@ -77,7 +77,7 @@ public class ApplicationContextAwareUtils implements ApplicationContextAware {
if (applicationContext != null) { if (applicationContext != null) {
return applicationContext.getEnvironment().getProperty(key, defaultValue); return applicationContext.getEnvironment().getProperty(key, defaultValue);
} }
LOGGER.warn("applicationContext is null, try to get property from System.getenv or System.getProperty"); LOGGER.warn("applicationContext is null, try to get property({}} from System.getenv or System.getProperty", key);
String property = System.getenv(key); String property = System.getenv(key);
if (StringUtils.isBlank(property)) { if (StringUtils.isBlank(property)) {
property = System.getProperty(key, defaultValue); property = System.getProperty(key, defaultValue);

Loading…
Cancel
Save