fix heartbeatEnabled and heartbeatInterval must be in PolarisDiscoveryProperties.

pull/1621/head
zihenz 2 months ago
parent 7039da1ad9
commit 4c37912757

@ -80,21 +80,20 @@ public class PolarisDiscoveryProperties {
/** /**
* Enable heartbeat or not. * Enable heartbeat or not.
*/ */
@Value("${spring.cloud.polaris.discovery.heartbeat.enabled:true}") @Value("${spring.cloud.polaris.discovery.heartbeat-enabled:true}")
private Boolean heartbeatEnabled = true; private Boolean heartbeatEnabled = true;
/** /**
* If instance registered. * Heartbeat interval (seconds).
*/ */
@Value("${spring.cloud.polaris.discovery.register:#{true}}") @Value("${spring.cloud.polaris.discovery.heartbeat-interval:5}")
private Boolean registerEnabled; private Integer heartbeatInterval = 5;
/** /**
* Heartbeat interval ( 0 < interval <= 60). * If instance registered.
* Time unit: second. Default: 5.
* @see ContextConstant#DEFAULT_REGISTRY_HEARTBEAT_TIME_INTERVAL
*/ */
private Integer heartbeatInterval = DEFAULT_REGISTRY_HEARTBEAT_TIME_INTERVAL; @Value("${spring.cloud.polaris.discovery.register:#{true}}")
private Boolean registerEnabled;
/** /**
* Custom health check url to override default. * Custom health check url to override default.

@ -81,12 +81,6 @@ public class PolarisServiceRegistry implements ServiceRegistry<PolarisRegistrati
private final StaticMetadataManager staticMetadataManager; private final StaticMetadataManager staticMetadataManager;
private final PolarisStatProperties polarisStatProperties; private final PolarisStatProperties polarisStatProperties;
@Value("${spring.cloud.polaris.discovery.heartbeat-enabled:true}")
private Boolean heartbeatEnabled = true;
@Value("${spring.cloud.polaris.discovery.heartbeat-interval:5}")
private Integer heartbeatInterval = 5;
public PolarisServiceRegistry(PolarisDiscoveryProperties polarisDiscoveryProperties, public PolarisServiceRegistry(PolarisDiscoveryProperties polarisDiscoveryProperties,
PolarisSDKContextManager polarisSDKContextManager, PolarisDiscoveryHandler polarisDiscoveryHandler, PolarisSDKContextManager polarisSDKContextManager, PolarisDiscoveryHandler polarisDiscoveryHandler,
StaticMetadataManager staticMetadataManager, PolarisStatProperties polarisStatProperties) { StaticMetadataManager staticMetadataManager, PolarisStatProperties polarisStatProperties) {
@ -136,14 +130,14 @@ public class PolarisServiceRegistry implements ServiceRegistry<PolarisRegistrati
ProviderAPI providerClient = polarisSDKContextManager.getProviderAPI(); ProviderAPI providerClient = polarisSDKContextManager.getProviderAPI();
InstanceRegisterResponse instanceRegisterResponse; InstanceRegisterResponse instanceRegisterResponse;
// 结合heartbeatEnabled和healthCheckUrl判断 // heartbeatEnabled and healthCheckUrl
if (!polarisDiscoveryProperties.getHeartbeatEnabled() if (!polarisDiscoveryProperties.getHeartbeatEnabled()
|| StringUtils.isBlank(polarisDiscoveryProperties.getHealthCheckUrl())) { || StringUtils.isBlank(polarisDiscoveryProperties.getHealthCheckUrl())) {
// 不启用心跳 或 未配置healthCheckUrl // Do not enable heartbeat or configure healthCheckURL
instanceRegisterResponse = providerClient.register(instanceRegisterRequest); instanceRegisterResponse = providerClient.register(instanceRegisterRequest);
LOGGER.info("Registered instance without heartbeat."); LOGGER.info("Registered instance without heartbeat.");
} else { } else {
// 启用心跳 且 配置了healthCheckUrl // Enable heartbeat and configure healthCheckURL
instanceRegisterRequest.setTtl(polarisDiscoveryProperties.getHeartbeatInterval()); instanceRegisterRequest.setTtl(polarisDiscoveryProperties.getHeartbeatInterval());
instanceRegisterResponse = providerClient.registerInstance(instanceRegisterRequest); instanceRegisterResponse = providerClient.registerInstance(instanceRegisterRequest);
LOGGER.info("Registered instance with heartbeat enabled."); LOGGER.info("Registered instance with heartbeat enabled.");

Loading…
Cancel
Save