deps:upgrade to spring boot 3.4.12. (#1756)

Signed-off-by: Haotian Zhang <928016560@qq.com>
pull/1758/head
Haotian Zhang 4 weeks ago committed by GitHub
parent 75f72ab023
commit 2b2b9743cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -68,9 +68,9 @@ jobs:
needs: set-jdks needs: set-jdks
steps: steps:
- name: Checkout codes - name: Checkout codes
uses: actions/checkout@v4 uses: actions/checkout@v5
- name: Set up JDK ${{ matrix.java }} - name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v4 uses: actions/setup-java@v5
with: with:
distribution: 'temurin' distribution: 'temurin'
java-version: ${{ matrix.java }} java-version: ${{ matrix.java }}
@ -85,7 +85,7 @@ jobs:
run: mvn clean test -B -U -Psonatype run: mvn clean test -B -U -Psonatype
- name: Upload coverage to Codecov - name: Upload coverage to Codecov
if: matrix.os == 'ubuntu-latest' && matrix.java == 17 if: matrix.os == 'ubuntu-latest' && matrix.java == 17
uses: codecov/codecov-action@v4 uses: codecov/codecov-action@v5
env: env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with: with:

@ -30,6 +30,6 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Checkout codes - name: Checkout codes
uses: actions/checkout@v4 uses: actions/checkout@v5
- name: Check License Header - name: Check License Header
uses: apache/skywalking-eyes@v0.4.0 uses: apache/skywalking-eyes@v0.4.0

@ -8,9 +8,9 @@ jobs:
release: release:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v5
- name: Set up JDK 17 - name: Set up JDK 17
uses: actions/setup-java@v4 uses: actions/setup-java@v5
with: with:
java-version: '17' java-version: '17'
distribution: 'temurin' distribution: 'temurin'

@ -21,7 +21,7 @@ jobs:
IS_SNAPSHOT: ${{ steps.check-deploy-type.outputs.IS_SNAPSHOT }} IS_SNAPSHOT: ${{ steps.check-deploy-type.outputs.IS_SNAPSHOT }}
steps: steps:
- name: Checkout codes - name: Checkout codes
uses: actions/checkout@v4 uses: actions/checkout@v5
- name: Check deploy type - name: Check deploy type
id: check-deploy-type id: check-deploy-type
run: | run: |
@ -65,9 +65,9 @@ jobs:
if: ${{ needs.check-snapshot.outputs.IS_SNAPSHOT == 'true' }} if: ${{ needs.check-snapshot.outputs.IS_SNAPSHOT == 'true' }}
steps: steps:
- name: Checkout codes - name: Checkout codes
uses: actions/checkout@v4 uses: actions/checkout@v5
- name: Set up JDK ${{ needs.set-jdk.outputs.jdk }} - name: Set up JDK ${{ needs.set-jdk.outputs.jdk }}
uses: actions/setup-java@v4 uses: actions/setup-java@v5
with: with:
java-version: ${{ needs.set-jdk.outputs.jdk }} java-version: ${{ needs.set-jdk.outputs.jdk }}
distribution: 'temurin' distribution: 'temurin'

@ -7,3 +7,4 @@
- [feat:support async metadata transfer.](https://github.com/Tencent/spring-cloud-tencent/pull/1743) - [feat:support async metadata transfer.](https://github.com/Tencent/spring-cloud-tencent/pull/1743)
- [fix:replace with string inside @ConditionalOnClass.](https://github.com/Tencent/spring-cloud-tencent/pull/1750) - [fix:replace with string inside @ConditionalOnClass.](https://github.com/Tencent/spring-cloud-tencent/pull/1750)
- [feat: support TagUtils, ContextToHeaderInterceptor in TSF.](https://github.com/Tencent/spring-cloud-tencent/pull/1754) - [feat: support TagUtils, ContextToHeaderInterceptor in TSF.](https://github.com/Tencent/spring-cloud-tencent/pull/1754)
- [deps:upgrade to spring boot 3.4.12.](https://github.com/Tencent/spring-cloud-tencent/pull/1756)

@ -5,7 +5,7 @@
<parent> <parent>
<groupId>org.springframework.cloud</groupId> <groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-build</artifactId> <artifactId>spring-cloud-build</artifactId>
<version>4.2.1</version> <version>4.2.3</version>
<relativePath/> <relativePath/>
</parent> </parent>
<modelVersion>4.0.0</modelVersion> <modelVersion>4.0.0</modelVersion>
@ -93,10 +93,10 @@
<revision>2.1.1.0-2024.0.2-SNAPSHOT</revision> <revision>2.1.1.0-2024.0.2-SNAPSHOT</revision>
<!-- Spring Framework --> <!-- Spring Framework -->
<spring.framework.version>6.2.9</spring.framework.version> <spring.framework.version>6.2.14</spring.framework.version>
<!-- Spring Boot --> <!-- Spring Boot -->
<spring.boot.version>3.4.8</spring.boot.version> <spring.boot.version>3.4.12</spring.boot.version>
<!-- Spring Cloud --> <!-- Spring Cloud -->
<spring.cloud.version>2024.0.2</spring.cloud.version> <spring.cloud.version>2024.0.2</spring.cloud.version>
@ -106,7 +106,6 @@
<!-- Maven Plugin Versions --> <!-- Maven Plugin Versions -->
<jacoco.version>0.8.12</jacoco.version> <jacoco.version>0.8.12</jacoco.version>
<flatten-maven-plugin.version>1.3.0</flatten-maven-plugin.version>
<maven-clean-plugin.version>3.4.0</maven-clean-plugin.version> <maven-clean-plugin.version>3.4.0</maven-clean-plugin.version>
<central.publishing.maven.plugin.version>0.8.0</central.publishing.maven.plugin.version> <central.publishing.maven.plugin.version>0.8.0</central.publishing.maven.plugin.version>
@ -278,7 +277,6 @@
<plugin> <plugin>
<groupId>org.codehaus.mojo</groupId> <groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId> <artifactId>flatten-maven-plugin</artifactId>
<version>${flatten-maven-plugin.version}</version>
<configuration> <configuration>
<updatePomFile>true</updatePomFile> <updatePomFile>true</updatePomFile>
<flattenMode>resolveCiFriendliesOnly</flattenMode> <flattenMode>resolveCiFriendliesOnly</flattenMode>

@ -31,7 +31,6 @@ import com.tencent.cloud.rpc.enhancement.config.RpcEnhancementAutoConfiguration;
import com.tencent.cloud.rpc.enhancement.config.RpcEnhancementPropertiesAutoConfiguration; import com.tencent.cloud.rpc.enhancement.config.RpcEnhancementPropertiesAutoConfiguration;
import com.tencent.polaris.client.util.Utils; import com.tencent.polaris.client.util.Utils;
import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
@ -103,16 +102,16 @@ public class PolarisCircuitBreakerTest {
Method getConfigurationsMethod = ReflectionUtils.findMethod(PolarisCircuitBreakerFactory.class, Method getConfigurationsMethod = ReflectionUtils.findMethod(PolarisCircuitBreakerFactory.class,
"getConfigurations"); "getConfigurations");
Assertions.assertNotNull(getConfigurationsMethod); assertThat(getConfigurationsMethod).isNotNull();
ReflectionUtils.makeAccessible(getConfigurationsMethod); ReflectionUtils.makeAccessible(getConfigurationsMethod);
Map<?, ?> values = (Map<?, ?>) ReflectionUtils.invokeMethod(getConfigurationsMethod, polarisCircuitBreakerFactory); Map<?, ?> values = (Map<?, ?>) ReflectionUtils.invokeMethod(getConfigurationsMethod, polarisCircuitBreakerFactory);
Assertions.assertNotNull(values); assertThat(values).isNotNull();
Assertions.assertEquals(1, values.size()); assertThat(values).hasSize(1);
Utils.sleepUninterrupted(10 * 1000); Utils.sleepUninterrupted(10 * 1000);
Assertions.assertEquals(0, values.size()); assertThat(values).hasSize(0);
}); });
} }

@ -19,13 +19,14 @@ package com.tencent.cloud.polaris.circuitbreaker.common;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension; import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.web.reactive.function.client.WebClientResponseException; import org.springframework.web.reactive.function.client.WebClientResponseException;
import static org.assertj.core.api.Assertions.assertThat;
/** /**
* Test for ${@link PolarisResultToErrorCode}. * Test for ${@link PolarisResultToErrorCode}.
* *
@ -38,7 +39,7 @@ class PolarisResultToErrorCodeTest {
@Test @Test
void testOnSuccess() { void testOnSuccess() {
Assertions.assertEquals(200, converter.onSuccess("any value")); assertThat(converter.onSuccess("any value")).isEqualTo(200);
} }
@Test @Test
@ -51,7 +52,7 @@ class PolarisResultToErrorCodeTest {
int errorCode = converter.onError(exception); int errorCode = converter.onError(exception);
// Then // Then
Assertions.assertEquals(404, errorCode); assertThat(errorCode).isEqualTo(404);
} }
@Test @Test
@ -60,7 +61,7 @@ class PolarisResultToErrorCodeTest {
int errorCode = converter.onError(new RuntimeException("test")); int errorCode = converter.onError(new RuntimeException("test"));
// Then // Then
Assertions.assertEquals(-1, errorCode); assertThat(errorCode).isEqualTo(-1);
} }
@Test @Test
@ -72,7 +73,7 @@ class PolarisResultToErrorCodeTest {
int errorCode = converter.onError(exception); int errorCode = converter.onError(exception);
// Then // Then
Assertions.assertEquals(-1, errorCode); assertThat(errorCode).isEqualTo(-1);
} }
@Test @Test
@ -85,10 +86,11 @@ class PolarisResultToErrorCodeTest {
// test exist class // test exist class
boolean result1 = (boolean) checkClassExist.invoke(converter, "java.lang.String"); boolean result1 = (boolean) checkClassExist.invoke(converter, "java.lang.String");
Assertions.assertTrue(result1); assertThat(result1).isTrue();
// test not exist class // test not exist class
boolean result2 = (boolean) checkClassExist.invoke(converter, "com.nonexistent.Class"); boolean result2 = (boolean) checkClassExist.invoke(converter, "com.nonexistent.Class");
Assertions.assertFalse(result2); assertThat(result2).isFalse();
} }
} }

@ -28,7 +28,6 @@ import com.tencent.polaris.circuitbreak.client.exception.CallAbortedException;
import feign.InvocationHandlerFactory; import feign.InvocationHandlerFactory;
import feign.Target; import feign.Target;
import feign.codec.Decoder; import feign.codec.Decoder;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
@ -37,7 +36,8 @@ import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.cloud.openfeign.FallbackFactory; import org.springframework.cloud.openfeign.FallbackFactory;
import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy; import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -84,20 +84,16 @@ class PolarisFeignCircuitBreakerInvocationHandlerTest {
@Test @Test
void testConstructorWithNullTarget() { void testConstructorWithNullTarget() {
Assertions.assertThrows(NullPointerException.class, () -> assertThatThrownBy(
new PolarisFeignCircuitBreakerInvocationHandler( () -> new PolarisFeignCircuitBreakerInvocationHandler(null, dispatch, fallbackFactory, decoder))
null, dispatch, fallbackFactory, decoder .isInstanceOf(NullPointerException.class);
)
);
} }
@Test @Test
void testConstructorWithNullDispatch() { void testConstructorWithNullDispatch() {
Assertions.assertThrows(NullPointerException.class, () -> assertThatThrownBy(() ->
new PolarisFeignCircuitBreakerInvocationHandler( new PolarisFeignCircuitBreakerInvocationHandler(target, null, fallbackFactory, decoder))
target, null, fallbackFactory, decoder .isInstanceOf(NullPointerException.class);
)
);
} }
@Test @Test
@ -108,9 +104,9 @@ class PolarisFeignCircuitBreakerInvocationHandlerTest {
Map<Method, Method> result = PolarisFeignCircuitBreakerInvocationHandler.toFallbackMethod(testDispatch); Map<Method, Method> result = PolarisFeignCircuitBreakerInvocationHandler.toFallbackMethod(testDispatch);
Assertions.assertNotNull(result); assertThat(result).isNotNull();
Assertions.assertTrue(result.containsKey(method)); assertThat(result).containsKey(method);
Assertions.assertEquals(method, result.get(method)); assertThat(result.get(method)).isEqualTo(method);
} }
@Test @Test
@ -119,10 +115,10 @@ class PolarisFeignCircuitBreakerInvocationHandlerTest {
Object mockProxy = mock(Object.class); Object mockProxy = mock(Object.class);
// Test equals with null // Test equals with null
Assertions.assertFalse((Boolean) handler.invoke(mockProxy, equalsMethod, new Object[] {null})); assertThat((Boolean) handler.invoke(mockProxy, equalsMethod, new Object[] {null})).isFalse();
// Test equals with non-proxy object // Test equals with non-proxy object
Assertions.assertFalse((Boolean) handler.invoke(mockProxy, equalsMethod, new Object[] {new Object()})); assertThat((Boolean) handler.invoke(mockProxy, equalsMethod, new Object[] {new Object()})).isFalse();
} }
@Test @Test
@ -131,7 +127,7 @@ class PolarisFeignCircuitBreakerInvocationHandlerTest {
Object mockProxy = mock(Object.class); Object mockProxy = mock(Object.class);
when(target.toString()).thenReturn("TestTarget"); when(target.toString()).thenReturn("TestTarget");
Assertions.assertEquals("TestTarget", handler.invoke(mockProxy, toStringMethod, null)); assertThat((String) handler.invoke(mockProxy, toStringMethod, null)).isEqualTo("TestTarget");
} }
@Test @Test
@ -178,7 +174,7 @@ class PolarisFeignCircuitBreakerInvocationHandlerTest {
Object result = handler.invoke(null, testMethod, new Object[] {}); Object result = handler.invoke(null, testMethod, new Object[] {});
// Verify // Verify
Assertions.assertEquals(expected, result); assertThat(result).isEqualTo(expected);
} }
@Test @Test
@ -190,8 +186,8 @@ class PolarisFeignCircuitBreakerInvocationHandlerTest {
decoder decoder
); );
Assertions.assertEquals(handler, testHandler); assertThat(testHandler).isEqualTo(handler);
Assertions.assertEquals(handler.hashCode(), testHandler.hashCode()); assertThat(testHandler.hashCode()).isEqualTo(handler.hashCode());
} }
interface TestInterface { interface TestInterface {

@ -20,12 +20,12 @@ package com.tencent.cloud.polaris.circuitbreaker.instrument.feign;
import feign.Feign; import feign.Feign;
import feign.RequestLine; import feign.RequestLine;
import feign.Target; import feign.Target;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.cloud.openfeign.FallbackFactory; import org.springframework.cloud.openfeign.FallbackFactory;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -45,7 +45,7 @@ public class PolarisFeignCircuitBreakerTest {
@Test @Test
public void testBuilderNotNull() { public void testBuilderNotNull() {
Assertions.assertNotNull(builder); assertThat(builder).isNotNull();
} }
@Test @Test
@ -67,8 +67,8 @@ public class PolarisFeignCircuitBreakerTest {
MyService result = builder.target(target, fallback); MyService result = builder.target(target, fallback);
// Verify that the result is not null and the fallback factory is used // Verify that the result is not null and the fallback factory is used
Assertions.assertNotNull(result); assertThat(result).isNotNull();
Assertions.assertEquals("Fallback Hello", result.sayHello()); assertThat(result.sayHello()).isEqualTo("Fallback Hello");
} }
@Test @Test
@ -93,8 +93,8 @@ public class PolarisFeignCircuitBreakerTest {
MyService result = builder.target(target, fallbackFactory); MyService result = builder.target(target, fallbackFactory);
// Verify that the result is not null and the fallback factory is used // Verify that the result is not null and the fallback factory is used
Assertions.assertNotNull(result); assertThat(result).isNotNull();
Assertions.assertEquals("Fallback Hello", result.sayHello()); assertThat(result.sayHello()).isEqualTo("Fallback Hello");
} }
@Test @Test
@ -112,8 +112,7 @@ public class PolarisFeignCircuitBreakerTest {
MyService result = builder.target(target); MyService result = builder.target(target);
// Verify that the result is not null // Verify that the result is not null
Assertions.assertNotNull(result); assertThat(result).isNotNull();
// Additional verifications can be added here based on the implementation
} }
@Test @Test
@ -122,8 +121,7 @@ public class PolarisFeignCircuitBreakerTest {
Feign feign = builder.build(null); Feign feign = builder.build(null);
// Verify that the Feign instance is not null // Verify that the Feign instance is not null
Assertions.assertNotNull(feign); assertThat(feign).isNotNull();
// Additional verifications can be added here based on the implementation
} }
public interface MyService { public interface MyService {

@ -23,11 +23,14 @@ import java.util.HashMap;
import java.util.Map; import java.util.Map;
import com.tencent.polaris.api.pojo.CircuitBreakerStatus; import com.tencent.polaris.api.pojo.CircuitBreakerStatus;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension; import org.mockito.junit.jupiter.MockitoExtension;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatCode;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** /**
* Tests for {@link PolarisCircuitBreakerHttpResponse}. * Tests for {@link PolarisCircuitBreakerHttpResponse}.
* *
@ -39,10 +42,10 @@ public class PolarisCircuitBreakerHttpResponseTest {
void testConstructorWithCodeOnly() throws IOException { void testConstructorWithCodeOnly() throws IOException {
PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200); PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200);
Assertions.assertEquals(200, response.getStatusCode().value()); assertThat(response.getStatusCode().value()).isEqualTo(200);
Assertions.assertNotNull(response.getHeaders()); assertThat(response.getHeaders()).isNotNull();
Assertions.assertTrue(response.getHeaders().isEmpty()); assertThat(response.getHeaders()).isEmpty();
Assertions.assertNull(response.getBody()); assertThat(response.getBody()).isNull();
} }
@Test @Test
@ -50,10 +53,10 @@ public class PolarisCircuitBreakerHttpResponseTest {
String body = "test body"; String body = "test body";
PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200, body); PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200, body);
Assertions.assertEquals(200, response.getStatusCode().value()); assertThat(response.getStatusCode().value()).isEqualTo(200);
Assertions.assertNotNull(response.getHeaders()); assertThat(response.getHeaders()).isNotNull();
Assertions.assertTrue(response.getHeaders().isEmpty()); assertThat(response.getHeaders()).isEmpty();
Assertions.assertNotNull(response.getBody()); assertThat(response.getBody()).isNotNull();
} }
@Test @Test
@ -65,12 +68,12 @@ public class PolarisCircuitBreakerHttpResponseTest {
PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200, headers, body); PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200, headers, body);
Assertions.assertEquals(200, response.getStatusCode().value()); assertThat(response.getStatusCode().value()).isEqualTo(200);
Assertions.assertNotNull(response.getHeaders()); assertThat(response.getHeaders()).isNotNull();
Assertions.assertEquals(2, response.getHeaders().size()); assertThat(response.getHeaders().size()).isEqualTo(2);
Assertions.assertTrue(response.getHeaders().containsKey("Content-Type")); assertThat(response.getHeaders()).containsKey("Content-Type");
Assertions.assertTrue(response.getHeaders().containsKey("Authorization")); assertThat(response.getHeaders()).containsKey("Authorization");
Assertions.assertNotNull(response.getBody()); assertThat(response.getBody()).isNotNull();
} }
@Test @Test
@ -81,44 +84,44 @@ public class PolarisCircuitBreakerHttpResponseTest {
PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(fallbackInfo); PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(fallbackInfo);
Assertions.assertEquals(200, response.getStatusCode().value()); assertThat(response.getStatusCode().value()).isEqualTo(200);
Assertions.assertEquals(fallbackInfo, response.getFallbackInfo()); assertThat(response.getFallbackInfo()).isEqualTo(fallbackInfo);
Assertions.assertNotNull(response.getHeaders()); assertThat(response.getHeaders()).isNotNull();
Assertions.assertTrue(response.getHeaders().containsKey("Content-Type")); assertThat(response.getHeaders()).containsKey("Content-Type");
Assertions.assertNotNull(response.getBody()); assertThat(response.getBody()).isNotNull();
} }
@Test @Test
void testGetStatusTextWithValidHttpStatus() { void testGetStatusTextWithValidHttpStatus() {
PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200); PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200);
Assertions.assertEquals("OK", response.getStatusText()); assertThat(response.getStatusText()).isEqualTo("OK");
} }
@Test @Test
void testGetStatusTextWithInvalidHttpStatus() { void testGetStatusTextWithInvalidHttpStatus() {
PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(999); PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(999);
//SCT 2024 will throw IllegalArgumentException when getStatusText() is called with invalid http status code //SCT 2024 will throw IllegalArgumentException when getStatusText() is called with invalid http status code
Assertions.assertThrows(IllegalArgumentException.class, () -> response.getStatusText()); assertThatThrownBy(() -> response.getStatusText()).isInstanceOf(IllegalArgumentException.class);
} }
@Test @Test
void testClose() { void testClose() {
PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200, "test body"); PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200, "test body");
InputStream body = response.getBody(); InputStream body = response.getBody();
Assertions.assertNotNull(body); assertThat(body).isNotNull();
response.close(); response.close();
// Verify that reading from closed stream throws exception // Verify that reading from closed stream throws exception
Assertions.assertDoesNotThrow(() -> body.read()); assertThatCode(() -> body.read()).doesNotThrowAnyException();
} }
@Test @Test
void testCloseWithNullBody() { void testCloseWithNullBody() {
PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200); PolarisCircuitBreakerHttpResponse response = new PolarisCircuitBreakerHttpResponse(200);
Assertions.assertNull(response.getBody()); assertThat(response.getBody()).isNull();
// Should not throw exception when closing null body // Should not throw exception when closing null body
Assertions.assertDoesNotThrow(() -> response.close()); assertThatCode(() -> response.close()).doesNotThrowAnyException();
} }
} }

@ -53,7 +53,7 @@ import org.springframework.http.HttpMethod;
import static com.tencent.polaris.test.common.Consts.NAMESPACE_TEST; import static com.tencent.polaris.test.common.Consts.NAMESPACE_TEST;
import static com.tencent.polaris.test.common.Consts.SERVICE_PROVIDER; import static com.tencent.polaris.test.common.Consts.SERVICE_PROVIDER;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy; import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString; import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;

@ -32,7 +32,6 @@ import com.tencent.cloud.polaris.context.config.PolarisContextProperties;
import com.tencent.polaris.configuration.api.core.ConfigFileService; import com.tencent.polaris.configuration.api.core.ConfigFileService;
import com.tencent.polaris.configuration.api.core.ConfigKVFile; import com.tencent.polaris.configuration.api.core.ConfigKVFile;
import com.tencent.polaris.configuration.client.internal.RevisableConfigFileGroup; import com.tencent.polaris.configuration.client.internal.RevisableConfigFileGroup;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
@ -302,21 +301,21 @@ public class PolarisConfigFileLocatorTest {
testProperties.setCheckAddress(checkAddress); testProperties.setCheckAddress(checkAddress);
testProperties.setShutdownIfConnectToConfigServerFailed(shutdownIfConnectToConfigServerFailed); testProperties.setShutdownIfConnectToConfigServerFailed(shutdownIfConnectToConfigServerFailed);
Assertions.assertEquals(enabled, testProperties.isEnabled()); assertThat(testProperties.isEnabled()).isEqualTo(enabled);
Assertions.assertEquals(address, testProperties.getAddress()); assertThat(testProperties.getAddress()).isEqualTo(address);
Assertions.assertEquals(port, testProperties.getPort()); assertThat(testProperties.getPort()).isEqualTo(port);
Assertions.assertEquals(token, testProperties.getToken()); assertThat(testProperties.getToken()).isEqualTo(token);
Assertions.assertEquals(autoRefresh, testProperties.isAutoRefresh()); assertThat(testProperties.isAutoRefresh()).isEqualTo(autoRefresh);
Assertions.assertEquals(refreshType, testProperties.getRefreshType()); assertThat(testProperties.getRefreshType()).isEqualTo(refreshType);
Assertions.assertEquals(groups, testProperties.getGroups()); assertThat(testProperties.getGroups()).isEqualTo(groups);
Assertions.assertEquals(preference, testProperties.isPreference()); assertThat(testProperties.isPreference()).isEqualTo(preference);
Assertions.assertEquals(dataSource, testProperties.getDataSource()); assertThat(testProperties.getDataSource()).isEqualTo(dataSource);
Assertions.assertEquals(localFileRootPath, testProperties.getLocalFileRootPath()); assertThat(testProperties.getLocalFileRootPath()).isEqualTo(localFileRootPath);
Assertions.assertEquals(internalEnabled, testProperties.isInternalEnabled()); assertThat(testProperties.isInternalEnabled()).isEqualTo(internalEnabled);
Assertions.assertEquals(checkAddress, testProperties.isCheckAddress()); assertThat(testProperties.isCheckAddress()).isEqualTo(checkAddress);
Assertions.assertEquals(shutdownIfConnectToConfigServerFailed, testProperties.isShutdownIfConnectToConfigServerFailed()); assertThat(testProperties.isShutdownIfConnectToConfigServerFailed()).isEqualTo(shutdownIfConnectToConfigServerFailed);
Assertions.assertNotNull(testProperties.toString()); assertThat(testProperties.toString()).isNotNull();
} }
private void clearCompositePropertySourceCache() { private void clearCompositePropertySourceCache() {

@ -71,8 +71,8 @@ import org.springframework.cloud.loadbalancer.core.ServiceInstanceListSupplier;
import org.springframework.http.HttpHeaders; import org.springframework.http.HttpHeaders;
import org.springframework.mock.http.server.reactive.MockServerHttpRequest; import org.springframework.mock.http.server.reactive.MockServerHttpRequest;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy; import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString; import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;

@ -37,7 +37,7 @@ import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.boot.test.context.SpringBootTest; import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.test.context.junit.jupiter.SpringExtension; import org.springframework.test.context.junit.jupiter.SpringExtension;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;

@ -43,7 +43,7 @@ import org.springframework.http.client.ClientHttpResponse;
import org.springframework.mock.http.client.MockClientHttpResponse; import org.springframework.mock.http.client.MockClientHttpResponse;
import org.springframework.test.context.junit.jupiter.SpringExtension; import org.springframework.test.context.junit.jupiter.SpringExtension;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq; import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;

@ -5,7 +5,7 @@
<parent> <parent>
<groupId>org.springframework.cloud</groupId> <groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-dependencies-parent</artifactId> <artifactId>spring-cloud-dependencies-parent</artifactId>
<version>4.2.1</version> <version>4.2.3</version>
<relativePath/> <relativePath/>
</parent> </parent>
<modelVersion>4.0.0</modelVersion> <modelVersion>4.0.0</modelVersion>
@ -80,7 +80,7 @@
<springdoc.version>2.8.13</springdoc.version> <springdoc.version>2.8.13</springdoc.version>
<!-- Maven Plugin Versions --> <!-- Maven Plugin Versions -->
<flatten-maven-plugin.version>1.3.0</flatten-maven-plugin.version> <flatten-maven-plugin.version>1.6.0</flatten-maven-plugin.version>
<central.publishing.maven.plugin.version>0.8.0</central.publishing.maven.plugin.version> <central.publishing.maven.plugin.version>0.8.0</central.publishing.maven.plugin.version>
</properties> </properties>

@ -17,7 +17,6 @@
package com.tencent.cloud.plugin.gateway; package com.tencent.cloud.plugin.gateway;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.mockito.Mock; import org.mockito.Mock;
@ -28,6 +27,7 @@ import org.springframework.cloud.gateway.filter.ReactiveLoadBalancerClientFilter
import org.springframework.cloud.loadbalancer.support.LoadBalancerClientFactory; import org.springframework.cloud.loadbalancer.support.LoadBalancerClientFactory;
import org.springframework.context.ApplicationContext; import org.springframework.context.ApplicationContext;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -62,7 +62,7 @@ public class PolarisReactiveLoadBalancerClientFilterBeanPostProcessorTest {
@Test @Test
void testGetOrder() { void testGetOrder() {
int order = processor.getOrder(); int order = processor.getOrder();
Assertions.assertEquals(PolarisReactiveLoadBalancerClientFilterBeanPostProcessor.ORDER, order); assertThat(order).isEqualTo(PolarisReactiveLoadBalancerClientFilterBeanPostProcessor.ORDER);
} }
@Test @Test
@ -75,7 +75,7 @@ public class PolarisReactiveLoadBalancerClientFilterBeanPostProcessorTest {
Object result = processor.postProcessAfterInitialization(originalInterceptor, beanName); Object result = processor.postProcessAfterInitialization(originalInterceptor, beanName);
// Assert // Assert
Assertions.assertInstanceOf(PolarisReactiveLoadBalancerClientFilter.class, result); assertThat(result).isInstanceOf(PolarisReactiveLoadBalancerClientFilter.class);
} }
@Test @Test
@ -88,7 +88,7 @@ public class PolarisReactiveLoadBalancerClientFilterBeanPostProcessorTest {
Object result = processor.postProcessAfterInitialization(originalBean, beanName); Object result = processor.postProcessAfterInitialization(originalBean, beanName);
// Assert // Assert
Assertions.assertSame(originalBean, result); assertThat(result).isSameAs(originalBean);
} }
} }

@ -20,7 +20,6 @@ package com.tencent.cloud.plugin.gateway;
import com.tencent.cloud.common.constant.MetadataConstant; import com.tencent.cloud.common.constant.MetadataConstant;
import com.tencent.cloud.common.metadata.MetadataContext; import com.tencent.cloud.common.metadata.MetadataContext;
import com.tencent.cloud.common.metadata.MetadataContextHolder; import com.tencent.cloud.common.metadata.MetadataContextHolder;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
@ -44,6 +43,7 @@ import static org.mockito.Mockito.when;
@ExtendWith(MockitoExtension.class) @ExtendWith(MockitoExtension.class)
class PolarisReactiveLoadBalancerClientFilterTest { class PolarisReactiveLoadBalancerClientFilterTest {
private final MetadataContext testContext = new MetadataContext();
@Mock @Mock
private LoadBalancerClientFactory clientFactory; private LoadBalancerClientFactory clientFactory;
@Mock @Mock
@ -54,9 +54,7 @@ class PolarisReactiveLoadBalancerClientFilterTest {
private ServerWebExchange exchange; private ServerWebExchange exchange;
@Mock @Mock
private GatewayFilterChain chain; private GatewayFilterChain chain;
private PolarisReactiveLoadBalancerClientFilter polarisFilter; private PolarisReactiveLoadBalancerClientFilter polarisFilter;
private final MetadataContext testContext = new MetadataContext();
@BeforeEach @BeforeEach
void setUp() { void setUp() {
@ -82,11 +80,11 @@ class PolarisReactiveLoadBalancerClientFilterTest {
when(originalFilter.filter(exchange, chain)) when(originalFilter.filter(exchange, chain))
.thenReturn(Mono.empty()); .thenReturn(Mono.empty());
MetadataContext before = MetadataContextHolder.get(); MetadataContext before = MetadataContextHolder.get();
Assertions.assertNotEquals(testContext, before); assertThat(before).isNotEqualTo(testContext);
// Act // Act
polarisFilter.filter(exchange, chain); polarisFilter.filter(exchange, chain);
MetadataContext after = MetadataContextHolder.get(); MetadataContext after = MetadataContextHolder.get();
Assertions.assertEquals(testContext, after); assertThat(after).isEqualTo(testContext);
} }
@Test @Test
@ -102,6 +100,6 @@ class PolarisReactiveLoadBalancerClientFilterTest {
MetadataContext after = MetadataContextHolder.get(); MetadataContext after = MetadataContextHolder.get();
// Assert // Assert
Assertions.assertEquals(before, after); assertThat(after).isEqualTo(before);
} }
} }

@ -24,7 +24,6 @@ import java.util.Map;
import com.tencent.cloud.polaris.discovery.PolarisDiscoveryClient; import com.tencent.cloud.polaris.discovery.PolarisDiscoveryClient;
import com.tencent.cloud.polaris.discovery.reactive.PolarisReactiveDiscoveryClient; import com.tencent.cloud.polaris.discovery.reactive.PolarisReactiveDiscoveryClient;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.mockito.Mockito; import org.mockito.Mockito;
@ -127,7 +126,8 @@ class ContextGatewayPropertiesManagerTest {
ContextGatewayFilter filter = new ContextGatewayFilter(manager, null); ContextGatewayFilter filter = new ContextGatewayFilter(manager, null);
MockServerHttpRequest request = MockServerHttpRequest.post("http://localhost/context/testNS/testSvc/api/exact").build(); MockServerHttpRequest request = MockServerHttpRequest.post("http://localhost/context/testNS/testSvc/api/exact")
.build();
String[] apis = filter.rebuildMsApi(request, group, request.getPath().value()); String[] apis = filter.rebuildMsApi(request, group, request.getPath().value());
// Test path matching // Test path matching
@ -223,7 +223,6 @@ class ContextGatewayPropertiesManagerTest {
"POST|/headerNS/svcFromHeader/api/test", "POST|/headerNS/svcFromHeader/api/test",
"/api/test"); "/api/test");
} }
private void testPositionCombination(ApiType apiType, Position namespacePos, Position servicePos, private void testPositionCombination(ApiType apiType, Position namespacePos, Position servicePos,
@ -287,19 +286,19 @@ class ContextGatewayPropertiesManagerTest {
void testGroupContext() { void testGroupContext() {
GroupContext group1 = new GroupContext(); GroupContext group1 = new GroupContext();
group1.setComment("testComment"); group1.setComment("testComment");
Assertions.assertEquals("testComment", group1.getComment()); assertThat(group1.getComment()).isEqualTo("testComment");
GroupContext.ContextPredicate contextPredicate = new GroupContext.ContextPredicate(); GroupContext.ContextPredicate contextPredicate = new GroupContext.ContextPredicate();
contextPredicate.setContext("testContext"); contextPredicate.setContext("testContext");
Assertions.assertEquals("testContext", contextPredicate.getContext()); assertThat(contextPredicate.getContext()).isEqualTo("testContext");
GroupContext.ContextRoute contextRoute = new GroupContext.ContextRoute(); GroupContext.ContextRoute contextRoute = new GroupContext.ContextRoute();
contextRoute.setPathMapping("testPathMapping"); contextRoute.setPathMapping("testPathMapping");
Assertions.assertEquals("testPathMapping", contextRoute.getPathMapping()); assertThat(contextRoute.getPathMapping()).isEqualTo("testPathMapping");
contextRoute.setHost("testHost"); contextRoute.setHost("testHost");
Assertions.assertEquals("testHost", contextRoute.getHost()); assertThat(contextRoute.getHost()).isEqualTo("testHost");
contextRoute.setMetadata(Collections.singletonMap("testKey", "testValue")); contextRoute.setMetadata(Collections.singletonMap("testKey", "testValue"));
Assertions.assertEquals(1, contextRoute.getMetadata().size()); assertThat(contextRoute.getMetadata()).hasSize(1);
} }
} }

@ -17,7 +17,6 @@
package com.tencent.cloud.plugin.gateway.context; package com.tencent.cloud.plugin.gateway.context;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.boot.test.context.runner.ApplicationContextRunner; import org.springframework.boot.test.context.runner.ApplicationContextRunner;
@ -48,7 +47,7 @@ class ContextRoutePredicateFactoryTest {
// Act // Act
ContextRoutePredicateFactory.Config config = factory.newConfig(); ContextRoutePredicateFactory.Config config = factory.newConfig();
config.setGroup("g1"); config.setGroup("g1");
Assertions.assertEquals("g1", config.getGroup()); assertThat(config.getGroup()).isEqualTo("g1");
GatewayPredicate gatewayPredicate = (GatewayPredicate) factory.apply(config); GatewayPredicate gatewayPredicate = (GatewayPredicate) factory.apply(config);
gatewayPredicate.toString(); gatewayPredicate.toString();
@ -57,8 +56,8 @@ class ContextRoutePredicateFactoryTest {
MockServerHttpRequest.get("/test").build()); MockServerHttpRequest.get("/test").build());
exchange.getAttributes().put(GATEWAY_PREDICATE_PATH_CONTAINER_ATTR, "mock"); exchange.getAttributes().put(GATEWAY_PREDICATE_PATH_CONTAINER_ATTR, "mock");
Assertions.assertTrue(gatewayPredicate.test(exchange)); assertThat(gatewayPredicate.test(exchange)).isTrue();
Assertions.assertEquals(config, gatewayPredicate.getConfig()); assertThat(gatewayPredicate.getConfig()).isEqualTo(config);
}); });
} }

@ -18,7 +18,6 @@
package com.tencent.cloud.rpc.enhancement.beanprocessor; package com.tencent.cloud.rpc.enhancement.beanprocessor;
import com.tencent.cloud.rpc.enhancement.plugin.EnhancedPluginRunner; import com.tencent.cloud.rpc.enhancement.plugin.EnhancedPluginRunner;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.mockito.Mock; import org.mockito.Mock;
@ -28,6 +27,7 @@ import org.springframework.beans.factory.BeanFactory;
import org.springframework.cloud.client.loadbalancer.LoadBalancerClient; import org.springframework.cloud.client.loadbalancer.LoadBalancerClient;
import org.springframework.cloud.client.loadbalancer.LoadBalancerRequestFactory; import org.springframework.cloud.client.loadbalancer.LoadBalancerRequestFactory;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
/** /**
@ -73,7 +73,7 @@ class BlockingLoadBalancerClientBeanPostProcessorTest {
Object result = processor.postProcessBeforeInitialization(originalBean, beanName); Object result = processor.postProcessBeforeInitialization(originalBean, beanName);
// Assert // Assert
Assertions.assertSame(originalBean, result); assertThat(result).isSameAs(originalBean);
} }
@Test @Test
@ -82,6 +82,6 @@ class BlockingLoadBalancerClientBeanPostProcessorTest {
int order = processor.getOrder(); int order = processor.getOrder();
// Assert // Assert
Assertions.assertEquals(BlockingLoadBalancerClientBeanPostProcessor.ORDER, order); assertThat(order).isEqualTo(BlockingLoadBalancerClientBeanPostProcessor.ORDER);
} }
} }

@ -42,7 +42,6 @@ import com.tencent.polaris.client.api.SDKContext;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable; import org.jetbrains.annotations.Nullable;
import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -177,9 +176,7 @@ public class EnhancedGatewayGlobalFilterTest {
EnhancedGatewayGlobalFilter filter = new EnhancedGatewayGlobalFilter(pluginRunner); EnhancedGatewayGlobalFilter filter = new EnhancedGatewayGlobalFilter(pluginRunner);
// Act & Assert // Act & Assert
Assertions.assertThrows(CallAbortedException.class, () -> { assertThatThrownBy(() -> filter.filter(exchange, chain)).isInstanceOf(CallAbortedException.class);
filter.filter(exchange, chain);
});
} }
@Test @Test

@ -36,7 +36,6 @@ import com.tencent.polaris.api.pojo.CircuitBreakerStatus;
import com.tencent.polaris.circuitbreak.client.exception.CallAbortedException; import com.tencent.polaris.circuitbreak.client.exception.CallAbortedException;
import com.tencent.polaris.client.api.SDKContext; import com.tencent.polaris.client.api.SDKContext;
import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -170,7 +169,7 @@ public class EnhancedWebClientExchangeFilterFunctionTest {
// Assert // Assert
StepVerifier.create(responseMono) StepVerifier.create(responseMono)
.expectNextMatches(response -> { .expectNextMatches(response -> {
Assertions.assertEquals(HttpStatus.SERVICE_UNAVAILABLE, response.statusCode()); assertThat(response.statusCode()).isEqualTo(HttpStatus.SERVICE_UNAVAILABLE);
assertThat(response.headers().asHttpHeaders().containsKey("header-key")).isTrue(); assertThat(response.headers().asHttpHeaders().containsKey("header-key")).isTrue();
return true; return true;
}) })

@ -20,13 +20,14 @@ package com.tencent.cloud.rpc.enhancement.plugin;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension; import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.cloud.client.serviceregistry.Registration; import org.springframework.cloud.client.serviceregistry.Registration;
import static org.assertj.core.api.Assertions.assertThat;
/** /**
* Tests for {@link DefaultEnhancedPluginRunner}. * Tests for {@link DefaultEnhancedPluginRunner}.
* *
@ -48,7 +49,7 @@ public class DefaultEnhancedPluginRunnerTest {
Registration result = DefaultEnhancedPluginRunner.getPolarisRegistration(registrations); Registration result = DefaultEnhancedPluginRunner.getPolarisRegistration(registrations);
// Assert // Assert
Assertions.assertSame(normalReg, result); assertThat(result).isSameAs(normalReg);
} }
// Helper method to create mock Registration objects // Helper method to create mock Registration objects

@ -4,5 +4,4 @@
"https://www.puppycrawl.com/dtds/suppressions_1_1.dtd"> "https://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
<suppressions> <suppressions>
<suppress files=".*" checks="RegexpHeader"/> <suppress files=".*" checks="RegexpHeader"/>
<suppress files=".*" checks="IllegalImport"/>
</suppressions> </suppressions>
Loading…
Cancel
Save