Addressing efortuna comments.

pull/14/head
Andrew Brogdon 8 years ago
parent ce63600d5a
commit e5a92bc1cf

@ -4,7 +4,6 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/widgets.dart';
import 'package:meta/meta.dart';
import 'package:scoped_model/scoped_model.dart';
import 'package:veggieseasons/data/model.dart';
import 'package:veggieseasons/data/veggie.dart';
@ -43,7 +42,7 @@ class SeasonCircle extends StatelessWidget {
class DetailsScreen extends StatelessWidget {
final int id;
DetailsScreen({@required this.id});
DetailsScreen(this.id);
Widget _createFavoriteButton(bool isFav, VoidCallback onPressed) {
return CupertinoButton(
@ -104,10 +103,7 @@ class DetailsScreen extends StatelessWidget {
final veggie = model.getVeggie(id);
return Padding(
padding: const EdgeInsets.symmetric(
horizontal: 24.0,
vertical: 24.0,
),
padding: const EdgeInsets.all(24.0),
child: Column(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: <Widget>[
@ -129,9 +125,10 @@ class DetailsScreen extends StatelessWidget {
),
],
),
SizedBox(height: 10.0),
Text(veggie.shortDescription),
SizedBox(height: 10.0),
Padding(
padding: const EdgeInsets.symmetric(vertical: 10.0),
child: Text(veggie.shortDescription),
),
_createFavoriteButton(veggie.isFavorite, () {
model.toggleFavorite(veggie.id);
}),

@ -119,9 +119,13 @@ abstract class Styles {
fontPackage: CupertinoIcons.iconFontPackage,
);
static const transparentColor = Color(0x00000000);
static const shadowColor = Color(0xa0000000);
static const shadowGradient = LinearGradient(
begin: Alignment.topCenter,
end: Alignment.bottomCenter,
colors: [Color(0x00000000), Color(0xa0000000)],
colors: [transparentColor, shadowColor],
);
}

@ -35,8 +35,8 @@ class VeggieHeadline extends StatelessWidget {
@override
Widget build(BuildContext context) {
return GestureDetector(
onTap: () => Navigator.of(context).push(CupertinoPageRoute(
builder: (context) => DetailsScreen(id: veggie.id))),
onTap: () => Navigator.of(context).push(
CupertinoPageRoute(builder: (context) => DetailsScreen(veggie.id))),
child: Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: [

Loading…
Cancel
Save