From e5a92bc1cfa7620ed9fef2277644fb06b4e0ea42 Mon Sep 17 00:00:00 2001
From: Andrew Brogdon <brogdon@gmail.com>
Date: Wed, 5 Sep 2018 15:28:41 -0700
Subject: [PATCH] Addressing efortuna comments.

---
 veggieseasons/lib/screens/details.dart         | 15 ++++++---------
 veggieseasons/lib/styles.dart                  |  6 +++++-
 veggieseasons/lib/widgets/veggie_headline.dart |  4 ++--
 3 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/veggieseasons/lib/screens/details.dart b/veggieseasons/lib/screens/details.dart
index 7babfdbd0..66543abfa 100644
--- a/veggieseasons/lib/screens/details.dart
+++ b/veggieseasons/lib/screens/details.dart
@@ -4,7 +4,6 @@
 
 import 'package:flutter/cupertino.dart';
 import 'package:flutter/widgets.dart';
-import 'package:meta/meta.dart';
 import 'package:scoped_model/scoped_model.dart';
 import 'package:veggieseasons/data/model.dart';
 import 'package:veggieseasons/data/veggie.dart';
@@ -43,7 +42,7 @@ class SeasonCircle extends StatelessWidget {
 class DetailsScreen extends StatelessWidget {
   final int id;
 
-  DetailsScreen({@required this.id});
+  DetailsScreen(this.id);
 
   Widget _createFavoriteButton(bool isFav, VoidCallback onPressed) {
     return CupertinoButton(
@@ -104,10 +103,7 @@ class DetailsScreen extends StatelessWidget {
     final veggie = model.getVeggie(id);
 
     return Padding(
-      padding: const EdgeInsets.symmetric(
-        horizontal: 24.0,
-        vertical: 24.0,
-      ),
+      padding: const EdgeInsets.all(24.0),
       child: Column(
         crossAxisAlignment: CrossAxisAlignment.stretch,
         children: <Widget>[
@@ -129,9 +125,10 @@ class DetailsScreen extends StatelessWidget {
               ),
             ],
           ),
-          SizedBox(height: 10.0),
-          Text(veggie.shortDescription),
-          SizedBox(height: 10.0),
+          Padding(
+            padding: const EdgeInsets.symmetric(vertical: 10.0),
+            child: Text(veggie.shortDescription),
+          ),
           _createFavoriteButton(veggie.isFavorite, () {
             model.toggleFavorite(veggie.id);
           }),
diff --git a/veggieseasons/lib/styles.dart b/veggieseasons/lib/styles.dart
index c0cec9b53..546c1bef7 100644
--- a/veggieseasons/lib/styles.dart
+++ b/veggieseasons/lib/styles.dart
@@ -119,9 +119,13 @@ abstract class Styles {
     fontPackage: CupertinoIcons.iconFontPackage,
   );
 
+  static const transparentColor = Color(0x00000000);
+
+  static const shadowColor = Color(0xa0000000);
+
   static const shadowGradient = LinearGradient(
     begin: Alignment.topCenter,
     end: Alignment.bottomCenter,
-    colors: [Color(0x00000000), Color(0xa0000000)],
+    colors: [transparentColor, shadowColor],
   );
 }
diff --git a/veggieseasons/lib/widgets/veggie_headline.dart b/veggieseasons/lib/widgets/veggie_headline.dart
index 87869ddbc..110a5bf47 100644
--- a/veggieseasons/lib/widgets/veggie_headline.dart
+++ b/veggieseasons/lib/widgets/veggie_headline.dart
@@ -35,8 +35,8 @@ class VeggieHeadline extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return GestureDetector(
-      onTap: () => Navigator.of(context).push(CupertinoPageRoute(
-          builder: (context) => DetailsScreen(id: veggie.id))),
+      onTap: () => Navigator.of(context).push(
+          CupertinoPageRoute(builder: (context) => DetailsScreen(veggie.id))),
       child: Row(
         crossAxisAlignment: CrossAxisAlignment.start,
         children: [