Pull up `TextEditingDeltaHistoryManager` to drop redundancy (#1306)

pull/1311/head
Brett Morgan 3 years ago committed by GitHub
parent addafa93ec
commit 77cf69097a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -303,6 +303,9 @@ class _MyHomePageState extends State<MyHomePage> {
_updateToggleButtonsStateOnButtonPressed, _updateToggleButtonsStateOnButtonPressed,
updateToggleButtonStateOnSelectionChanged: updateToggleButtonStateOnSelectionChanged:
_updateToggleButtonsStateOnSelectionChanged, _updateToggleButtonsStateOnSelectionChanged,
child: TextEditingDeltaHistoryManager(
history: _textEditingDeltaHistory,
updateHistoryOnInput: _updateTextEditingDeltaHistory,
child: Column( child: Column(
children: [ children: [
Padding( Padding(
@ -325,8 +328,8 @@ class _MyHomePageState extends State<MyHomePage> {
manager.toggleButtonsState manager.toggleButtonsState
.contains(ToggleButtonsState.underline), .contains(ToggleButtonsState.underline),
], ],
onPressed: (index) => onPressed: (index) => manager
manager.updateToggleButtonsOnButtonPressed(index), .updateToggleButtonsOnButtonPressed(index),
children: const [ children: const [
Icon(Icons.format_bold), Icon(Icons.format_bold),
Icon(Icons.format_italic), Icon(Icons.format_italic),
@ -340,9 +343,6 @@ class _MyHomePageState extends State<MyHomePage> {
Expanded( Expanded(
child: Padding( child: Padding(
padding: const EdgeInsets.symmetric(horizontal: 35.0), padding: const EdgeInsets.symmetric(horizontal: 35.0),
child: TextEditingDeltaHistoryManager(
history: _textEditingDeltaHistory,
updateHistoryOnInput: _updateTextEditingDeltaHistory,
child: BasicTextField( child: BasicTextField(
controller: _replacementTextEditingController, controller: _replacementTextEditingController,
style: const TextStyle( style: const TextStyle(
@ -351,15 +351,11 @@ class _MyHomePageState extends State<MyHomePage> {
), ),
), ),
), ),
),
Expanded( Expanded(
child: Column( child: Column(
children: [ children: [
_buildTextEditingDeltaViewHeader(), _buildTextEditingDeltaViewHeader(),
Expanded( Expanded(
child: TextEditingDeltaHistoryManager(
history: _textEditingDeltaHistory,
updateHistoryOnInput: _updateTextEditingDeltaHistory,
child: Builder( child: Builder(
builder: (innerContext) { builder: (innerContext) {
final TextEditingDeltaHistoryManager manager = final TextEditingDeltaHistoryManager manager =
@ -381,7 +377,6 @@ class _MyHomePageState extends State<MyHomePage> {
}, },
), ),
), ),
),
const SizedBox(height: 10), const SizedBox(height: 10),
], ],
), ),
@ -391,6 +386,7 @@ class _MyHomePageState extends State<MyHomePage> {
), ),
), ),
), ),
),
); );
} }
} }

@ -18,7 +18,8 @@ class TextEditingDeltaHistoryManager extends InheritedWidget {
static TextEditingDeltaHistoryManager of(BuildContext context) { static TextEditingDeltaHistoryManager of(BuildContext context) {
final TextEditingDeltaHistoryManager? result = context final TextEditingDeltaHistoryManager? result = context
.dependOnInheritedWidgetOfExactType<TextEditingDeltaHistoryManager>(); .dependOnInheritedWidgetOfExactType<TextEditingDeltaHistoryManager>();
assert(result != null, 'No ToggleButtonsStateManager found in context'); assert(
result != null, 'No TextEditingDeltaHistoryManager found in context');
return result!; return result!;
} }

Loading…
Cancel
Save