refactor: remove redundant notifyListeners in deleteBooking

pull/2839/head
harshyadavDeveloper 5 months ago
parent 56bf76f2f0
commit 14b57fb61b

@ -65,7 +65,6 @@ class HomeViewModel extends ChangeNotifier {
} }
Future<Result<void>> _deleteBooking(int id) async { Future<Result<void>> _deleteBooking(int id) async {
try {
final resultDelete = await _bookingRepository.delete(id); final resultDelete = await _bookingRepository.delete(id);
switch (resultDelete) { switch (resultDelete) {
case Ok<void>(): case Ok<void>():
@ -75,21 +74,18 @@ class HomeViewModel extends ChangeNotifier {
return resultDelete; return resultDelete;
} }
// After deleting the booking, we need to reload the bookings list. // After deleting the booking, reload the bookings list.
// BookingRepository is the source of truth for bookings.
final resultLoadBookings = await _bookingRepository.getBookingsList(); final resultLoadBookings = await _bookingRepository.getBookingsList();
switch (resultLoadBookings) { switch (resultLoadBookings) {
case Ok<List<BookingSummary>>(): case Ok<List<BookingSummary>>():
_bookings = resultLoadBookings.value; _bookings = resultLoadBookings.value;
_log.fine('Loaded bookings'); _log.fine('Loaded bookings');
notifyListeners(); // notify only when data changes
case Error<List<BookingSummary>>(): case Error<List<BookingSummary>>():
_log.warning('Failed to load bookings', resultLoadBookings.error); _log.warning('Failed to load bookings', resultLoadBookings.error);
return resultLoadBookings; return resultLoadBookings;
} }
return resultLoadBookings; return resultLoadBookings;
} finally {
notifyListeners();
}
} }
} }

Loading…
Cancel
Save