refactor: changed multiball states enum values

pull/235/head
RuiAlonso 3 years ago
parent 8f1d31de62
commit f8b8ab4011

@ -19,7 +19,7 @@ class MultiballBlinkingBehavior extends TimerComponent
void _onNewState(MultiballState state) { void _onNewState(MultiballState state) {
final animationEnabled = final animationEnabled =
state.animationState == MultiballAnimationState.animated; state.animationState == MultiballAnimationState.blinking;
final canBlink = _blinksCounter < _maxBlinks; final canBlink = _blinksCounter < _maxBlinks;
if (animationEnabled && canBlink) { if (animationEnabled && canBlink) {

@ -10,13 +10,13 @@ class MultiballCubit extends Cubit<MultiballState> {
void onAnimate() { void onAnimate() {
emit( emit(
state.copyWith(animationState: MultiballAnimationState.animated), state.copyWith(animationState: MultiballAnimationState.blinking),
); );
} }
void onStop() { void onStop() {
emit( emit(
state.copyWith(animationState: MultiballAnimationState.stopped), state.copyWith(animationState: MultiballAnimationState.idle),
); );
} }

@ -10,8 +10,8 @@ enum MultiballLightState {
// Indicates if the blinking animation is running. // Indicates if the blinking animation is running.
enum MultiballAnimationState { enum MultiballAnimationState {
stopped, idle,
animated, blinking,
} }
class MultiballState extends Equatable { class MultiballState extends Equatable {
@ -23,7 +23,7 @@ class MultiballState extends Equatable {
const MultiballState.initial() const MultiballState.initial()
: this( : this(
lightState: MultiballLightState.dimmed, lightState: MultiballLightState.dimmed,
animationState: MultiballAnimationState.stopped, animationState: MultiballAnimationState.idle,
); );
final MultiballLightState lightState; final MultiballLightState lightState;

@ -36,7 +36,7 @@ void main() {
streamController.add( streamController.add(
MultiballState( MultiballState(
animationState: MultiballAnimationState.animated, animationState: MultiballAnimationState.blinking,
lightState: MultiballLightState.lit, lightState: MultiballLightState.lit,
), ),
); );
@ -72,7 +72,7 @@ void main() {
streamController.add( streamController.add(
MultiballState( MultiballState(
animationState: MultiballAnimationState.animated, animationState: MultiballAnimationState.blinking,
lightState: MultiballLightState.lit, lightState: MultiballLightState.lit,
), ),
); );
@ -80,7 +80,7 @@ void main() {
streamController.add( streamController.add(
MultiballState( MultiballState(
animationState: MultiballAnimationState.stopped, animationState: MultiballAnimationState.idle,
lightState: MultiballLightState.lit, lightState: MultiballLightState.lit,
), ),
); );
@ -109,7 +109,7 @@ void main() {
streamController.add( streamController.add(
MultiballState( MultiballState(
animationState: MultiballAnimationState.stopped, animationState: MultiballAnimationState.idle,
lightState: MultiballLightState.lit, lightState: MultiballLightState.lit,
), ),
); );
@ -140,7 +140,7 @@ void main() {
streamController.add( streamController.add(
MultiballState( MultiballState(
animationState: MultiballAnimationState.animated, animationState: MultiballAnimationState.blinking,
lightState: MultiballLightState.dimmed, lightState: MultiballLightState.dimmed,
), ),
); );

@ -15,7 +15,7 @@ void main() {
..having( ..having(
(state) => state.animationState, (state) => state.animationState,
'animationState', 'animationState',
MultiballAnimationState.animated, MultiballAnimationState.blinking,
) )
], ],
); );
@ -29,7 +29,7 @@ void main() {
..having( ..having(
(state) => state.animationState, (state) => state.animationState,
'animationState', 'animationState',
MultiballAnimationState.stopped, MultiballAnimationState.idle,
) )
], ],
); );

@ -8,12 +8,12 @@ void main() {
test('supports value equality', () { test('supports value equality', () {
expect( expect(
MultiballState( MultiballState(
animationState: MultiballAnimationState.stopped, animationState: MultiballAnimationState.idle,
lightState: MultiballLightState.dimmed, lightState: MultiballLightState.dimmed,
), ),
equals( equals(
MultiballState( MultiballState(
animationState: MultiballAnimationState.stopped, animationState: MultiballAnimationState.idle,
lightState: MultiballLightState.dimmed, lightState: MultiballLightState.dimmed,
), ),
), ),
@ -24,7 +24,7 @@ void main() {
test('can be instantiated', () { test('can be instantiated', () {
expect( expect(
MultiballState( MultiballState(
animationState: MultiballAnimationState.stopped, animationState: MultiballAnimationState.idle,
lightState: MultiballLightState.dimmed, lightState: MultiballLightState.dimmed,
), ),
isNotNull, isNotNull,
@ -38,7 +38,7 @@ void main() {
'when no argument specified', 'when no argument specified',
() { () {
final multiballState = MultiballState( final multiballState = MultiballState(
animationState: MultiballAnimationState.stopped, animationState: MultiballAnimationState.idle,
lightState: MultiballLightState.dimmed, lightState: MultiballLightState.dimmed,
); );
expect( expect(
@ -53,18 +53,18 @@ void main() {
'when all arguments specified', 'when all arguments specified',
() { () {
final multiballState = MultiballState( final multiballState = MultiballState(
animationState: MultiballAnimationState.stopped, animationState: MultiballAnimationState.idle,
lightState: MultiballLightState.dimmed, lightState: MultiballLightState.dimmed,
); );
final otherMultiballState = MultiballState( final otherMultiballState = MultiballState(
animationState: MultiballAnimationState.animated, animationState: MultiballAnimationState.blinking,
lightState: MultiballLightState.lit, lightState: MultiballLightState.lit,
); );
expect(multiballState, isNot(equals(otherMultiballState))); expect(multiballState, isNot(equals(otherMultiballState)));
expect( expect(
multiballState.copyWith( multiballState.copyWith(
animationState: MultiballAnimationState.animated, animationState: MultiballAnimationState.blinking,
lightState: MultiballLightState.lit, lightState: MultiballLightState.lit,
), ),
equals(otherMultiballState), equals(otherMultiballState),

Loading…
Cancel
Save