fix: apply code review

lib/leaderboard/models/leader_board_entry.dart

@@ -36,7 +36,7 @@ extension LeaderboardEntryDataX on LeaderboardEntryData {
       rank: position.toString(),
       playerInitials: playerInitials,
       score: score,
-      character: character.toTheme.characterAsset,
+      character: character.toTheme.character,
     );
   }
 }

lib/theme/view/character_selection_page.dart

@@ -122,7 +122,7 @@ class CharacterImageButton extends StatelessWidget {
         ),
         child: Padding(
           padding: const EdgeInsets.all(8),
-          child: characterTheme.characterAsset.image(),
+          child: characterTheme.character.image(),
         ),
       ),
     );

packages/pinball_theme/lib/src/themes/android_theme.dart

@@ -15,14 +15,11 @@ class AndroidTheme extends CharacterTheme {
   Color get ballColor => Colors.green;
 
   @override
-  AssetGenImage get characterAsset => Assets.images.android;
+  AssetGenImage get character => Assets.images.android.character;
 
   @override
-  AssetGenImage get backgroundAsset => Assets.images.androidBackground;
+  AssetGenImage get background => Assets.images.android.background;
 
   @override
-  AssetGenImage get placeholderAsset => Assets.images.androidPlaceholder;
+  AssetGenImage get icon => Assets.images.android.icon;
-
-  @override
-  AssetGenImage get iconAsset => Assets.images.androidIcon;
 }

packages/pinball_theme/lib/src/themes/character_theme.dart

@@ -19,24 +19,20 @@ abstract class CharacterTheme extends Equatable {
   Color get ballColor;
 
   /// Asset for the theme character.
-  AssetGenImage get characterAsset;
+  AssetGenImage get character;
 
   /// Asset for the background.
-  AssetGenImage get backgroundAsset;
+  AssetGenImage get background;
-
-  /// Asset for the placeholder.
-  AssetGenImage get placeholderAsset;
 
   /// Icon asset.
-  AssetGenImage get iconAsset;
+  AssetGenImage get icon;
 
   @override
   List<Object?> get props => [
         name,
         ballColor,
-        characterAsset,
+        character,
-        backgroundAsset,
+        background,
-        placeholderAsset,
+        icon,
-        iconAsset,
       ];
 }

packages/pinball_theme/lib/src/themes/dash_theme.dart

@@ -15,14 +15,11 @@ class DashTheme extends CharacterTheme {
   Color get ballColor => Colors.blue;
 
   @override
-  AssetGenImage get characterAsset => Assets.images.dash;
+  AssetGenImage get character => Assets.images.dash.character;
 
   @override
-  AssetGenImage get backgroundAsset => Assets.images.dashBackground;
+  AssetGenImage get background => Assets.images.dash.background;
 
   @override
-  AssetGenImage get placeholderAsset => Assets.images.dashPlaceholder;
+  AssetGenImage get icon => Assets.images.dash.icon;
-
-  @override
-  AssetGenImage get iconAsset => Assets.images.dashIcon;
 }

packages/pinball_theme/lib/src/themes/dino_theme.dart

@@ -15,14 +15,11 @@ class DinoTheme extends CharacterTheme {
   Color get ballColor => Colors.grey;
 
   @override
-  AssetGenImage get characterAsset => Assets.images.dino;
+  AssetGenImage get character => Assets.images.dino.character;
 
   @override
-  AssetGenImage get backgroundAsset => Assets.images.dinoBackground;
+  AssetGenImage get background => Assets.images.dino.background;
 
   @override
-  AssetGenImage get placeholderAsset => Assets.images.dinoPlaceholder;
+  AssetGenImage get icon => Assets.images.dino.icon;
-
-  @override
-  AssetGenImage get iconAsset => Assets.images.dinoIcon;
 }

packages/pinball_theme/lib/src/themes/sparky_theme.dart

@@ -15,14 +15,11 @@ class SparkyTheme extends CharacterTheme {
   String get name => 'Sparky';
 
   @override
-  AssetGenImage get characterAsset => Assets.images.sparky;
+  AssetGenImage get character => Assets.images.sparky.character;
 
   @override
-  AssetGenImage get backgroundAsset => Assets.images.sparkyBackground;
+  AssetGenImage get background => Assets.images.sparky.background;
 
   @override
-  AssetGenImage get placeholderAsset => Assets.images.sparkyPlaceholder;
+  AssetGenImage get icon => Assets.images.sparky.icon;
-
-  @override
-  AssetGenImage get iconAsset => Assets.images.sparkyIcon;
 }

packages/pinball_theme/test/src/themes/android_theme_test.dart

@@ -18,26 +18,22 @@ void main() {
       expect(AndroidTheme().ballColor, equals(Colors.green));
     });
 
-    test('characterAsset is correct', () {
+    test('character asset is correct', () {
-      expect(AndroidTheme().characterAsset, equals(Assets.images.android));
-    });
-
-    test('backgroundAsset is correct', () {
       expect(
-        AndroidTheme().backgroundAsset,
+        AndroidTheme().character,
-        equals(Assets.images.androidBackground),
+        equals(Assets.images.android.character),
       );
     });
 
-    test('iconAsset is correct', () {
+    test('background asset is correct', () {
-      expect(AndroidTheme().iconAsset, equals(Assets.images.androidIcon));
-    });
-
-    test('placeholderAsset is correct', () {
       expect(
-        AndroidTheme().placeholderAsset,
+        AndroidTheme().background,
-        equals(Assets.images.androidPlaceholder),
+        equals(Assets.images.android.background),
       );
     });
+
+    test('icon asset is correct', () {
+      expect(AndroidTheme().icon, equals(Assets.images.android.icon));
+    });
   });
 }

packages/pinball_theme/test/src/themes/dash_theme_test.dart

@@ -18,26 +18,22 @@ void main() {
       expect(DashTheme().ballColor, equals(Colors.blue));
     });
 
-    test('characterAsset is correct', () {
+    test('character asset is correct', () {
-      expect(DashTheme().characterAsset, equals(Assets.images.dash));
-    });
-
-    test('backgroundAsset is correct', () {
       expect(
-        DashTheme().backgroundAsset,
+        DashTheme().character,
-        equals(Assets.images.dashBackground),
+        equals(Assets.images.dash.character),
       );
     });
 
-    test('iconAsset is correct', () {
+    test('background asset is correct', () {
-      expect(DashTheme().iconAsset, equals(Assets.images.dashIcon));
-    });
-
-    test('placeholderAsset is correct', () {
       expect(
-        DashTheme().placeholderAsset,
+        DashTheme().background,
-        equals(Assets.images.dashPlaceholder),
+        equals(Assets.images.dash.background),
       );
     });
+
+    test('icon asset is correct', () {
+      expect(DashTheme().icon, equals(Assets.images.dash.icon));
+    });
   });
 }

packages/pinball_theme/test/src/themes/dino_theme_test.dart

@@ -18,26 +18,22 @@ void main() {
       expect(DinoTheme().ballColor, equals(Colors.grey));
     });
 
-    test('characterAsset is correct', () {
+    test('character asset is correct', () {
-      expect(DinoTheme().characterAsset, equals(Assets.images.dino));
-    });
-
-    test('backgroundAsset is correct', () {
       expect(
-        DinoTheme().backgroundAsset,
+        DinoTheme().character,
-        equals(Assets.images.dinoBackground),
+        equals(Assets.images.dino.character),
       );
     });
 
-    test('iconAsset is correct', () {
+    test('background asset is correct', () {
-      expect(DinoTheme().iconAsset, equals(Assets.images.dinoIcon));
-    });
-
-    test('placeholderAsset is correct', () {
       expect(
-        DinoTheme().placeholderAsset,
+        DinoTheme().background,
-        equals(Assets.images.dinoPlaceholder),
+        equals(Assets.images.dino.background),
       );
     });
+
+    test('icon asset is correct', () {
+      expect(DinoTheme().icon, equals(Assets.images.dino.icon));
+    });
   });
 }

packages/pinball_theme/test/src/themes/sparky_theme_test.dart

@@ -18,26 +18,22 @@ void main() {
       expect(SparkyTheme().ballColor, equals(Colors.orange));
     });
 
-    test('characterAsset is correct', () {
+    test('character asset is correct', () {
-      expect(SparkyTheme().characterAsset, equals(Assets.images.sparky));
-    });
-
-    test('backgroundAsset is correct', () {
       expect(
-        SparkyTheme().backgroundAsset,
+        SparkyTheme().character,
-        equals(Assets.images.sparkyBackground),
+        equals(Assets.images.sparky.character),
       );
     });
 
-    test('iconAsset is correct', () {
+    test('background asset is correct', () {
-      expect(SparkyTheme().iconAsset, equals(Assets.images.sparkyIcon));
-    });
-
-    test('placeholderAsset is correct', () {
       expect(
-        SparkyTheme().placeholderAsset,
+        SparkyTheme().background,
-        equals(Assets.images.sparkyPlaceholder),
+        equals(Assets.images.sparky.background),
       );
     });
+
+    test('icon asset is correct', () {
+      expect(SparkyTheme().icon, equals(Assets.images.sparky.icon));
+    });
   });
 }

test/leaderboard/bloc/leaderboard_state_test.dart

@@ -30,7 +30,7 @@ void main() {
         rank: '1',
         playerInitials: 'ABC',
         score: 1500,
-        character: DashTheme().characterAsset,
+        character: DashTheme().character,
       );
 
       test(

test/leaderboard/view/leaderboard_page_test.dart

@@ -121,7 +121,7 @@ void main() {
               rank: '1',
               playerInitials: 'ABC',
               score: 10000,
-              character: DashTheme().characterAsset,
+              character: DashTheme().character,
             ),
           ],
         ),