feat: pr suggestions

pull/24/head
Erick Zanardo 4 years ago
parent 57a6243649
commit ab359aafb5

@ -38,7 +38,7 @@ class GameBloc extends Bloc<GameEvent, GameState> {
activatedBonusLetters: [], activatedBonusLetters: [],
bonusHistory: [ bonusHistory: [
...state.bonusHistory, ...state.bonusHistory,
GameBonuses.letterSequence, GameBonus.letterSequence,
], ],
), ),
); );

@ -1,7 +1,9 @@
part of 'game_bloc.dart'; part of 'game_bloc.dart';
/// Defines bonuses that a player can gain during a [PinballGame]. /// Defines bonuses that a player can gain during a PinballGame.
enum GameBonuses { enum GameBonus {
/// Bonus achieved when the user activate all of the bonus
/// letters on the board
letterSequence, letterSequence,
} }
@ -35,9 +37,9 @@ class GameState extends Equatable {
/// Active bonus letters. /// Active bonus letters.
final List<int> activatedBonusLetters; final List<int> activatedBonusLetters;
/// Holds the history of all the [GameBonus]es earned by the player during a /// Holds the history of all the [GameBonus]es earned by the player during a
/// [PinballGame]. /// PinballGame.
final List<GameBonuses> bonusHistory; final List<GameBonus> bonusHistory;
/// Determines when the game is over. /// Determines when the game is over.
bool get isGameOver => balls == 0; bool get isGameOver => balls == 0;
@ -49,7 +51,7 @@ class GameState extends Equatable {
int? score, int? score,
int? balls, int? balls,
List<int>? activatedBonusLetters, List<int>? activatedBonusLetters,
List<GameBonuses>? bonusHistory, List<GameBonus>? bonusHistory,
}) { }) {
assert( assert(
score == null || score >= this.score, score == null || score >= this.score,

@ -154,7 +154,7 @@ void main() {
score: 0, score: 0,
balls: 3, balls: 3,
activatedBonusLetters: [], activatedBonusLetters: [],
bonusHistory: [GameBonuses.letterSequence], bonusHistory: [GameBonus.letterSequence],
), ),
], ],
); );

@ -175,7 +175,7 @@ void main() {
score: gameState.score + 1, score: gameState.score + 1,
balls: gameState.balls + 1, balls: gameState.balls + 1,
activatedBonusLetters: const [0], activatedBonusLetters: const [0],
bonusHistory: const [GameBonuses.letterSequence], bonusHistory: const [GameBonus.letterSequence],
); );
expect(gameState, isNot(equals(otherGameState))); expect(gameState, isNot(equals(otherGameState)));

Loading…
Cancel
Save