fix: apply code review

pull/233/head
arturplaczek 3 years ago
parent 7c3ee4f687
commit 972bb1bec0

@ -32,7 +32,7 @@ class PinballGamePage extends StatelessWidget {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
final selectedCharacter = final selectedCharacter =
context.read<CharacterThemeCubit>().state.selectedCharacter; context.read<CharacterThemeCubit>().state.characterTheme;
final audio = context.read<PinballAudio>(); final audio = context.read<PinballAudio>();
final pinballAudio = context.read<PinballAudio>(); final pinballAudio = context.read<PinballAudio>();

@ -4,12 +4,12 @@
part of 'character_theme_cubit.dart'; part of 'character_theme_cubit.dart';
class CharacterThemeState extends Equatable { class CharacterThemeState extends Equatable {
const CharacterThemeState(this.selectedCharacter); const CharacterThemeState(this.characterTheme);
const CharacterThemeState.initial() : selectedCharacter = const DashTheme(); const CharacterThemeState.initial() : characterTheme = const DashTheme();
final CharacterTheme selectedCharacter; final CharacterTheme characterTheme;
@override @override
List<Object> get props => [selectedCharacter]; List<Object> get props => [characterTheme];
} }

@ -111,7 +111,7 @@ class CharacterImageButton extends StatelessWidget {
Widget build(BuildContext context) { Widget build(BuildContext context) {
final currentCharacterTheme = final currentCharacterTheme =
context.select<CharacterThemeCubit, CharacterTheme>( context.select<CharacterThemeCubit, CharacterTheme>(
(cubit) => cubit.state.selectedCharacter, (cubit) => cubit.state.characterTheme,
); );
return GestureDetector( return GestureDetector(

@ -8,7 +8,7 @@ void main() {
test('initial state has Dash character theme', () { test('initial state has Dash character theme', () {
final characterThemeCubit = CharacterThemeCubit(); final characterThemeCubit = CharacterThemeCubit();
expect( expect(
characterThemeCubit.state.selectedCharacter, characterThemeCubit.state.characterTheme,
equals(const DashTheme()), equals(const DashTheme()),
); );
}); });

Loading…
Cancel
Save