refactor: changed names and removed replaying

pull/359/head
RuiAlonso 3 years ago
parent d3c1166964
commit 9626b88156

@ -23,14 +23,12 @@ enum GameBonus {
enum GameStatus {
waiting,
playing,
replaying,
gameOver,
}
extension GameStatusX on GameStatus {
bool get isWaiting => this == GameStatus.waiting;
bool get isPlaying =>
this == GameStatus.playing || this == GameStatus.replaying;
bool get isPlaying => this == GameStatus.playing;
bool get isGameOver => this == GameStatus.gameOver;
}

@ -73,7 +73,7 @@ class Backbox extends PositionComponent with ZIndex {
InfoDisplay(
onShare: () {
_bloc.add(
ScoreShareRequested(
ShareScoreRequested(
score: state.score,
initials: state.initials,
character: state.character,

@ -18,7 +18,7 @@ class BackboxBloc extends Bloc<BackboxEvent, BackboxState> {
super(LoadingState()) {
on<PlayerInitialsRequested>(_onPlayerInitialsRequested);
on<PlayerInitialsSubmitted>(_onPlayerInitialsSubmitted);
on<ScoreShareRequested>(_onScoreShareRequested);
on<ShareScoreRequested>(_onScoreShareRequested);
}
final LeaderboardRepository _leaderboardRepository;
@ -62,7 +62,7 @@ class BackboxBloc extends Bloc<BackboxEvent, BackboxState> {
}
Future<void> _onScoreShareRequested(
ScoreShareRequested event,
ShareScoreRequested event,
Emitter<BackboxState> emit,
) async {
emit(

@ -52,12 +52,12 @@ class PlayerInitialsSubmitted extends BackboxEvent {
List<Object?> get props => [score, initials, character];
}
/// {@template score_share_requested}
/// {@template share_score_requested}
/// Event that request the user to share score and initials.
/// {@endtemplate}
class ScoreShareRequested extends BackboxEvent {
/// {@macro score_share_requested}
const ScoreShareRequested({
class ShareScoreRequested extends BackboxEvent {
/// {@macro share_score_requested}
const ShareScoreRequested({
required this.score,
required this.initials,
required this.character,

@ -22,9 +22,6 @@ class GameBlocStatusListener extends Component
readProvider<PinballPlayer>().play(PinballAudio.backgroundMusic);
gameRef.overlays.remove(PinballGame.playButtonOverlay);
break;
case GameStatus.replaying:
gameRef.overlays.remove(PinballGame.replayButtonOverlay);
break;
case GameStatus.gameOver:
readProvider<PinballPlayer>().play(PinballAudio.gameOverVoiceOver);
gameRef.descendants().whereType<Backbox>().first.requestInitials(

@ -260,7 +260,7 @@ void main() {
verify(
() => bloc.add(
ScoreShareRequested(
ShareScoreRequested(
score: state.score,
initials: state.initials,
character: state.character,

@ -100,7 +100,7 @@ void main() {
},
build: () => BackboxBloc(leaderboardRepository: leaderboardRepository),
act: (bloc) => bloc.add(
ScoreShareRequested(
ShareScoreRequested(
score: 100,
initials: 'AAA',
character: AndroidTheme(),

@ -126,7 +126,7 @@ void main() {
group('ScoreShareRequested', () {
test('can be instantiated', () {
expect(
ScoreShareRequested(
ShareScoreRequested(
score: 0,
initials: 'AAA',
character: AndroidTheme(),
@ -137,13 +137,13 @@ void main() {
test('supports value comparison', () {
expect(
ScoreShareRequested(
ShareScoreRequested(
score: 0,
initials: 'AAA',
character: AndroidTheme(),
),
equals(
ScoreShareRequested(
ShareScoreRequested(
score: 0,
initials: 'AAA',
character: AndroidTheme(),
@ -152,14 +152,14 @@ void main() {
);
expect(
ScoreShareRequested(
ShareScoreRequested(
score: 0,
initials: 'AAA',
character: AndroidTheme(),
),
isNot(
equals(
ScoreShareRequested(
ShareScoreRequested(
score: 1,
initials: 'AAA',
character: AndroidTheme(),
@ -169,14 +169,14 @@ void main() {
);
expect(
ScoreShareRequested(
ShareScoreRequested(
score: 0,
initials: 'AAA',
character: AndroidTheme(),
),
isNot(
equals(
ScoreShareRequested(
ShareScoreRequested(
score: 0,
initials: 'AAA',
character: SparkyTheme(),
@ -186,14 +186,14 @@ void main() {
);
expect(
ScoreShareRequested(
ShareScoreRequested(
score: 0,
initials: 'AAA',
character: AndroidTheme(),
),
isNot(
equals(
ScoreShareRequested(
ShareScoreRequested(
score: 0,
initials: 'BBB',
character: AndroidTheme(),

@ -98,7 +98,7 @@ void main() {
);
flameTester.testGameWidget(
'calls onNavigate when Go to IO link is tapped',
'calls onNavigate when go to IO link is tapped',
setUp: (game, tester) async {
var tapped = false;
@ -108,10 +108,10 @@ void main() {
);
await game.pump(component);
final gotoLink =
component.descendants().whereType<GotoIOLinkComponent>().first;
final googleLink =
component.descendants().whereType<GoogleIOLinkComponent>().first;
gotoLink.onTapDown(tapDownInfo);
googleLink.onTapDown(tapDownInfo);
expect(tapped, isTrue);
},

Loading…
Cancel
Save