suggestions

lib/app/view/app.dart

@@ -15,15 +15,15 @@ class App extends StatelessWidget {
     Key? key,
     required AuthenticationRepository authenticationRepository,
     required LeaderboardRepository leaderboardRepository,
-    required PinballAudioPlayer pinballPlayer,
+    required PinballAudioPlayer pinballAudioPlayer,
   })  : _authenticationRepository = authenticationRepository,
         _leaderboardRepository = leaderboardRepository,
-        _pinballPlayer = pinballPlayer,
+        _pinballAudioPlayer = pinballAudioPlayer,
         super(key: key);
 
   final AuthenticationRepository _authenticationRepository;
   final LeaderboardRepository _leaderboardRepository;
-  final PinballAudioPlayer _pinballPlayer;
+  final PinballAudioPlayer _pinballAudioPlayer;
 
   @override
   Widget build(BuildContext context) {
@@ -31,7 +31,7 @@ class App extends StatelessWidget {
       providers: [
         RepositoryProvider.value(value: _authenticationRepository),
         RepositoryProvider.value(value: _leaderboardRepository),
-        RepositoryProvider.value(value: _pinballPlayer),
+        RepositoryProvider.value(value: _pinballAudioPlayer),
       ],
       child: MultiBlocProvider(
         providers: [

lib/main_development.dart

@@ -11,7 +11,7 @@ void main() {
   bootstrap((firestore, firebaseAuth) async {
     final leaderboardRepository = LeaderboardRepository(firestore);
     final authenticationRepository = AuthenticationRepository(firebaseAuth);
-    final pinballPlayer = PinballAudioPlayer();
+    final pinballAudioPlayer = PinballAudioPlayer();
     unawaited(
       Firebase.initializeApp().then(
         (_) => authenticationRepository.authenticateAnonymously(),
@@ -20,7 +20,7 @@ void main() {
     return App(
       authenticationRepository: authenticationRepository,
       leaderboardRepository: leaderboardRepository,
-      pinballPlayer: pinballPlayer,
+      pinballAudioPlayer: pinballAudioPlayer,
     );
   });
 }

lib/main_production.dart

@@ -11,7 +11,7 @@ void main() {
   bootstrap((firestore, firebaseAuth) async {
     final leaderboardRepository = LeaderboardRepository(firestore);
     final authenticationRepository = AuthenticationRepository(firebaseAuth);
-    final pinballPlayer = PinballAudioPlayer();
+    final pinballAudioPlayer = PinballAudioPlayer();
     unawaited(
       Firebase.initializeApp().then(
         (_) => authenticationRepository.authenticateAnonymously(),
@@ -20,7 +20,7 @@ void main() {
     return App(
       authenticationRepository: authenticationRepository,
       leaderboardRepository: leaderboardRepository,
-      pinballPlayer: pinballPlayer,
+      pinballAudioPlayer: pinballAudioPlayer,
     );
   });
 }

lib/main_staging.dart

@@ -11,7 +11,7 @@ void main() {
   bootstrap((firestore, firebaseAuth) async {
     final leaderboardRepository = LeaderboardRepository(firestore);
     final authenticationRepository = AuthenticationRepository(firebaseAuth);
-    final pinballPlayer = PinballAudioPlayer();
+    final pinballAudioPlayer = PinballAudioPlayer();
     unawaited(
       Firebase.initializeApp().then(
         (_) => authenticationRepository.authenticateAnonymously(),
@@ -20,7 +20,7 @@ void main() {
     return App(
       authenticationRepository: authenticationRepository,
       leaderboardRepository: leaderboardRepository,
-      pinballPlayer: pinballPlayer,
+      pinballAudioPlayer: pinballAudioPlayer,
     );
   });
 }

test/app/view/app_test.dart

@@ -18,13 +18,13 @@ void main() {
   group('App', () {
     late AuthenticationRepository authenticationRepository;
     late LeaderboardRepository leaderboardRepository;
-    late PinballAudioPlayer pinballPlayer;
+    late PinballAudioPlayer pinballAudioPlayer;
 
     setUp(() {
       authenticationRepository = _MockAuthenticationRepository();
       leaderboardRepository = _MockLeaderboardRepository();
-      pinballPlayer = _MockPinballAudioPlayer();
-      when(pinballPlayer.load).thenAnswer((_) => [Future.value()]);
+      pinballAudioPlayer = _MockPinballAudioPlayer();
+      when(pinballAudioPlayer.load).thenAnswer((_) => [Future.value()]);
     });
 
     testWidgets('renders PinballGamePage', (tester) async {
@@ -32,7 +32,7 @@ void main() {
         App(
           authenticationRepository: authenticationRepository,
           leaderboardRepository: leaderboardRepository,
-          pinballPlayer: pinballPlayer,
+          pinballAudioPlayer: pinballAudioPlayer,
         ),
       );
       await tester.pump(const Duration(milliseconds: 400));

test/game/components/controlled_plunger_test.dart

@@ -28,7 +28,7 @@ class _TestGame extends Forge2DGame with HasKeyboardHandlerComponents {
   Future<void> pump(
     Plunger child, {
     GameBloc? gameBloc,
-    PinballAudioPlayer? pinballPlayer,
+    PinballAudioPlayer? pinballAudioPlayer,
   }) {
     return ensureAdd(
       FlameBlocProvider<GameBloc, GameState>.value(
@@ -36,7 +36,7 @@ class _TestGame extends Forge2DGame with HasKeyboardHandlerComponents {
           ..add(const GameStarted()),
         children: [
           FlameProvider<PinballAudioPlayer>.value(
-            pinballPlayer ?? _MockPinballAudioPlayer(),
+            pinballAudioPlayer ?? _MockPinballAudioPlayer(),
             children: [child],
           )
         ],
@@ -166,7 +166,7 @@ void main() {
 
     flameTester.test('plays the correct sound on load', (game) async {
       final parent = ControlledPlunger(compressionDistance: 10);
-      await game.pump(parent, pinballPlayer: player);
+      await game.pump(parent, pinballAudioPlayer: player);
       await parent.ensureAdd(PlungerNoiseBehavior());
       verify(() => player.play(PinballAudio.launcher)).called(1);
     });

test/game/components/game_bloc_status_listener_test.dart

@@ -30,7 +30,7 @@ class _TestGame extends Forge2DGame {
 
   Future<void> pump(
     Iterable<Component> children, {
-    PinballAudioPlayer? pinballPlayer,
+    PinballAudioPlayer? pinballAudioPlayer,
   }) async {
     return ensureAdd(
       FlameMultiBlocProvider(
@@ -46,7 +46,7 @@ class _TestGame extends Forge2DGame {
           MultiFlameProvider(
             providers: [
               FlameProvider<PinballAudioPlayer>.value(
-                pinballPlayer ?? _MockPinballAudioPlayer(),
+                pinballAudioPlayer ?? _MockPinballAudioPlayer(),
               ),
               FlameProvider<AppLocalizations>.value(
                 _MockAppLocalizations(),
@@ -198,7 +198,7 @@ void main() {
               leaderboardRepository: repository,
               entries: const [],
             );
-            await game.pump([component, backbox], pinballPlayer: player);
+            await game.pump([component, backbox], pinballAudioPlayer: player);
 
             component.onNewState(state);
 
@@ -221,7 +221,7 @@ void main() {
           (game) async {
             final player = _MockPinballAudioPlayer();
             final component = GameBlocStatusListener();
-            await game.pump([component], pinballPlayer: player);
+            await game.pump([component], pinballAudioPlayer: player);
 
             expect(state.status, equals(GameStatus.playing));
             component.onNewState(state);

test/helpers/pump_app.dart

@@ -55,7 +55,7 @@ extension PumpApp on WidgetTester {
     AssetsManagerCubit? assetsManagerCubit,
     CharacterThemeCubit? characterThemeCubit,
     LeaderboardRepository? leaderboardRepository,
-    PinballAudioPlayer? pinballPlayer,
+    PinballAudioPlayer? pinballAudioPlayer,
   }) {
     return runAsync(() {
       return pumpWidget(
@@ -65,7 +65,7 @@ extension PumpApp on WidgetTester {
               value: leaderboardRepository ?? _MockLeaderboardRepository(),
             ),
             RepositoryProvider.value(
-              value: pinballPlayer ?? _buildDefaultPinballAudioPlayer(),
+              value: pinballAudioPlayer ?? _buildDefaultPinballAudioPlayer(),
             ),
           ],
           child: MultiBlocProvider(

test/start_game/widgets/start_game_listener_test.dart

@@ -241,7 +241,7 @@ void main() {
               child: SizedBox.shrink(),
             ),
             startGameBloc: startGameBloc,
-            pinballPlayer: pinballAudioPlayer,
+            pinballAudioPlayer: pinballAudioPlayer,
           );
           await tester.pumpAndSettle();