fix: apply code review

lib/app/view/app.dart

@@ -37,20 +37,14 @@ class App extends StatelessWidget {
       ],
       child: BlocProvider(
         create: (context) => ThemeCubit(),
-        child: MaterialApp(
+        child: const MaterialApp(
           title: 'I/O Pinball',
-          theme: ThemeData(
+          localizationsDelegates: [
-            appBarTheme: const AppBarTheme(color: Color(0xFF13B9FF)),
-            colorScheme: ColorScheme.fromSwatch(
-              accentColor: const Color(0xFF13B9FF),
-            ),
-          ),
-          localizationsDelegates: const [
             AppLocalizations.delegate,
             GlobalMaterialLocalizations.delegate,
           ],
           supportedLocales: AppLocalizations.supportedLocales,
-          home: const PinballGamePage(),
+          home: PinballGamePage(),
         ),
       ),
     );

lib/game/view/pinball_game_page.dart

@@ -5,7 +5,7 @@ import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:pinball/game/game.dart';
-import 'package:pinball/start_game/bloc/start_game_bloc.dart';
+import 'package:pinball/start_game/start_game.dart';
 import 'package:pinball/theme/theme.dart';
 import 'package:pinball_audio/pinball_audio.dart';
 
@@ -76,17 +76,16 @@ class PinballGameView extends StatelessWidget {
     return Scaffold(
       backgroundColor: Colors.blue,
       body: isLoading
-          ? const PinballGameLoadedView()
+          ? const _PinballGameLoadingView()
-          : PinballGameBody(
+          : PinballGameLoadedView(
               game: game,
             ),
     );
   }
 }
 
-@visibleForTesting
+class _PinballGameLoadingView extends StatelessWidget {
-class PinballGameLoadedView extends StatelessWidget {
+  const _PinballGameLoadingView({Key? key}) : super(key: key);
-  const PinballGameLoadedView({Key? key}) : super(key: key);
 
   @override
   Widget build(BuildContext context) {
@@ -107,8 +106,8 @@ class PinballGameLoadedView extends StatelessWidget {
 }
 
 @visibleForTesting
-class PinballGameBody extends StatelessWidget {
+class PinballGameLoadedView extends StatelessWidget {
-  const PinballGameBody({
+  const PinballGameLoadedView({
     Key? key,
     required this.game,
   }) : super(key: key);

lib/game/view/widgets/play_button_overlay.dart

@@ -34,7 +34,7 @@ class PlayButtonOverlay extends StatelessWidget {
                 child: SizedBox(
                   height: height,
                   width: width,
-                  child: const CharacterSelectionPage(),
+                  child: const CharacterSelectionDialog(),
                 ),
               );
             },

lib/leaderboard/view/leaderboard_page.dart

@@ -69,7 +69,7 @@ class LeaderboardView extends StatelessWidget {
               const SizedBox(height: 20),
               TextButton(
                 onPressed: () => Navigator.of(context).push<void>(
-                  CharacterSelectionPage.route(),
+                  CharacterSelectionDialog.route(),
                 ),
                 child: Text(l10n.retry),
               ),

lib/theme/view/character_selection_page.dart

@@ -7,12 +7,12 @@ import 'package:pinball/start_game/start_game.dart';
 import 'package:pinball/theme/theme.dart';
 import 'package:pinball_theme/pinball_theme.dart';
 
-class CharacterSelectionPage extends StatelessWidget {
+class CharacterSelectionDialog extends StatelessWidget {
-  const CharacterSelectionPage({Key? key}) : super(key: key);
+  const CharacterSelectionDialog({Key? key}) : super(key: key);
 
   static Route route() {
     return MaterialPageRoute<void>(
-      builder: (_) => const CharacterSelectionPage(),
+      builder: (_) => const CharacterSelectionDialog(),
     );
   }
 

test/game/view/pinball_game_page_test.dart

@@ -72,22 +72,37 @@ void main() {
           ),
           findsOneWidget,
         );
+      },
+    );
 
-        final loadedAssetsState = AssetsManagerState(
+    testWidgets(
-          loadables: [Future<void>.value()],
+        'renders PinballGameLoadedView after resources have been loaded',
-          loaded: [Future<void>.value()],
+        (tester) async {
-        );
+      final assetsManagerCubit = MockAssetsManagerCubit();
-        whenListen(
+
-          assetsManagerCubit,
+      final loadedAssetsState = AssetsManagerState(
-          Stream.value(loadedAssetsState),
+        loadables: [Future<void>.value()],
-          initialState: loadedAssetsState,
+        loaded: [Future<void>.value()],
-        );
+      );
+      whenListen(
+        assetsManagerCubit,
+        Stream.value(loadedAssetsState),
+        initialState: loadedAssetsState,
+      );
+
+      await tester.pumpApp(
+        PinballGameView(
+          game: game,
+        ),
+        assetsManagerCubit: assetsManagerCubit,
+        themeCubit: themeCubit,
+        gameBloc: gameBloc,
+      );
 
-        await tester.pump();
+      await tester.pump();
 
-        expect(find.byType(PinballGameBody), findsOneWidget);
+      expect(find.byType(PinballGameLoadedView), findsOneWidget);
-      },
+    });
-    );
 
     group('route', () {
       Future<void> pumpRoute({

test/game/view/widgets/play_button_overlay_test.dart

@@ -33,14 +33,14 @@ void main() {
       verify(gameFlowController.start).called(1);
     });
 
-    testWidgets('is showing CharacterSelectionPage dialog when taped',
+    testWidgets('is showing CharacterSelectionPage dialog when tapped',
         (tester) async {
       await tester.pumpApp(PlayButtonOverlay(game: game));
 
       await tester.tap(find.text('Play'));
       await tester.pump();
 
-      expect(find.byType(CharacterSelectionPage), findsOneWidget);
+      expect(find.byType(CharacterSelectionDialog), findsOneWidget);
     });
   });
 }

test/theme/view/character_selection_page_test.dart

@@ -25,7 +25,7 @@ void main() {
   group('CharacterSelectionPage', () {
     testWidgets('renders CharacterSelectionView', (tester) async {
       await tester.pumpApp(
-        CharacterSelectionPage(),
+        CharacterSelectionDialog(),
         themeCubit: themeCubit,
       );
       expect(find.byType(CharacterSelectionView), findsOneWidget);
@@ -39,7 +39,7 @@ void main() {
               return ElevatedButton(
                 onPressed: () {
                   Navigator.of(context)
-                      .push<void>(CharacterSelectionPage.route());
+                      .push<void>(CharacterSelectionDialog.route());
                 },
                 child: Text('Tap me'),
               );
@@ -52,7 +52,7 @@ void main() {
       await tester.tap(find.text('Tap me'));
       await tester.pumpAndSettle();
 
-      expect(find.byType(CharacterSelectionPage), findsOneWidget);
+      expect(find.byType(CharacterSelectionDialog), findsOneWidget);
     });
   });