msb-public
/
pinball
mirror of https://github.com/flutter/pinball.git
1
0
Code Issues Projects Releases Wiki Activity

feat: improved tests

Browse Source
pull/119/head
alestiago 4 years ago
parent 37d583ba6d
commit 30330da306
3 changed files with 294 additions and 95 deletions
Show Stats Download Patch File Download Diff File

59
lib/game/components/flutter_forest.dart
Unescape View File

@ -16,11 +16,10 @@ import 'package:pinball_components/pinball_components.dart';
/// is awarded, and the [BigDashNestBumper] releases a new [Ball].
/// {@endtemplate}
// TODO(alestiago): Make a [Blueprint] once [Blueprint] inherits from [Component].
class FlutterForest extends Component
with Controls<FlutterForestController>, HasGameRef<PinballGame> {
class FlutterForest extends Component with Controls<_FlutterForestController> {
/// {@macro flutter_forest}
FlutterForest() {
controller = FlutterForestController(this);
controller = _FlutterForestController(this);
}
@override
@ -28,14 +27,15 @@ class FlutterForest extends Component
await super.onLoad();
final signPost = FlutterSignPost()..initialPosition = Vector2(8.35, 58.3);
final bigNest = ControlledBigDashNestBumper(id: 'big_nest_bumper')
..initialPosition = Vector2(18.55, 59.35);
final smallLeftNest =
ControlledSmallDashNestBumper.a(id: 'small_nest_bumper_a')
..initialPosition = Vector2(8.95, 51.95);
final smallRightNest =
ControlledSmallDashNestBumper.b(id: 'small_nest_bumper_b')
..initialPosition = Vector2(23.3, 46.75);
final bigNest = _ControlledBigDashNestBumper(
id: 'big_nest_bumper',
)..initialPosition = Vector2(18.55, 59.35);
final smallLeftNest = _ControlledSmallDashNestBumper.a(
id: 'small_nest_bumper_a',
)..initialPosition = Vector2(8.95, 51.95);
final smallRightNest = _ControlledSmallDashNestBumper.b(
id: 'small_nest_bumper_b',
)..initialPosition = Vector2(23.3, 46.75);
await addAll([
signPost,
@ -49,15 +49,15 @@ class FlutterForest extends Component
/// {@template flutter_forest_controller}
///
/// {@endtemplate}
class FlutterForestController extends ComponentController<FlutterForest>
class _FlutterForestController extends ComponentController<FlutterForest>
with BlocComponent<GameBloc, GameState>, HasGameRef<PinballGame> {
/// {@macro flutter_forest_controller}
FlutterForestController(FlutterForest flutterForest) : super(flutterForest);
_FlutterForestController(FlutterForest flutterForest) : super(flutterForest);
@override
Future<void> onLoad() async {
await super.onLoad();
gameRef.addContactCallback(ControlledDashNestBumperBallContactCallback());
gameRef.addContactCallback(_ControlledDashNestBumperBallContactCallback());
}
@override
@ -81,10 +81,10 @@ class FlutterForestController extends ComponentController<FlutterForest>
/// {@template controlled_big_dash_nest_bumper}
/// A [BigDashNestBumper] controlled by a [DashNestBumperController].
/// {@endtemplate}
class ControlledBigDashNestBumper extends BigDashNestBumper
class _ControlledBigDashNestBumper extends BigDashNestBumper
with Controls<DashNestBumperController>, ScorePoints {
/// {@macro controlled_big_dash_nest_bumper}
ControlledBigDashNestBumper({required String id}) : super() {
_ControlledBigDashNestBumper({required String id}) : super() {
controller = DashNestBumperController(this, id: id);
}
@ -95,15 +95,15 @@ class ControlledBigDashNestBumper extends BigDashNestBumper
/// {@template controlled_small_dash_nest_bumper}
/// A [SmallDashNestBumper] controlled by a [DashNestBumperController].
/// {@endtemplate}
class ControlledSmallDashNestBumper extends SmallDashNestBumper
class _ControlledSmallDashNestBumper extends SmallDashNestBumper
with Controls<DashNestBumperController>, ScorePoints {
/// {@macro controlled_small_dash_nest_bumper}
ControlledSmallDashNestBumper.a({required String id}) : super.a() {
_ControlledSmallDashNestBumper.a({required String id}) : super.a() {
controller = DashNestBumperController(this, id: id);
}
/// {@macro controlled_small_dash_nest_bumper}
ControlledSmallDashNestBumper.b({required String id}) : super.b() {
_ControlledSmallDashNestBumper.b({required String id}) : super.b() {
controller = DashNestBumperController(this, id: id);
}
@ -114,24 +114,24 @@ class ControlledSmallDashNestBumper extends SmallDashNestBumper
/// {@template dash_nest_bumper_controller}
/// Controls a [DashNestBumper].
/// {@endtemplate}
@visibleForTesting
class DashNestBumperController extends ComponentController<DashNestBumper>
with BlocComponent<GameBloc, GameState>, HasGameRef<PinballGame> {
/// {@macro dash_nest_bumper_controller}
DashNestBumperController(
DashNestBumper dashNestBumper, {
required String id,
}) : _id = id,
super(dashNestBumper);
required this.id,
}) : super(dashNestBumper);
/// Unique identifier for the controlled [DashNestBumper].
///
/// Used to identify [DashNestBumper]s in [GameState.activatedDashNests].
final String _id;
final String id;
@override
bool listenWhen(GameState? previousState, GameState newState) {
final wasActive = previousState?.activatedDashNests.contains(_id) ?? false;
final isActive = newState.activatedDashNests.contains(_id);
final wasActive = previousState?.activatedDashNests.contains(id) ?? false;
final isActive = newState.activatedDashNests.contains(id);
return wasActive != isActive;
}
@ -140,7 +140,7 @@ class DashNestBumperController extends ComponentController<DashNestBumper>
void onNewState(GameState state) {
super.onNewState(state);
if (state.activatedDashNests.contains(_id)) {
if (state.activatedDashNests.contains(id)) {
component.activate();
} else {
component.deactivate();
@ -149,15 +149,14 @@ class DashNestBumperController extends ComponentController<DashNestBumper>
/// Registers when a [DashNestBumper] is hit by a [Ball].
///
/// Triggered by [ControlledDashNestBumperBallContactCallback].
/// Triggered by [_ControlledDashNestBumperBallContactCallback].
void hit() {
gameRef.read<GameBloc>().add(DashNestActivated(_id));
gameRef.read<GameBloc>().add(DashNestActivated(id));
}
}
/// Listens when a [Ball] bounces bounces against a [DashNestBumper]
@visibleForTesting
class ControlledDashNestBumperBallContactCallback
class _ControlledDashNestBumperBallContactCallback
extends ContactCallback<Controls<DashNestBumperController>, Ball> {
@override
void begin(

34
packages/pinball_components/test/src/components/dash_nest_bumper_test.dart
Unescape View File

@ -0,0 +1,34 @@
// ignore_for_file: cascade_invocations
import 'package:flame_test/flame_test.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pinball_components/pinball_components.dart';
import '../../helpers/helpers.dart';
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
final flameTester = FlameTester(TestGame.new);
group('BigDashNestBumper', () {
flameTester.test('loads correctly', (game) async {
final bigNest = BigDashNestBumper();
await game.ensureAdd(bigNest);
expect(game.contains(bigNest), isTrue);
});
});
group('SmallDashNestBumper', () {
flameTester.test('"a" loads correctly', (game) async {
final smallNest = SmallDashNestBumper.a();
await game.ensureAdd(smallNest);
expect(game.contains(smallNest), isTrue);
});
flameTester.test('"b" loads correctly', (game) async {
final smallNest = SmallDashNestBumper.b();
await game.ensureAdd(smallNest);
expect(game.contains(smallNest), isTrue);
});
});
}

254
test/game/components/flutter_forest_test.dart
Unescape View File

@ -1,7 +1,12 @@
// ignore_for_file: cascade_invocations
import 'dart:math';
import 'package:bloc_test/bloc_test.dart';
import 'package:flame/components.dart';
import 'package:flame_forge2d/flame_forge2d.dart';
import 'package:flame_test/flame_test.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:mocktail/mocktail.dart';
import 'package:pinball/game/game.dart';
@ -9,6 +14,18 @@ import 'package:pinball_components/pinball_components.dart';
import '../../helpers/helpers.dart';
void beginContact(Forge2DGame game, BodyComponent bodyA, BodyComponent bodyB) {
assert(
bodyA.body.fixtures.isNotEmpty && bodyB.body.fixtures.isNotEmpty,
'Bodies require fixtures to contact each other.',
);
final fixtureA = bodyA.body.fixtures.first;
final fixtureB = bodyB.body.fixtures.first;
final contact = Contact.init(fixtureA, 0, fixtureB, 0);
game.world.contactManager.contactListener?.beginContact(contact);
}
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
final flameTester = FlameTester(PinballGameTest.create);
@ -30,33 +47,46 @@ void main() {
'a FlutterSignPost',
(game) async {
await game.ready();
final flutterForest = FlutterForest();
await game.ensureAdd(flutterForest);
expect(
game.descendants().whereType<FlutterSignPost>().length,
flutterForest.descendants().whereType<FlutterSignPost>().length,
equals(1),
);
},
);
});
flameTester.test(
'onNewState adds a new ball',
'a BigDashNestBumper',
(game) async {
final flutterForest = FlutterForest();
await game.ready();
final flutterForest = FlutterForest();
await game.ensureAdd(flutterForest);
final previousBalls = game.descendants().whereType<Ball>().length;
flutterForest.onNewState(MockGameState());
expect(
flutterForest.descendants().whereType<BigDashNestBumper>().length,
equals(1),
);
},
);
flameTester.test(
'two SmallDashNestBumper',
(game) async {
await game.ready();
final flutterForest = FlutterForest();
await game.ensureAdd(flutterForest);
expect(
game.descendants().whereType<Ball>().length,
greaterThan(previousBalls),
flutterForest.descendants().whereType<SmallDashNestBumper>().length,
equals(2),
);
},
);
});
group('controller', () {
group('listenWhen', () {
final gameBloc = MockGameBloc();
final tester = flameBlocTester(
@ -64,14 +94,6 @@ void main() {
gameBloc: () => gameBloc,
);
setUp(() {
whenListen(
gameBloc,
const Stream<GameState>.empty(),
initialState: const GameState.initial(),
);
});
tester.testGameWidget(
'listens when a Bonus.dashNest is added',
verify: (game, tester) async {
@ -85,7 +107,8 @@ void main() {
bonusHistory: [GameBonus.dashNest],
);
expect(
flutterForest.listenWhen(const GameState.initial(), state),
flutterForest.controller
.listenWhen(const GameState.initial(), state),
isTrue,
);
},
@ -93,15 +116,31 @@ void main() {
});
});
group('DashNestBumperBallContactCallback', () {
final gameBloc = MockGameBloc();
final tester = flameBlocTester(
// TODO(alestiago): Use TestGame.new once a controller is implemented.
game: PinballGameTest.create,
gameBloc: () => gameBloc,
flameTester.test(
'onNewState adds a new ball',
(game) async {
final flutterForest = FlutterForest();
await game.ready();
await game.ensureAdd(flutterForest);
final previousBalls = game.descendants().whereType<Ball>().length;
flutterForest.controller.onNewState(MockGameState());
await game.ready();
expect(
game.descendants().whereType<Ball>().length,
greaterThan(previousBalls),
);
},
);
group('bumpers', () {
late Ball ball;
late GameBloc gameBloc;
setUp(() {
ball = Ball(baseColor: const Color(0xFF00FFFF));
gameBloc = MockGameBloc();
whenListen(
gameBloc,
const Stream<GameState>.empty(),
@ -109,43 +148,170 @@ void main() {
);
});
final dashNestBumper = MockDashNestBumper();
final tester = flameBlocTester<PinballGame>(
game: PinballGameTest.create,
gameBloc: () => gameBloc,
);
tester.testGameWidget(
'adds a DashNestActivated event with DashNestBumper.id',
'add DashNestActivated event',
setUp: (game, tester) async {
const id = '0';
when(() => dashNestBumper.id).thenReturn(id);
when(() => dashNestBumper.gameRef).thenReturn(game);
final flutterForest = FlutterForest();
await game.ensureAdd(flutterForest);
await game.ensureAdd(ball);
final bumpers =
flutterForest.descendants().whereType<DashNestBumper>();
for (final bumper in bumpers) {
beginContact(game, bumper, ball);
final controller = bumper.firstChild<DashNestBumperController>()!;
// TODO(alestiago): Investiagate why is is being called twice
// instead of once.
verify(
() => gameBloc.add(DashNestActivated(controller.id)),
).called(2);
}
},
verify: (game, tester) async {
final contactCallback = DashNestBumperBallContactCallback();
contactCallback.begin(dashNestBumper, MockBall(), MockContact());
);
tester.testGameWidget(
'add Scored event',
setUp: (game, tester) async {
final flutterForest = FlutterForest();
await game.ensureAdd(flutterForest);
await game.ensureAdd(ball);
final bumpers =
flutterForest.descendants().whereType<DashNestBumper>();
for (final bumper in bumpers) {
beginContact(game, bumper, ball);
final points = (bumper as ScorePoints).points;
verify(
() => gameBloc.add(DashNestActivated(dashNestBumper.id)),
() => gameBloc.add(Scored(points: points)),
).called(1);
}
},
);
});
});
group('DashNestBumperController', () {
late DashNestBumper dashNestBumper;
group('BigDashNestBumper', () {
test('has points', () {
final dashNestBumper = BigDashNestBumper(id: '');
expect(dashNestBumper.points, greaterThan(0));
setUp(() {
dashNestBumper = MockDashNestBumper();
});
group(
'listensWhen',
() {
late GameState previousState;
late GameState newState;
setUp(
() {
previousState = MockGameState();
newState = MockGameState();
},
);
test('listens when the id is added to activatedDashNests', () {
const id = '';
final controller = DashNestBumperController(
dashNestBumper,
id: id,
);
when(() => previousState.activatedDashNests).thenReturn({});
when(() => newState.activatedDashNests).thenReturn({id});
expect(controller.listenWhen(previousState, newState), isTrue);
});
group('SmallDashNestBumper', () {
group('has points', () {
test('when a', () {
final dashNestBumper = SmallDashNestBumper.a(id: '');
expect(dashNestBumper.points, greaterThan(0));
test('listens when the id is removed to activatedDashNests', () {
const id = '';
final controller = DashNestBumperController(
dashNestBumper,
id: id,
);
when(() => previousState.activatedDashNests).thenReturn({id});
when(() => newState.activatedDashNests).thenReturn({});
expect(controller.listenWhen(previousState, newState), isTrue);
});
test('when b', () {
final dashNestBumper = SmallDashNestBumper.b(id: '');
expect(dashNestBumper.points, greaterThan(0));
test("doesn't listen when the id is never in activatedDashNests", () {
final controller = DashNestBumperController(
dashNestBumper,
id: '',
);
when(() => previousState.activatedDashNests).thenReturn({});
when(() => newState.activatedDashNests).thenReturn({});
expect(controller.listenWhen(previousState, newState), isFalse);
});
test("doesn't listen when the id still in activatedDashNests", () {
const id = '';
final controller = DashNestBumperController(
dashNestBumper,
id: id,
);
when(() => previousState.activatedDashNests).thenReturn({id});
when(() => newState.activatedDashNests).thenReturn({id});
expect(controller.listenWhen(previousState, newState), isFalse);
});
},
);
group(
'onNewState',
() {
late GameState state;
setUp(() {
state = MockGameState();
});
test(
'activates the bumper when id in activatedDashNests',
() {
const id = '';
final controller = DashNestBumperController(
dashNestBumper,
id: id,
);
when(() => state.activatedDashNests).thenReturn({id});
controller.onNewState(state);
verify(() => dashNestBumper.activate()).called(1);
},
);
test(
'deactivates the bumper when id not in activatedDashNests',
() {
final controller = DashNestBumperController(
dashNestBumper,
id: '',
);
when(() => state.activatedDashNests).thenReturn({});
controller.onNewState(state);
verify(() => dashNestBumper.deactivate()).called(1);
},
);
},
);
});
}
class MockDashNestBumper extends Mock implements DashNestBumper {}

Write Preview
Loading…
Cancel
Save