Merge branch 'fix/spaceship-ramp-logic' of github.com:VGVentures/pinball into fix/spaceship-ramp-logic

packages/pinball_components/test/src/components/spaceship_ramp/cubit/spaceship_ramp_state_test.dart

@@ -47,7 +47,7 @@ void main() {
     });
 
     test(
-      'fullArrowLit returns if lightState is last one',
+      'fullArrowLit returns true when lightState is last one',
       () {
         expect(
           SpaceshipRampState.initial().fullArrowLit,

test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart

@@ -67,7 +67,7 @@ void main() {
 
     flameTester.test(
       'adds onProgressed '
-      'when hits and multiplier is less than 6',
+      'when hits and multiplier are less than 6',
       (game) async {
         final bloc = _MockSpaceshipRampCubit();
         final state = SpaceshipRampState.initial();
@@ -104,7 +104,7 @@ void main() {
 
     flameTester.test(
       'adds onProgressed '
-      'when hits and multiplier is 6 but arrow is not full lit',
+      'when hits and multiplier are 6 but arrow is not fully lit',
       (game) async {
         final bloc = _MockSpaceshipRampCubit();
         final state = SpaceshipRampState.initial();
@@ -141,7 +141,7 @@ void main() {
 
     flameTester.test(
       "doesn't add onProgressed "
-      'when hits and multiplier is 6 and arrow is full lit',
+      'when hits and multiplier are 6 and arrow is fully lit',
       (game) async {
         final bloc = _MockSpaceshipRampCubit();
         final state = SpaceshipRampState.initial();
@@ -182,8 +182,8 @@ void main() {
     );
 
     flameTester.test(
-      'adds again onProgressed to dimmed all '
-      'when arrow is full lit after hit and multiplier is less than 6',
+      'adds onProgressed to dim arrow '
+      'when arrow is fully lit after hit and multiplier is less than 6',
       (game) async {
         final bloc = _MockSpaceshipRampCubit();
         final state = SpaceshipRampState.initial();
@@ -224,8 +224,8 @@ void main() {
     );
 
     flameTester.test(
-      "doesn't add again onProgressed to dimmed all "
-      'when arrow is not full lit after hit',
+      "doesn't add onProgressed to dim arrow "
+      'when arrow is not fully lit after hit',
       (game) async {
         final bloc = _MockSpaceshipRampCubit();
         final state = SpaceshipRampState.initial();
@@ -266,7 +266,7 @@ void main() {
     );
 
     flameTester.test(
-      "doesn't add again onProgressed to dimmed all "
+      "doesn't add onProgressed to dim arrow "
       'when multiplier is 6 after hit',
       (game) async {
         final bloc = _MockSpaceshipRampCubit();

test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart

@@ -66,7 +66,7 @@ void main() {
     final flameTester = FlameTester(_TestGame.new);
 
     flameTester.test(
-      'when round lost call onReset',
+      'calls onReset when round lost',
       (game) async {
         final bloc = _MockSpaceshipRampCubit();
         final state = GameState.initial();
@@ -95,7 +95,7 @@ void main() {
     );
 
     flameTester.test(
-      "when round doesn't change never call onReset",
+      "doesn't call onReset when round stays the same",
       (game) async {
         final bloc = _MockSpaceshipRampCubit();
         final state = GameState.initial();

test/game/components/android_acres/behaviors/ramp_shot_behavior_test.dart

@@ -69,7 +69,7 @@ void main() {
     final flameTester = FlameTester(_TestGame.new);
 
     flameTester.test(
-      'when hits adds a ScoringBehavior',
+      'adds a ScoringBehavior when hit',
       (game) async {
         final bloc = _MockSpaceshipRampCubit();
         final state = SpaceshipRampState.initial();