From 4ff65277fec290e17b947d7428e2b8ffd6dd6c2c Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:26:17 +0200 Subject: [PATCH 01/10] Update test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_progress_behavior_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart index fec9b72b..05b875fd 100644 --- a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart @@ -269,7 +269,7 @@ void main() { ); flameTester.test( - "doesn't add again onProgressed to dimmed all " + "doesn't add onProgressed to dim arrow " 'when multiplier is 6 after hit', (game) async { final bloc = _MockSpaceshipRampCubit(); From ece70d81584e1b37f6f847a08d5d8d3db1161e7b Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:26:26 +0200 Subject: [PATCH 02/10] Update test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_reset_behavior_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart index 80cff43a..7c80ddbb 100644 --- a/test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart @@ -95,7 +95,7 @@ void main() { ); flameTester.test( - "when round doesn't change never call onReset", + "doesn't call onReset when round stays the same", (game) async { final bloc = _MockSpaceshipRampCubit(); final state = GameState.initial(); From 8a09c228007f7703dbd43af7cc7a39975c09d022 Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:26:34 +0200 Subject: [PATCH 03/10] Update test/game/components/android_acres/behaviors/ramp_shot_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_shot_behavior_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/game/components/android_acres/behaviors/ramp_shot_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_shot_behavior_test.dart index 49a88a62..8a9c8fc3 100644 --- a/test/game/components/android_acres/behaviors/ramp_shot_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_shot_behavior_test.dart @@ -69,7 +69,7 @@ void main() { final flameTester = FlameTester(_TestGame.new); flameTester.test( - 'when hits adds a ScoringBehavior', + 'adds a ScoringBehavior when hit', (game) async { final bloc = _MockSpaceshipRampCubit(); final state = SpaceshipRampState.initial(); From 56e8b8ec107d59fdc86a48437641f197573540c8 Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:26:42 +0200 Subject: [PATCH 04/10] Update test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_reset_behavior_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart index 7c80ddbb..74946e09 100644 --- a/test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_reset_behavior_test.dart @@ -66,7 +66,7 @@ void main() { final flameTester = FlameTester(_TestGame.new); flameTester.test( - 'when round lost call onReset', + 'calls onReset when round lost', (game) async { final bloc = _MockSpaceshipRampCubit(); final state = GameState.initial(); From 136c1b293f3160497c63aa28fd25062f5fc6fca3 Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:37:47 +0200 Subject: [PATCH 05/10] Update packages/pinball_components/test/src/components/spaceship_ramp/cubit/spaceship_ramp_state_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../spaceship_ramp/cubit/spaceship_ramp_state_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pinball_components/test/src/components/spaceship_ramp/cubit/spaceship_ramp_state_test.dart b/packages/pinball_components/test/src/components/spaceship_ramp/cubit/spaceship_ramp_state_test.dart index 77cf20c3..e7a2a859 100644 --- a/packages/pinball_components/test/src/components/spaceship_ramp/cubit/spaceship_ramp_state_test.dart +++ b/packages/pinball_components/test/src/components/spaceship_ramp/cubit/spaceship_ramp_state_test.dart @@ -47,7 +47,7 @@ void main() { }); test( - 'fullArrowLit returns if lightState is last one', + 'fullArrowLit returns true when lightState is last one', () { expect( SpaceshipRampState.initial().fullArrowLit, From 9e297f3d6464b47f181d2454d632538fe5cb18ce Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:39:38 +0200 Subject: [PATCH 06/10] Update test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_progress_behavior_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart index 05b875fd..433c5e35 100644 --- a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart @@ -107,7 +107,7 @@ void main() { flameTester.test( 'adds onProgressed ' - 'when hits and multiplier is 6 but arrow is not full lit', + 'when hits and multiplier are 6 but arrow is not fully lit', (game) async { final bloc = _MockSpaceshipRampCubit(); final state = SpaceshipRampState.initial(); From 72dc87025450f756c87347d20cada17dda1f09d2 Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:39:53 +0200 Subject: [PATCH 07/10] Update test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_progress_behavior_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart index 433c5e35..68dafcc5 100644 --- a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart @@ -70,7 +70,7 @@ void main() { flameTester.test( 'adds onProgressed ' - 'when hits and multiplier is less than 6', + 'when hits and multiplier are less than 6', (game) async { final bloc = _MockSpaceshipRampCubit(); final state = SpaceshipRampState.initial(); From d64d5d8b16724d1fd673bc4e810158c70e892f0d Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:40:09 +0200 Subject: [PATCH 08/10] Update test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_progress_behavior_test.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart index 68dafcc5..77e7f72b 100644 --- a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart @@ -185,8 +185,8 @@ void main() { ); flameTester.test( - 'adds again onProgressed to dimmed all ' - 'when arrow is full lit after hit and multiplier is less than 6', + 'adds onProgressed to dim arrow ' + 'when arrow is fully lit after hit and multiplier is less than 6', (game) async { final bloc = _MockSpaceshipRampCubit(); final state = SpaceshipRampState.initial(); From f67fcc8e9d600ba4f40e96df6b6dd65d31a94f59 Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:40:21 +0200 Subject: [PATCH 09/10] Update test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_progress_behavior_test.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart index 77e7f72b..ac0aa5a3 100644 --- a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart @@ -227,8 +227,8 @@ void main() { ); flameTester.test( - "doesn't add again onProgressed to dimmed all " - 'when arrow is not full lit after hit', + "doesn't add onProgressed to dim arrow " + 'when arrow is not fully lit after hit', (game) async { final bloc = _MockSpaceshipRampCubit(); final state = SpaceshipRampState.initial(); From eaed91d7e81f9e2cb74783105fa2f5c14cdc2308 Mon Sep 17 00:00:00 2001 From: Rui Miguel Alonso Date: Mon, 9 May 2022 16:40:36 +0200 Subject: [PATCH 10/10] Update test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../android_acres/behaviors/ramp_progress_behavior_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart index ac0aa5a3..8bf72977 100644 --- a/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart +++ b/test/game/components/android_acres/behaviors/ramp_progress_behavior_test.dart @@ -144,7 +144,7 @@ void main() { flameTester.test( "doesn't add onProgressed " - 'when hits and multiplier is 6 and arrow is full lit', + 'when hits and multiplier are 6 and arrow is fully lit', (game) async { final bloc = _MockSpaceshipRampCubit(); final state = SpaceshipRampState.initial();