feat: pr suggestions

pull/60/head
Erick Zanardo 4 years ago
parent 65c00d638e
commit 199f3bf9a8

@ -297,7 +297,7 @@ class SpaceshipWall extends BodyComponent with InitialPosition {
class SpaceshipEntranceBallContactCallback
extends ContactCallback<SpaceshipEntrance, Ball> {
@override
void begin(SpaceshipEntrance entrance, Ball ball, Contact contact) {
void begin(SpaceshipEntrance entrance, Ball ball, _) {
ball
..priority = 3
..gameRef.reorderChildren();
@ -318,9 +318,10 @@ class SpaceshipEntranceBallContactCallback
class SpaceshipHoleBallContactCallback
extends ContactCallback<SpaceshipHole, Ball> {
@override
void begin(SpaceshipHole hole, Ball ball, Contact contact) {
ball.priority = 1;
ball.gameRef.reorderChildren();
void begin(SpaceshipHole hole, Ball ball, _) {
ball
..priority = 1
..gameRef.reorderChildren();
for (final fixture in ball.body.fixtures) {
fixture.filterData.categoryBits = 0xFFFF;

@ -82,28 +82,16 @@ class PinballGame extends Forge2DGame
Future<void> _addSpaceship() async {
final position = Vector2(20, -24);
unawaited(add(SpaceshipSaucer()..initialPosition = position));
unawaited(add(SpaceshipEntrance()..initialPosition = position));
unawaited(add(SpaceshipBridge()..initialPosition = position));
unawaited(
add(
await addAll(
[
SpaceshipSaucer()..initialPosition = position,
SpaceshipEntrance()..initialPosition = position,
SpaceshipBridge()..initialPosition = position,
SpaceshipBridgeTop()..initialPosition = position + Vector2(0, 5.5),
),
);
unawaited(
add(
SpaceshipHole()..initialPosition = position - Vector2(5, 4),
),
);
unawaited(
add(
SpaceshipHole()..initialPosition = position - Vector2(-5, 4),
),
);
unawaited(
add(SpaceshipWall()..initialPosition = position),
SpaceshipWall()..initialPosition = position,
],
);
}

Loading…
Cancel
Save