fix: mock flame images (#332)

test/game/view/widgets/bonus_animation_test.dart

@@ -1,9 +1,5 @@
 // ignore_for_file: invalid_use_of_protected_member
 
-import 'dart:typed_data';
-
-import 'package:flame/assets.dart';
-import 'package:flame/flame.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:mocktail/mocktail.dart';
@@ -13,8 +9,6 @@ import 'package:pinball_flame/pinball_flame.dart';
 
 import '../../../helpers/helpers.dart';
 
-class _MockImages extends Mock implements Images {}
-
 class _MockCallback extends Mock {
   void call();
 }
@@ -24,13 +18,7 @@ void main() {
   const animationDuration = 6;
 
   setUp(() async {
-    // TODO(arturplaczek): need to find for a better solution for loading image
+    await mockFlameImages();
-    // or use original images from BonusAnimation.loadAssets()
-    final image = await decodeImageFromList(Uint8List.fromList(fakeImage));
-    final images = _MockImages();
-    when(() => images.fromCache(any())).thenReturn(image);
-    when(() => images.load(any())).thenAnswer((_) => Future.value(image));
-    Flame.images = images;
   });
 
   group('loads SpriteAnimationWidget correctly for', () {

test/game/view/widgets/game_hud_test.dart

@@ -1,11 +1,8 @@
 // ignore_for_file: prefer_const_constructors
 
 import 'dart:async';
-import 'dart:typed_data';
 
 import 'package:bloc_test/bloc_test.dart';
-import 'package:flame/assets.dart';
-import 'package:flame/flame.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:flutter_localizations/flutter_localizations.dart';
@@ -18,8 +15,6 @@ import 'package:pinball_ui/pinball_ui.dart';
 
 import '../../../helpers/helpers.dart';
 
-class _MockImages extends Mock implements Images {}
-
 class _MockGameBloc extends Mock implements GameBloc {}
 
 void main() {
@@ -34,15 +29,9 @@ void main() {
     );
 
     setUp(() async {
-      gameBloc = _MockGameBloc();
+      await mockFlameImages();
 
-      // TODO(arturplaczek): need to find for a better solution for loading
+      gameBloc = _MockGameBloc();
-      // image or use original images from BonusAnimation.loadAssets()
-      final image = await decodeImageFromList(Uint8List.fromList(fakeImage));
-      final images = _MockImages();
-      when(() => images.fromCache(any())).thenReturn(image);
-      when(() => images.load(any())).thenAnswer((_) => Future.value(image));
-      Flame.images = images;
 
       whenListen(
         gameBloc,

test/game/view/widgets/play_button_overlay_test.dart

@@ -1,10 +1,8 @@
 import 'package:bloc_test/bloc_test.dart';
-import 'package:flame/flame.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:mocktail/mocktail.dart';
 import 'package:pinball/game/game.dart';
 import 'package:pinball/select_character/select_character.dart';
-import 'package:pinball_theme/pinball_theme.dart';
 
 import '../../../helpers/helpers.dart';
 
@@ -21,14 +19,12 @@ void main() {
     late CharacterThemeCubit characterThemeCubit;
 
     setUp(() async {
-      Flame.images.prefix = '';
+      await mockFlameImages();
-      await Flame.images.load(const DashTheme().animation.keyName);
+
-      await Flame.images.load(const AndroidTheme().animation.keyName);
-      await Flame.images.load(const DinoTheme().animation.keyName);
-      await Flame.images.load(const SparkyTheme().animation.keyName);
       game = _MockPinballGame();
       gameFlowController = _MockGameFlowController();
       characterThemeCubit = _MockCharacterThemeCubit();
+
       whenListen(
         characterThemeCubit,
         const Stream<CharacterThemeState>.empty(),

test/helpers/fakes.dart

@@ -5,70 +5,3 @@ import 'package:pinball/game/game.dart';
 class FakeContact extends Fake implements Contact {}
 
 class FakeGameEvent extends Fake implements GameEvent {}
-
-const fakeImage = <int>[
-  0x89,
-  0x50,
-  0x4E,
-  0x47,
-  0x0D,
-  0x0A,
-  0x1A,
-  0x0A,
-  0x00,
-  0x00,
-  0x00,
-  0x0D,
-  0x49,
-  0x48,
-  0x44,
-  0x52,
-  0x00,
-  0x00,
-  0x00,
-  0x01,
-  0x00,
-  0x00,
-  0x00,
-  0x01,
-  0x08,
-  0x06,
-  0x00,
-  0x00,
-  0x00,
-  0x1F,
-  0x15,
-  0xC4,
-  0x89,
-  0x00,
-  0x00,
-  0x00,
-  0x0A,
-  0x49,
-  0x44,
-  0x41,
-  0x54,
-  0x78,
-  0x9C,
-  0x63,
-  0x00,
-  0x01,
-  0x00,
-  0x00,
-  0x05,
-  0x00,
-  0x01,
-  0x0D,
-  0x0A,
-  0x2D,
-  0xB4,
-  0x00,
-  0x00,
-  0x00,
-  0x00,
-  0x49,
-  0x45,
-  0x4E,
-  0x44,
-  0xAE,
-];

test/helpers/helpers.dart

@@ -2,6 +2,7 @@ export 'builders.dart';
 export 'fakes.dart';
 export 'forge2d.dart';
 export 'key_testers.dart';
+export 'mock_flame_images.dart';
 export 'pump_app.dart';
 export 'test_games.dart';
 export 'text_span.dart';

test/helpers/mock_flame_images.dart

@@ -0,0 +1,92 @@
+import 'dart:typed_data';
+
+import 'package:flame/assets.dart';
+import 'package:flame/flame.dart';
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:mocktail/mocktail.dart';
+
+class _MockImages extends Mock implements Images {}
+
+/// {@template mock_flame_images}
+/// Mock for flame images instance.
+///
+/// Using real images blocks the tests, for this reason we need fake image
+/// everywhere we use [Images.fromCache] or [Images.load].
+/// {@endtemplate}
+// TODO(arturplaczek): need to find for a better solution for loading image
+// or use original images.
+Future<void> mockFlameImages() async {
+  final image = await decodeImageFromList(Uint8List.fromList(_fakeImage));
+  final images = _MockImages();
+  when(() => images.fromCache(any())).thenReturn(image);
+  when(() => images.load(any())).thenAnswer((_) => Future.value(image));
+  Flame.images = images;
+}
+
+const _fakeImage = <int>[
+  0x89,
+  0x50,
+  0x4E,
+  0x47,
+  0x0D,
+  0x0A,
+  0x1A,
+  0x0A,
+  0x00,
+  0x00,
+  0x00,
+  0x0D,
+  0x49,
+  0x48,
+  0x44,
+  0x52,
+  0x00,
+  0x00,
+  0x00,
+  0x01,
+  0x00,
+  0x00,
+  0x00,
+  0x01,
+  0x08,
+  0x06,
+  0x00,
+  0x00,
+  0x00,
+  0x1F,
+  0x15,
+  0xC4,
+  0x89,
+  0x00,
+  0x00,
+  0x00,
+  0x0A,
+  0x49,
+  0x44,
+  0x41,
+  0x54,
+  0x78,
+  0x9C,
+  0x63,
+  0x00,
+  0x01,
+  0x00,
+  0x00,
+  0x05,
+  0x00,
+  0x01,
+  0x0D,
+  0x0A,
+  0x2D,
+  0xB4,
+  0x00,
+  0x00,
+  0x00,
+  0x00,
+  0x49,
+  0x45,
+  0x4E,
+  0x44,
+  0xAE,
+];

test/select_character/view/character_selection_page_test.dart

@@ -1,5 +1,4 @@
 import 'package:bloc_test/bloc_test.dart';
-import 'package:flame/flame.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:mocktail/mocktail.dart';
@@ -17,11 +16,8 @@ void main() {
   late CharacterThemeCubit characterThemeCubit;
 
   setUp(() async {
-    Flame.images.prefix = '';
+    await mockFlameImages();
-    await Flame.images.load(const DashTheme().animation.keyName);
+
-    await Flame.images.load(const AndroidTheme().animation.keyName);
-    await Flame.images.load(const DinoTheme().animation.keyName);
-    await Flame.images.load(const SparkyTheme().animation.keyName);
     characterThemeCubit = _MockCharacterThemeCubit();
     whenListen(
       characterThemeCubit,