feat: pr suggestions

pull/24/head
Erick Zanardo 4 years ago
parent 2fe97b0dd5
commit 03769460e1

@ -7,7 +7,7 @@ part 'game_state.dart';
class GameBloc extends Bloc<GameEvent, GameState> { class GameBloc extends Bloc<GameEvent, GameState> {
GameBloc({ GameBloc({
int bonusLettersCount = 6, int bonusLettersCount = 'GOOGLE'.length,
}) : _bonusLettersCount = bonusLettersCount, }) : _bonusLettersCount = bonusLettersCount,
super(const GameState.initial()) { super(const GameState.initial()) {
on<BallLost>(_onBallLost); on<BallLost>(_onBallLost);
@ -38,7 +38,7 @@ class GameBloc extends Bloc<GameEvent, GameState> {
activatedBonusLetters: [], activatedBonusLetters: [],
bonusHistory: [ bonusHistory: [
...state.bonusHistory, ...state.bonusHistory,
GameBonus.letterSequence, GameBonus.word,
], ],
), ),
); );

@ -3,8 +3,8 @@ part of 'game_bloc.dart';
/// Defines bonuses that a player can gain during a PinballGame. /// Defines bonuses that a player can gain during a PinballGame.
enum GameBonus { enum GameBonus {
/// Bonus achieved when the user activate all of the bonus /// Bonus achieved when the user activate all of the bonus
/// letters on the board /// letters on the board, forming the bonus word
letterSequence, word,
} }
/// {@template game_state} /// {@template game_state}

@ -154,7 +154,7 @@ void main() {
score: 0, score: 0,
balls: 3, balls: 3,
activatedBonusLetters: [], activatedBonusLetters: [],
bonusHistory: [GameBonus.letterSequence], bonusHistory: [GameBonus.word],
), ),
], ],
); );

@ -175,7 +175,7 @@ void main() {
score: gameState.score + 1, score: gameState.score + 1,
balls: gameState.balls + 1, balls: gameState.balls + 1,
activatedBonusLetters: const [0], activatedBonusLetters: const [0],
bonusHistory: const [GameBonus.letterSequence], bonusHistory: const [GameBonus.word],
); );
expect(gameState, isNot(equals(otherGameState))); expect(gameState, isNot(equals(otherGameState)));

Loading…
Cancel
Save