242 Commits (f1bc6f1226fa396c00def380c9b6e968a3d42b42)

Author	SHA1	Message	Date
Simon Marquis	daa2228132	Restore original `type` labels	1 year ago
Simon Marquis	0377fd8712	Replace `NewsResourceType` enum with simpler String type ... See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901	1 year ago
Adetunji Dahunsi	153b34fd50	Merge pull request #850 from qamarelsafadi/loading-progress-for-image ... Fix #849: Loading progress for image	1 year ago
Don Turner	492697ce6b	Merge pull request #873 from SimonMarquis/misc-warnings ... Fix miscellaneous warnings	1 year ago
Qamar A. Safadi	2db3e0c804	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Don Turner	8901e5932a	Merge pull request #872 from SimonMarquis/data-objects ... Convert 'sealed' sub-object to 'data object'	1 year ago
Don Turner	0e13207a40	Merge pull request #874 from SimonMarquis/string-decoder ... Replace StringDecoder injection with simpler API	1 year ago
Qamar A. Safadi	5abc69fb49	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Simon Marquis	0418997f5a	Extract `UTF-8` character encoding	1 year ago
Don Turner	4d0efef3b4	Merge pull request #879 from tatsuyafujisaki/rename-constants ... Rename constants	1 year ago
Qamar A. Safadi	8aa0457ca9	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Adetunji Dahunsi	0a20cb729b	Merge pull request #877 from android/tj/scrollbars ... Update feedItemsSize calculation	1 year ago
Tatsuya Fujisaki	4eeb045287	Rename constants	1 year ago
Adetunji Dahunsi	ec53d03854	Merge pull request #722 from android/tj/scrollbars ... Add scrollbars to app	1 year ago
dahunsi	03610d229a	Update feedItemsSize calculation ... Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452	1 year ago
Simon Marquis	e8449112b4	Replace StringDecoder injection with simpler API ... The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String. For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`). Unit tests would fail because Uri is not mocked (since we are not using Robolectric). Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc. FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded". The solution to this problem was to simply use regular Java APIs: - `URLDecoder.decode(urlEncodedTopicId, "UTF-8")` - `URLEncoder.encode(topicId, "UTF-8")`	1 year ago
Simon Marquis	4bdc9705af	Fix miscellaneous warnings ... - Remove unused namespace declaration - Collapse empty manifest tags - Remove redundant qualifier name - Remove redundant suppression	1 year ago
Simon Marquis	b7799f0475	Convert 'sealed' sub-object to 'data object'	1 year ago
Qamar A. Safadi	9f3103c212	Merge branch 'android:main' into loading-progress-for-image	1 year ago
Simon Marquis	995d7b643f	Add missing full stop in `search_not_ready` string	1 year ago
qamarelsafadi	f1a2993adc	feat: remove add placeholder todo	1 year ago
TJ Dahunsi	e13e84c155	Replace usages of 'displacement' to 'moved' in parameter names ... Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a	1 year ago
TJ Dahunsi	eeb4973265	PR feedback ... Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f	1 year ago
TJ Dahunsi	bdf3ee3cb0	PR feedback ... Change-Id: Ie22aa3c7fdf4c8ca8d8118837cfd279de8c6d80b	1 year ago
TJ Dahunsi	cb1d50e65e	Even better names ... Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65	1 year ago
TJ Dahunsi	3aec705048	Add padding to scrollbars	1 year ago
TJ Dahunsi	31b4841cb2	Add scrollbars to app	1 year ago
Milosz Moczkowski	9197b332c4	Merge pull request #825 from android/refactor/interest_item ... Refactor InterestsItem to a Material3 ListItem	1 year ago
Miłosz Moczkowski	445c18a803	Refactor InterestsItem to Material3 ListItem ... Change-Id: I12adc8820964aecd97ea0b4e22ae13e95e1428ab	2 years ago
Alex Vanyo	4d65946f95	Merge pull request #808 from SimonMarquis/compose-bom-2023-06-00 ... Upgrade Compose BoM `2023.06.00` and Compose compiler `1.4.7`	2 years ago
TJ Dahunsi	4af86580eb	Move analytics tracking of news deep link to an extension method ... Change-Id: Id3d1a30d86634b9176067696db5ecfd4d02854a5	2 years ago
Milosz Moczkowski	7203460051	Merge branch 'main' into compose-bom-2023-06-00	2 years ago
TJ Dahunsi	c4686cfa54	Track when deep link notifications are opened ... Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91	2 years ago
Don Turner	21777aba65	Merge pull request #799 from android/tm/feed-content-type ... Add contentType to news feed	2 years ago
Simon Marquis	40b5248302	Replace deprecated method `TextFieldDefaults.textFieldColors` ... ``` TextFieldColors' is deprecated. Renamed to `TextFieldDefaults.colors` with additional parameters to controlcontainer color based on state. ```	2 years ago
Alex Vanyo	9cd390c56a	Merge pull request #684 from MaximillianLeonov/feature-settings ... Replace `if` condition with AnimatedVisibility component	2 years ago
Tomáš Mlynarič	19ffb53150	Don't use lambda contentType for a single item ... Change-Id: I0588c031428d523707463c5f0f0b6c586ea5e2c3	2 years ago
Tomáš Mlynarič	4a8a43551a	Add contentType to news feed ... Before ScrollForYouFeedBenchmark_scrollFeedCompilationFull frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5 frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1 Traces: Iteration 0 1 2 3 4 5 6 7 8 9 After ScrollForYouFeedBenchmark_scrollFeedCompilationFull frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2 frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7 Traces: Iteration 0 1 2 3 4 5 6 7 8 9 Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef	2 years ago
Simon Marquis	cb84082ae7	Merge branch 'main' into patch/proguard	2 years ago
James Rose	7826b4f5f2	Merge pull request #748 from SimonMarquis/fix/permissions ... Grant `POST_NOTIFICATIONS` permission in more instrumented tests	2 years ago
Amaury Medeiros	512930c239	Fix inline comment as suggested in PR	2 years ago
Amaury Medeiros	87c27f6b82	Apply suggested changes to inline comment	2 years ago
Amaury Medeiros	dd70bbd589	Fix ForYouScreen Compose Previews ... Permissions should only be called in an Activity context, which is a layoutlib limitation. We need to avoid launching the permission request when in LocalInspectionMode, otherwise we'll have render errors on the ForYouScreen previews.	2 years ago
Maximillian Leonov	bea3661f81	Merge branch 'main' into feature-settings ... # Conflicts: # feature/settings/src/main/java/com/google/samples/apps/nowinandroid/feature/settings/SettingsDialog.kt	2 years ago
Maximillian Leonov	7dadf033c1	Add comment for ColumnScope usage	2 years ago
Miłosz Moczkowski	7b30720b25	Remove nested scaffold from the bookmarks screen ... Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950	2 years ago
Milosz Moczkowski	1345764649	Merge pull request #770 from android/refactor/remove_unused_statements ... Remove unused statements	2 years ago
Miłosz Moczkowski	83fa8c887f	Spotless apply ... Change-Id: I80457acc6a49fe9755240a3d52ff96a8fdfd6b92	2 years ago
Miłosz Moczkowski	99094199bc	Remove redundant suppressions ... Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef	2 years ago
Miłosz Moczkowski	5bf66739bd	Remove redundant statements ... Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89	2 years ago