f1bc6f1226
Restore `Unknown` type as empty `String`
2 years ago
c831dc673c
Fix broken text
2 years ago
daa2228132
Restore original `type` labels
2 years ago
480d8e7d7c
Fix missing removal
2 years ago
553b01fcb6
spotlessApply
2 years ago
0377fd8712
Replace `NewsResourceType` enum with simpler String type
...
See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901
2 years ago
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
2 years ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
2 years ago
246200f163
Merge pull request #754 from android/tm/metrics-one-folder
...
Compose compiler metrics saved into one folder
2 years ago
308f51f87d
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
2 years ago
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
2 years ago
5d7e33d905
fix formatting
2 years ago
e96e54f7de
Merge pull request #806 from SimonMarquis/objenesis
...
Remove forced resolution strategy
2 years ago
8901e5932a
Merge pull request #872 from SimonMarquis/data-objects
...
Convert 'sealed' sub-object to 'data object'
2 years ago
0e13207a40
Merge pull request #874 from SimonMarquis/string-decoder
...
Replace StringDecoder injection with simpler API
2 years ago
f203e9a218
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
2 years ago
5abc69fb49
Merge branch 'android:main' into loading-progress-for-image
2 years ago
0418997f5a
Extract `UTF-8` character encoding
2 years ago
e03294bad5
Merge pull request #871 from SimonMarquis/patch-1
...
Update README.md to mention `prodRelease` variant
2 years ago
4d0efef3b4
Merge pull request #879 from tatsuyafujisaki/rename-constants
...
Rename constants
2 years ago
f6d62f999c
2 years ago
d685f46309
Merge pull request #884 from alizera/fix_animation_label
...
fix: add label to animations for fixing lint issue
2 years ago
a23ffab602
fix: add label to animations for fixing lint issue
2 years ago
8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
2 years ago
0a20cb729b
Merge pull request #877 from android/tj/scrollbars
...
Update feedItemsSize calculation
2 years ago
4eeb045287
Rename constants
2 years ago
ec53d03854
Merge pull request #722 from android/tj/scrollbars
...
Add scrollbars to app
2 years ago
03610d229a
Update feedItemsSize calculation
...
Change-Id: I2bf6a2fa0e210cef1318707d948a49d2ef010452
2 years ago
e8449112b4
Replace StringDecoder injection with simpler API
...
The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String.
For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`).
Unit tests would fail because Uri is not mocked (since we are not using Robolectric).
Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc.
FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded".
The solution to this problem was to simply use regular Java APIs:
- `URLDecoder.decode(urlEncodedTopicId, "UTF-8")`
- `URLEncoder.encode(topicId, "UTF-8")`
2 years ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
2 years ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
2 years ago
72788223d2
Update README.md to mention `prodRelease` variant
...
and remove the "in open beta" now that it has been published.
2 years ago
5bbcc904e9
feat: make painter in one line
2 years ago
3595d8dcb5
feat: move the placeholder default value to the method
2 years ago
9f3103c212
Merge branch 'android:main' into loading-progress-for-image
2 years ago
a3ee09ec3e
Merge pull request #817 from android/av/enable-edge-to-edge
...
Switch to new Activity.enableEdgeToEdge
2 years ago
2693773fa2
Merge pull request #866 from nodmp/main-topic-typo
...
Typo fix for topics
2 years ago
04eb632081
Merge pull request #862 from SimonMarquis/patch-1
...
Remove hardcoded topic names in `NavigationTest.kt`
2 years ago
d8a6d0de13
Replace NiaNetworkDataSource with TopicsRepository
...
to be closer to the actual source of data used by the instrumented app.
2 years ago
57f3700980
Select last topic by name instead of a random one
2 years ago
8d3c2341ad
Merge pull request #864 from SimonMarquis/patch-2
...
Add missing full stop in `search_not_ready` string
2 years ago
c779b4e8ca
Typo fix for topics
...
tocpis -> topics
2 years ago
2b218b97d9
Switch to new Activity.enableEdgeToEdge
...
Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f
2 years ago
995d7b643f
Add missing full stop in `search_not_ready` string
2 years ago
0a1f333fc6
Update NavigationTest.kt
2 years ago
bf5fdb4cf8
Update NavigationTest.kt
2 years ago
250850cf9b
Remove hardcoded topic names in `NavigationTest.kt`
2 years ago
e276212574
feat: remove check if placeholder null and put a default placeholder if its not passed.
2 years ago
f1a2993adc
feat: remove add placeholder todo
2 years ago
427d65ecb2
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
2 years ago
Simon Marquis
Adetunji Dahunsi
Don Turner
qamarelsafadi
Qamar A. Safadi
Tatsuya Fujisaki
AlirezaJoon
dahunsi
Alex Vanyo
prosixe