Don Turner
e8e107c17b
Update screenshots
1 year ago
Don Turner
ef56e5a2f9
Merge pull request #1720 from android/revert-1344-main
...
Revert "Upgrade retrofit to 2.10.0"
1 year ago
Don Turner
b21835909c
Merge pull request #1722 from android/revert-1630-dependabot/gradle/protobuf-4.28.2
...
Revert "Bump protobuf from 4.26.1 to 4.28.2"
1 year ago
Ben Weiss
729681b79a
Revert "Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )"
...
This reverts commit 82b6352da1 .
1 year ago
dturner
802bc3e161
🤖 Updates screenshots
1 year ago
Don Turner
047b44dc68
Merge pull request #1721 from android/revert-1656-dependabot/gradle/firebaseCrashlyticsPlugin-3.0.2
...
Revert "Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2"
1 year ago
Don Turner
9ee490322f
Revert "Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2 ( #1656 )"
...
This reverts commit d10c8c0c25 .
1 year ago
Don Turner
c1dfad169e
Revert "Upgrade retrofit to 2.10.0 ( #1344 )"
...
This reverts commit 9f11fe6337 .
1 year ago
Jaehwa Noh
dfc3355054
Empty search text is added in recent searches problem fix. ( #1223 )
...
* Add if state to prevent blank query.
* Create test emptySearchText_NotAddToRecentSearches
- For empty query not add in recent query list.
* Apply early return.
* assertEquals to assertNull.
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Import org.junit.Assert.assertNull
* Change org.junit.Assert.assertNull to kotlin.test.assertNull.
Change-Id: I60083b0b9a1dcaed84d957b49c91e5163d5659d6
* Add 'or' to prevent search when query is blank.
Change-Id: If498de05889d6d5946b1bbb1d1c10cb311bb9b52
* Create stateIsEmptyQuery_withThreeWhiteSpacesSearchQuery test.
Change-Id: I6d6e8f9fe988ca83fae484e4f2338ad6fe58b676
* Add UI logic to prevent blank text search in SearchScreen.
- Early return to do not call onSearchExplicitlyTriggered()
Change-Id: I28db284eac9059fb6f48dd718721a1fc5fdb8f7a
* Apply trim at query to remove whitespace.
Change-Id: Id349af4bb1af3d0f1c3973e6fb9e6f3e7b924d9b
* Create test stateIsEmptyQuery_withThreeWhiteSpacesAndOneLetterSearchQuery
Change-Id: Iee59f6085e4045b2e3c532f78804926290b6c6c5
* Update feature/search/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Change name to emptySearchText_isNotAddedTorecentSearches()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeSpaces_isEmptyQuery()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()
Change-Id: I4c82b12e2c9bd4ff480e94061caf257a603e38da
* Revert "Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()"
This reverts commit e4c176598a .
* Change name to searchTextWithThreeSpacesAndOneLetter_isEmptyQuery
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Add end curly bracket.
Change-Id: I7bd113e7b65d646f5321e34a7df2868f6e239cad
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
1 year ago
dependabot[bot]
274c38c154
Bump madrapps/jacoco-report from 1.7.0 to 1.7.1 ( #1627 )
...
Bumps [madrapps/jacoco-report](https://github.com/madrapps/jacoco-report ) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/madrapps/jacoco-report/releases )
- [Commits](https://github.com/madrapps/jacoco-report/compare/v1.7.0...v1.7.1 )
---
updated-dependencies:
- dependency-name: madrapps/jacoco-report
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 year ago
dependabot[bot]
82b6352da1
Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )
...
* Bump protobuf from 4.26.1 to 4.28.2
Bumps `protobuf` from 4.26.1 to 4.28.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 4.26.1 to 4.28.2
Updates `com.google.protobuf:protoc` from 4.26.1 to 4.28.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/commits )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
* 🤖 Updates screenshots
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>
1 year ago
dependabot[bot]
56c284a303
Bump com.google.accompanist:accompanist-permissions from 0.34.0 to 0.36.0 ( #1658 )
...
* Bump com.google.accompanist:accompanist-permissions
Bumps [com.google.accompanist:accompanist-permissions](https://github.com/google/accompanist ) from 0.34.0 to 0.36.0.
- [Release notes](https://github.com/google/accompanist/releases )
- [Commits](https://github.com/google/accompanist/compare/v0.34.0...v0.36.0 )
---
updated-dependencies:
- dependency-name: com.google.accompanist:accompanist-permissions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
1 year ago
dependabot[bot]
bee6f6bb87
Bump androidxMacroBenchmark from 1.3.0 to 1.3.1 ( #1652 )
...
Bumps `androidxMacroBenchmark` from 1.3.0 to 1.3.1.
Updates `androidx.benchmark:benchmark-macro-junit4` from 1.3.0 to 1.3.1
Updates `androidx.baselineprofile` from 1.3.0 to 1.3.1
---
updated-dependencies:
- dependency-name: androidx.benchmark:benchmark-macro-junit4
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: androidx.baselineprofile
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 year ago
dependabot[bot]
eef7b9d6ae
Bump androidx.test:core from 1.5.0 to 1.6.1 ( #1654 )
...
Bumps androidx.test:core from 1.5.0 to 1.6.1.
---
updated-dependencies:
- dependency-name: androidx.test:core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 year ago
dependabot[bot]
3b84a5fcdb
Bump com.google.truth:truth from 1.4.2 to 1.4.4 ( #1655 )
...
Bumps [com.google.truth:truth](https://github.com/google/truth ) from 1.4.2 to 1.4.4.
- [Release notes](https://github.com/google/truth/releases )
- [Commits](https://github.com/google/truth/compare/v1.4.2...v1.4.4 )
---
updated-dependencies:
- dependency-name: com.google.truth:truth
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 year ago
dependabot[bot]
d10c8c0c25
Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2 ( #1656 )
...
Bumps `firebaseCrashlyticsPlugin` from 2.9.9 to 3.0.2.
Updates `com.google.firebase:firebase-crashlytics-gradle` from 2.9.9 to 3.0.2
Updates `com.google.firebase.crashlytics` from 2.9.9 to 3.0.2
---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-crashlytics-gradle
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: com.google.firebase.crashlytics
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 year ago
Ali Shariat
9f11fe6337
Upgrade retrofit to 2.10.0 ( #1344 )
...
* Upgrade retrofit to 2.10.0
* Update gradle/libs.versions.toml
---------
Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>
Co-authored-by: Zongle Wang <wangzongler@gmail.com>
1 year ago
Jaehwa Noh
1881730806
Bump spotless(6.23.3 to 6.25.0) and ktlint(1.0.1 to 1.4.0) ( #1318 )
...
* Bump up
- spotless.
- ktlint.
Change-Id: I4a0d1b4089dd4882df4653303a52f07f2bf6771f
* Update gradle/init.gradle.kts
* Disable all new features since ktlint 1.3.0.
https://github.com/pinterest/ktlint/releases/tag/1.3.0
Change-Id: I8f0ea640c06a2266cf0b7ede0da06bdd32651bbc
* Disabled `ktlint_standard_function-signature`.
Change-Id: Ib3e6e66d1774b39b5c92ec822308db107b070b82
---------
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
1 year ago
sanao
ab87857c9b
[Refactor]: Replace enableAndroidTest with androidTest.enable ( #1274 )
...
This is because enableAndroidTest is deprecated.
Fixes #1272
1 year ago
Zongle Wang
55dbe61c65
Optimize google maven downloading ( #1051 )
1 year ago
Don Turner
afb6741554
Merge pull request #1682 from blue928sky/use-lifecycle-compose-LocalLifecycleOwner
...
Use androidx.lifecycle.compose.LocalLifecycleOwner
1 year ago
Don Turner
284978fbcd
Merge pull request #1689 from Jaehwa-Noh/replace-test-to-version-catalog
...
Replace kotlin("test") to version catalog `kotlin.test`.
1 year ago
Don Turner
1c2fe163a0
Merge pull request #1706 from eltociear/patch-1
...
docs: update README.md
1 year ago
Ikko Eltociear Ashimine
643b62ed68
docs: update README.md
...
unecessary -> unnecessary
1 year ago
Yuri Schimke
717f2db3cd
Merge pull request #1699 from yschimke/latest_roborazzi
...
Update screenshot dependencies including robolectric, roborazzi
1 year ago
yschimke
2401e20dd4
🤖 Updates screenshots
1 year ago
Yuri Schimke
d7f1863920
remove sdk 21
1 year ago
Yuri Schimke
56fd308d65
revert screenshots
1 year ago
Yuri Schimke
0dd998765c
Update dependencies
...
Update Compose BOM to 2024.11.00 and update other dependencies, such as Robolectric and Roborazzi.
Also, update Screenshot Tests with sdk version 35 for better screenshot testing.
1 year ago
Alex Vanyo
d42262c939
Merge pull request #1690 from Jaehwa-Noh/remove-unused-import
...
Remove unused import
1 year ago
blue928sky
a929f9ccc0
Merge remote-tracking branch 'origin/main' into use-lifecycle-compose-LocalLifecycleOwner
...
Change-Id: I338708411967f018bc4a86b2cecebc1bcce71d32
1 year ago
Jaehwa Noh
72db5835ec
Remove unused import
1 year ago
Jaehwa Noh
1d659b0eea
Replace kotlin("test") to version catalog `kotlin.test`.
...
Change-Id: Ifd7de5dda724102063a9df660cacc6d6b16699e0
1 year ago
Don Turner
6bb75909fe
Merge pull request #1667 from SimonMarquis/patch-2
...
[Fix] Add missing unit test dependency for JVM modules
1 year ago
Don Turner
d4087b74a1
Merge pull request #1681 from android/dt/improve-navigation
...
Fix topic chip navigation from ForYou screen
1 year ago
Don Turner
18bb7a45a2
Fix spotless
1 year ago
Don Turner
717e0c7ad0
Add unit test for NetowrkTopic mapper
1 year ago
Don Turner
b478ceae54
Fix failing UI test, add unit test and refactor
1 year ago
blue928sky
bf54ccc760
feat: use androidx.lifecycle.compose.LocalLifecycleOwner
...
Change-Id: If0a414ee4d5aab277fb90343ba7d5aa6a9dbd2e8
1 year ago
Don Turner
ec0868cc02
Merge pull request #1671 from SimonMarquis/patch-3
...
Check Java version compatibility
1 year ago
Don Turner
68af0e713c
Merge pull request #1679 from SimonMarquis/patch-5
...
Delete unused and duplicated dependency
1 year ago
Don Turner
38a27cf7c8
Merge pull request #1678 from SimonMarquis/patch-4
...
Delete unused color
1 year ago
Don Turner
fbf0558465
Fix navigation test for ForYou to TopicScreen
1 year ago
dturner
2eee83eeda
🤖 Updates screenshots
1 year ago
dturner
a134126d8a
🤖 Updates baselines for Dependency Guard
1 year ago
Don Turner
d5d270bc5d
Update Espresso and a few other libs to fix NoClassDefFoundError when running UI test
1 year ago
Don Turner
ecfb5157dd
Improve test data and add UI test for topic chip
1 year ago
Don Turner
89795c98b5
Fix spotless
1 year ago
Don Turner
ef132e07e3
Fix the top app bar logic for top level destinations
1 year ago
Don Turner
5994d8c6fd
Add TopicScreen as a sub destination in the ForYou section. Fixes #1463
1 year ago