707117a4f2
Merge branch 'main' into kotlinify
2 years ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
9d41ffa318
Merge branch 'main' into kotlinify
2 years ago
b6d82e24df
Merge branch 'main' into kotlinify
2 years ago
f8f932705a
Remove violations: discouraged-comment-location
2 years ago
fb5bd225be
Spotless
2 years ago
3142ecb495
Remove redundant mutable state
2 years ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
77451779cd
Use animateItemPlacement() on feed
...
Change-Id: Id120a6e84e0641679fa54ebf0e34bb04165aa419
2 years ago
03d2455f41
Use lazy vertical staggered grid in feed to maximize space utilization
...
Change-Id: I66fff57bd0f11f5f73e7e5c9b5c51b0fa6a76926
2 years ago
b2cd980170
Merge remote-tracking branch 'origin/main' into resource-prefix
2 years ago
ebfe01affd
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
2 years ago
a33dafccad
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
6c0d6ad82e
Fixes icons size in onboarding and restores LocalInspection for images ( #909 )
...
* Fixes icons size in onboarding and restores LocalInspection for images
2 years ago
0ced769999
Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values
2 years ago
4a5ec5bd82
Update `var` with fake default value to the more "correct" `lateinit var`
2 years ago
f1bc6f1226
Restore `Unknown` type as empty `String`
2 years ago
c831dc673c
Fix broken text
2 years ago
daa2228132
Restore original `type` labels
2 years ago
480d8e7d7c
Fix missing removal
2 years ago
0377fd8712
Replace `NewsResourceType` enum with simpler String type
...
See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901
2 years ago
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
2 years ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
2 years ago
308f51f87d
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
2 years ago
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
2 years ago
5d7e33d905
fix formatting
2 years ago
f203e9a218
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
2 years ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
3 years ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
3 years ago
5bbcc904e9
feat: make painter in one line
3 years ago
9f3103c212
Merge branch 'android:main' into loading-progress-for-image
3 years ago
c779b4e8ca
Typo fix for topics
...
tocpis -> topics
3 years ago
57025e7587
fix: review notes
3 years ago
8a197800c5
feat: fix format issue
3 years ago
7a05f7db96
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
3 years ago
3284eb68a3
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
3 years ago
42b16bf7be
Merge remote-tracking branch 'origin/main'
3 years ago
ee8b70003d
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
3 years ago
3114b2eeaa
Allow localised date format
3 years ago
8e1e994bb1
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
3 years ago
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
3 years ago
479a2f00b0
Refactor icons
3 years ago
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
3 years ago
f6bdba08d9
added comment to document what happens on tapping news resource card.
3 years ago
bbc80bb0e2
added back launchCustomChromeTab()
3 years ago
51379a249d
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
...
1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
3 years ago
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
3 years ago
050db2cb72
Merge branch 'main' into jr/track-viewed
3 years ago
feafb5fbed
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
...
Provide true to LocalInspectionMode
3 years ago
2b2f6d48ce
Merge pull request #600 from takagimeow/cleanup-unused-args
...
Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
3 years ago
Don Turner
Simon Marquis
lihenggui
Ben Trengrove
dahunsi
Simon Marquis
Jose Alcérreca
Adetunji Dahunsi
qamarelsafadi
Qamar A. Safadi
prosixe
ahmedmadhoun1
Tomáš Mlynarič
Miłosz Moczkowski
gururani-abhishek
Takeshi Hagikura
James Rose