d8b735f80e
Revert "Improve accessibility to ForYou topics ( #1309 )" ( #1732 )
...
This reverts commit 48544194f4
2 weeks ago
b9105c61f7
Replace github action `always` into `!cancelled`. ( #1440 )
...
* Replace method always into cancelled.
Change-Id: I6518ce38a6640d42b9089e264c529ddaf75766b8
* Remove redundant if state.
2 weeks ago
013424896c
Merge pull request #1050 from android/bw/threadPolicy
...
Enable the thread police 👮 for debug builds
2 weeks ago
48544194f4
Improve accessibility to ForYou topics ( #1309 )
...
* Clear semantics.
Change-Id: I69a48798f6be8433e877c38166bd73cd776d71ac
* Merge the descendants semantics.
Change-Id: Ifbe91bb694b393e6780f93732a7d38f5ee355680
* Add string for icon description.
Change-Id: Ibf35c651aeacfbe317794ed898f0fb0e8bc1ec15
* Change icon description.
Change-Id: I9359bf8c9272b247669ae58fd79e5f79466ec0a9
* Change state of icon check logic.
Change-Id: I3e5e89fc1c469c3f3c4744d18f697f68d070996b
* Merge only text.
Change-Id: I36eefc6dd9f56f7a1f63003f0f95f6755ae16def
* Add stateDescription.
Change-Id: Id4d32e49374dbdb6e666048937e37060cbd4b454
* Add toggleableState.
Change-Id: I9f836e2463bf800786d11f9e0997a7d570ff90b0
* Set clearAndSetSemantics at Row.
Change-Id: Ic25b9ca11bbcc40c8ff24172669b07ea9b7642a9
* Set stateDescription "Following" and "Not Following".
Change-Id: Ib82ac94b05a5d373ac10787aac5241fb4f03c7b2
* Find topic by onNodeWithContentDescription.
Change-Id: I2423e3846c02169f6bf1fc30d9b4034b5f79efb3
* Find topic by onNodeWithContentDescription.
Change-Id: Iefc97fd9e52227f51f7d40f8c10cb4878cde90c0
2 weeks ago
90b992b950
Improve `README.md` Noticeability ( #1405 )
...
* Highlight Note.
Change-Id: I79b564cf56428dd278d257da2c75f57312067148
* Highlight Note.
Change-Id: I9ec8e49a3fcd88de9de1838b3003ed81150d4cf6
* Change style.
* Add newline.
Change-Id: I8d443f63ba91082fcd6754a9b1f4a657091a1a11
* Add newline and emphasis.
Change-Id: I7fd4d80fde91ede9c4a784c04ebb895fa43bf015
2 weeks ago
6bf2d04d59
Merge pull request #1708 from yschimke/introduce_screenshot_a11y_tests
...
Introduce screenshot accessibility tests
2 weeks ago
27a05c416e
Extract strict mode policy into function
...
Change-Id: If170b2b05859ebfca7bc91ccc790be5b43a1b772
2 weeks ago
225f05e697
Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/NiaApplication.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 weeks ago
a258794dc6
Merge branch 'main' into introduce_screenshot_a11y_tests
2 weeks ago
e36b7ab454
Merge pull request #1711 from AdnanHabibMirza/adnan/typesafe_project_accessor
...
Use typesafe project accessor
2 weeks ago
78b1a6748a
Merge pull request #1707 from yongsuk44/feature/type-safe
...
Refactor: Use type safe SearchRoute
2 weeks ago
462440e990
Merge pull request #1695 from gibachan/remove-redundant-annotations
...
Remove redundant annotations
2 weeks ago
55b67c345f
Merge pull request #1731 from android/dt/update-screenshots-2
...
Update screenshots (again)
2 weeks ago
d9b35f6ecb
Update screenshots (again)
2 weeks ago
104edcbe5e
Merge pull request #1723 from android/dt/update-screenshots
...
Update screenshots
2 weeks ago
3a3643e258
Merge pull request #1725 from android/dt/add-api34emu
...
Add API 34 emulator
2 weeks ago
cb811ecf6d
Merge pull request #1728 from android/trambui/navigation-null-debug
...
incorporate safe fallback destination to fix null destination causing UI flickering
2 weeks ago
e8035622b3
Enable the thread police 👮 for debug builds
...
* App will now crash if someone does funky stuff on the main thread.
Change-Id: I9026c100705f2fec6963a1d888b40906186f9d28
2 weeks ago
81e7ef0a05
Replace Annotation to compiler args. ( #1602 )
...
Change-Id: I691fc0f14d4bb2c62224dc77a5d0f3a08b59a75b
2 weeks ago
0e52982866
Merge branch 'main' into trambui/navigation-null-debug
2 weeks ago
827d3d66e2
incorporate safe fallback destination to null destination UI flickering
2 weeks ago
4a0723441f
Dependency version upgrades, not API 35 yet ( #1719 )
...
* Update screenshots
Change-Id: Ibed7889a3389ab6044e00a185158f36ce857b6b2
* Dependency version upgrades
Change-Id: Ib4a1f9bef1dd3e1736907479125d0abb5b22e9bd
* Address review comments
Change-Id: Ia2c6a52e289285a7a78336fa4250fa6a04ccb5c4
* 🤖 Updates baselines for Dependency Guard
* 🤖 Updates screenshots
2 weeks ago
ba05404017
Issue #1272 rewrote it.enableAndroidTest to it.androidTest.enable ( #1456 )
2 weeks ago
e6ec99e793
Add clear instruction at CI screenshot tests error output ( #1423 )
...
* Add clear instruction
- Your fork's CI will take screenshots for your fork.
Change-Id: I7ea1a437be4f9723fcf71d4d18932f8f44f46fa8
* Remove screenshots to see CI instruction.
Change-Id: Ib12f0ee4ff4faff8287f9ddfd5e533868abca4f8
* Revert "Remove screenshots to see CI instruction."
This reverts commit 36de3be9ba
2 weeks ago
37fea198e4
Add instruction in ```generateModuleGraphs.sh``` documentation. ( #1361 )
...
* Add Others OS instruction in documentation.
Change-Id: I96be572051558d89e004187534da96a7b01a78ea
* Change apt-get to apt according to [documentation](https://graphviz.org/download/ )
Change-Id: I0c00ce50d6bce83de79b5612021822691090cb6f
2 weeks ago
cc50941173
Add API 34 emulator
2 weeks ago
d183cbd412
Merge pull request #1724 from android/dt/remove-api30emu
...
Removing API 30 emulator while investigating flakiness
2 weeks ago
8267b619d6
Removing API 30 emulator while investigating flakiness
2 weeks ago
e8e107c17b
Update screenshots
2 weeks ago
ef56e5a2f9
Merge pull request #1720 from android/revert-1344-main
...
Revert "Upgrade retrofit to 2.10.0"
2 weeks ago
b21835909c
Merge pull request #1722 from android/revert-1630-dependabot/gradle/protobuf-4.28.2
...
Revert "Bump protobuf from 4.26.1 to 4.28.2"
2 weeks ago
729681b79a
Revert "Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )"
...
This reverts commit 82b6352da1
2 weeks ago
802bc3e161
🤖 Updates screenshots
2 weeks ago
047b44dc68
Merge pull request #1721 from android/revert-1656-dependabot/gradle/firebaseCrashlyticsPlugin-3.0.2
...
Revert "Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2"
2 weeks ago
9ee490322f
Revert "Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2 ( #1656 )"
...
This reverts commit d10c8c0c25
2 weeks ago
c1dfad169e
Revert "Upgrade retrofit to 2.10.0 ( #1344 )"
...
This reverts commit 9f11fe6337
2 weeks ago
dfc3355054
Empty search text is added in recent searches problem fix. ( #1223 )
...
* Add if state to prevent blank query.
* Create test emptySearchText_NotAddToRecentSearches
- For empty query not add in recent query list.
* Apply early return.
* assertEquals to assertNull.
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Import org.junit.Assert.assertNull
* Change org.junit.Assert.assertNull to kotlin.test.assertNull.
Change-Id: I60083b0b9a1dcaed84d957b49c91e5163d5659d6
* Add 'or' to prevent search when query is blank.
Change-Id: If498de05889d6d5946b1bbb1d1c10cb311bb9b52
* Create stateIsEmptyQuery_withThreeWhiteSpacesSearchQuery test.
Change-Id: I6d6e8f9fe988ca83fae484e4f2338ad6fe58b676
* Add UI logic to prevent blank text search in SearchScreen.
- Early return to do not call onSearchExplicitlyTriggered()
Change-Id: I28db284eac9059fb6f48dd718721a1fc5fdb8f7a
* Apply trim at query to remove whitespace.
Change-Id: Id349af4bb1af3d0f1c3973e6fb9e6f3e7b924d9b
* Create test stateIsEmptyQuery_withThreeWhiteSpacesAndOneLetterSearchQuery
Change-Id: Iee59f6085e4045b2e3c532f78804926290b6c6c5
* Update feature/search/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/search/SearchViewModelTest.kt
Change name to emptySearchText_isNotAddedTorecentSearches()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeSpaces_isEmptyQuery()
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
* Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()
Change-Id: I4c82b12e2c9bd4ff480e94061caf257a603e38da
* Revert "Change name to searchTextWithThreeWhiteSpacesAndOneCharacter_isEmptyQuery()"
This reverts commit e4c176598a
2 weeks ago
274c38c154
Bump madrapps/jacoco-report from 1.7.0 to 1.7.1 ( #1627 )
...
Bumps [madrapps/jacoco-report](https://github.com/madrapps/jacoco-report ) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/madrapps/jacoco-report/releases )
- [Commits](https://github.com/madrapps/jacoco-report/compare/v1.7.0...v1.7.1 )
---
updated-dependencies:
- dependency-name: madrapps/jacoco-report
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 weeks ago
82b6352da1
Bump protobuf from 4.26.1 to 4.28.2 ( #1630 )
...
* Bump protobuf from 4.26.1 to 4.28.2
Bumps `protobuf` from 4.26.1 to 4.28.2.
Updates `com.google.protobuf:protobuf-kotlin-lite` from 4.26.1 to 4.28.2
Updates `com.google.protobuf:protoc` from 4.26.1 to 4.28.2
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
- [Commits](https://github.com/protocolbuffers/protobuf/commits )
---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-kotlin-lite
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
* 🤖 Updates screenshots
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>
2 weeks ago
56c284a303
Bump com.google.accompanist:accompanist-permissions from 0.34.0 to 0.36.0 ( #1658 )
...
* Bump com.google.accompanist:accompanist-permissions
Bumps [com.google.accompanist:accompanist-permissions](https://github.com/google/accompanist ) from 0.34.0 to 0.36.0.
- [Release notes](https://github.com/google/accompanist/releases )
- [Commits](https://github.com/google/accompanist/compare/v0.34.0...v0.36.0 )
---
updated-dependencies:
- dependency-name: com.google.accompanist:accompanist-permissions
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* 🤖 Updates baselines for Dependency Guard
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
2 weeks ago
bee6f6bb87
Bump androidxMacroBenchmark from 1.3.0 to 1.3.1 ( #1652 )
...
Bumps `androidxMacroBenchmark` from 1.3.0 to 1.3.1.
Updates `androidx.benchmark:benchmark-macro-junit4` from 1.3.0 to 1.3.1
Updates `androidx.baselineprofile` from 1.3.0 to 1.3.1
---
updated-dependencies:
- dependency-name: androidx.benchmark:benchmark-macro-junit4
dependency-type: direct:production
update-type: version-update:semver-patch
- dependency-name: androidx.baselineprofile
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 weeks ago
eef7b9d6ae
Bump androidx.test:core from 1.5.0 to 1.6.1 ( #1654 )
...
Bumps androidx.test:core from 1.5.0 to 1.6.1.
---
updated-dependencies:
- dependency-name: androidx.test:core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 weeks ago
3b84a5fcdb
Bump com.google.truth:truth from 1.4.2 to 1.4.4 ( #1655 )
...
Bumps [com.google.truth:truth](https://github.com/google/truth ) from 1.4.2 to 1.4.4.
- [Release notes](https://github.com/google/truth/releases )
- [Commits](https://github.com/google/truth/compare/v1.4.2...v1.4.4 )
---
updated-dependencies:
- dependency-name: com.google.truth:truth
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 weeks ago
d10c8c0c25
Bump firebaseCrashlyticsPlugin from 2.9.9 to 3.0.2 ( #1656 )
...
Bumps `firebaseCrashlyticsPlugin` from 2.9.9 to 3.0.2.
Updates `com.google.firebase:firebase-crashlytics-gradle` from 2.9.9 to 3.0.2
Updates `com.google.firebase.crashlytics` from 2.9.9 to 3.0.2
---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-crashlytics-gradle
dependency-type: direct:production
update-type: version-update:semver-major
- dependency-name: com.google.firebase.crashlytics
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 weeks ago
9f11fe6337
Upgrade retrofit to 2.10.0 ( #1344 )
...
* Upgrade retrofit to 2.10.0
* Update gradle/libs.versions.toml
---------
Co-authored-by: Ben Weiss <keyboardsurfer@users.noreply.github.com>
Co-authored-by: Zongle Wang <wangzongler@gmail.com>
2 weeks ago
1881730806
Bump spotless(6.23.3 to 6.25.0) and ktlint(1.0.1 to 1.4.0) ( #1318 )
...
* Bump up
- spotless.
- ktlint.
Change-Id: I4a0d1b4089dd4882df4653303a52f07f2bf6771f
* Update gradle/init.gradle.kts
* Disable all new features since ktlint 1.3.0.
https://github.com/pinterest/ktlint/releases/tag/1.3.0
Change-Id: I8f0ea640c06a2266cf0b7ede0da06bdd32651bbc
* Disabled `ktlint_standard_function-signature`.
Change-Id: Ib3e6e66d1774b39b5c92ec822308db107b070b82
---------
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
2 weeks ago
ab87857c9b
[Refactor]: Replace enableAndroidTest with androidTest.enable ( #1274 )
...
This is because enableAndroidTest is deprecated.
Fixes #1272
2 weeks ago
55dbe61c65
Optimize google maven downloading ( #1051 )
2 weeks ago
afb6741554
Merge pull request #1682 from blue928sky/use-lifecycle-compose-LocalLifecycleOwner
...
Use androidx.lifecycle.compose.LocalLifecycleOwner
4 weeks ago
284978fbcd
Merge pull request #1689 from Jaehwa-Noh/replace-test-to-version-catalog
...
Replace kotlin("test") to version catalog `kotlin.test`.
4 weeks ago
Ben Weiss
Jaehwa Noh
Don Turner
Ben Weiss
Don Turner
Tram Bui
Tram Bui
Rudr Pratap Singh
dependabot[bot]
Ali Shariat
sanao
Zongle Wang