4843216871
Merge branch 'main' into kotlinify
2 years ago
81b15d046e
Merge branch 'main' into issue-945
2 years ago
6cd965d70c
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
2 years ago
1d92f90ab0
Merge pull request #956 from KDW03/add_saved_test
...
Add Test for Saved Top Level Destination
2 years ago
137944ab9a
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
2 years ago
e4991aff96
Merge branch 'main' into kotlinify
2 years ago
8d29d9bf57
Merge pull request #1094 from lihenggui/main
...
Upgrade Spotless and Ktlint and remove code convention violations
2 years ago
00823a51ac
Merge pull request #1103 from android/add_icon_comment
...
Add comment explaining why the launcher icon colors differ per build
2 years ago
2e663d3572
Merge branch 'main' into kotlinify
2 years ago
5a49b51008
Moving comments to _after_ first XML element
...
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
2 years ago
b3d68b92d3
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
2 years ago
c8163a7328
Fix spotless
...
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
2 years ago
76e3c1d97c
Revert "Move app screenshot tests to match dependencies declaration"
2 years ago
235585c8c4
Add comment explaining why the launcher icon colors differ per build variant
...
Change-Id: I30126402370162ccbe53e177652583e4472f2030
2 years ago
14c90400be
Move app screenshot tests to match dependencies declaration
...
Fixes #990
2 years ago
5aa9122f08
Remove violations: property-naming
2 years ago
5e965962c5
Spotless
2 years ago
6a3a5ea692
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
2 years ago
8d0b893459
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
2 years ago
ad98844d64
Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold"
...
This reverts commit 335a7ec68caa8ce0e1f6
2 years ago
ed702d195a
🤖 Updates screenshots
2 years ago
e03e5561ef
Replace manual navigation component switching with new NavigationSuiteScaffold
...
Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723
2 years ago
4faf8f0d8d
[CI] Better caching and fewer jobs run
...
* [CI] Runs build in macos to generate a cache for androidTest runs
* Build projects before running emulator
* Fixes flaky coroutines test
* Moves spotless up in local tests job
* Enables config cache by setting problems to warn. Fixes #1022
2 years ago
0081d14105
remove ACCESS_ADSERVICES permissions
2 years ago
ecb7528a2c
Inline color values for app icons
2 years ago
1e0e1140ff
Removed Comments
2 years ago
cd87a5ad70
Use colors from design palette in build variant icons
2 years ago
8c7055f8ce
Create different icons for each build variant
...
Added color values for DEBUG and BENCHMARK build variants.
2 years ago
85b7549b44
NiaAppScreenSizesScreenshotTests.kt: Fixes screenshot test showing wrong width ( #986 )
...
* FIxes screenshot test
* 🤖 Updates screenshots
2 years ago
5009105592
🤖 Updates screenshots
2 years ago
79bb3b9edf
Merge remote-tracking branch 'origin/main' into resource-prefix
2 years ago
5df3f0b665
Merge remote-tracking branch 'origin/main' into issue-945
2 years ago
ed9299de65
Add Test for Saved Top Level Destination
2 years ago
415e35c35e
Enforce `resourcePrefix` on Android library modules
...
```
:ui-test-hilt-manifest -> ui_test_hilt_manifest_
:core:analytics -> core_analytics_
:core:common -> core_common_
:core:data -> core_data_
:core:data-test -> core_data_test_
:core:database -> core_database_
:core:datastore -> core_datastore_
:core:datastore-test -> core_datastore_test_
:core:designsystem -> core_designsystem_
:core:domain -> core_domain_
:core:network -> core_network_
:core:notifications -> core_notifications_
:core:testing -> core_testing_
:core:ui -> core_ui_
:feature:bookmarks -> feature_bookmarks_
:feature:foryou -> feature_foryou_
:feature:interests -> feature_interests_
:feature:search -> feature_search_
:feature:settings -> feature_settings_
:feature:topic -> feature_topic_
:sync:sync-test -> sync_test_
:sync:work -> sync_work_
```
2 years ago
2bbb982b3a
Migrate from `java` to `kotlin` sourceSet directory
2 years ago
23f14116f6
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
...
- Prevent logging multiple times (because of `onResume()` callback)
- Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot.
- Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type.
- Add proper javadoc format with markdown specific blocks.
- Update logs & tag to be more uniform.
Closes #945
2 years ago
ff9f38198f
Adds screenshot tests to :core:designsystem ( #931 )
...
* WIP: Adds screenshot tests to :core:designsystem
Change-Id: I0672845feba4064652dd8d60f07047b87864e121
* 🤖 Updates screenshots
* Creates tests for more components and cleans up
Change-Id: I61fe3ae6a4e8a41a599d520e16fc14aa6a643a22
* WIP: More cleanup and more combinations of themes
Change-Id: I34312bc7d147b31f1c638cd505a9c241f8267523
* Added the rest of the screenshot tests for designsystem
Change-Id: Ic427db5491910781c038882055524e3f3dbed194
* Some more cleanup
Change-Id: I7384e55864719af9122ad9da8e50a09cb9a60180
* Spotless
Change-Id: I22aa46e1f56b8b638c9d609ababbe49d471a26c6
* 🤖 Updates screenshots
* ScreenshotHelper cleanup
Change-Id: Ic94d41618e7850ab47f294d8022b405f18c843f0
2 years ago
d32d871f4b
Merge pull request #868 from SimonMarquis/patch-4
...
Handle topic clicks from all destinations
2 years ago
9748be62c5
Adds Screenshot testing with Roborazzi ( #876 )
...
* Adds screenshot tests using Roborazzi (Robolectric Native Graphics)
- Adds Roborazzi to convention plugins
- Adds Screenshot helper in :core-testing
- Creates screenshot suites for :app and :feature-foryou
* CI and spotless
* Moves :app tests to testDemo and makes NiaAppScreenSizesScreenshotTests prettier
* CI: Moves local tests to their own step
* CI: Adds --rerun to screenshot task
* CI: Moves screenshots before local tests
* CI: Fixes wrong if statement in workflow
* CI WIP: trying to trigger the push step
* CI: Re-enables roborazzi verification
* Fixes flaky screenshot tests by setting LocalInspectionMode on
* CI: screenshot commits now use the original author intead of bot account
* CI: Disables globbing because file_pattern didn't work
* CI: Trying new file pattern for png files
* CI: Adds a check for forks
* 🤖 Updates screenshots
* Code review: toml cleanup, comments
* Use new github.event.pull_request.head.repo.fork
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
* Uses Robolectric qualifiers to set the dpi, adds section to README
* Spotless
* Delegates creation of repository to Hilt in test
* Revert "Use new github.event.pull_request.head.repo.fork"
* 🤖 Updates screenshots
* Empty commit to trigger GHA on main branch
* Makes time zones deterministic in screenshot tests
* Increases GMD timeout to 90m, but it has to be reduced
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
2 years ago
28c9412cc9
Convert 'sealed' sub-object to 'data object'
2 years ago
0a606296e1
Merge pull request #817 from android/av/enable-edge-to-edge
...
Switch to new Activity.enableEdgeToEdge
2 years ago
b0b13d07bc
Replace NiaNetworkDataSource with TopicsRepository
...
to be closer to the actual source of data used by the instrumented app.
2 years ago
812c558bc3
Select last topic by name instead of a random one
2 years ago
c7a5a5865b
Handle topic clicks from all destinations
...
Closes #865
2 years ago
65007350ab
Switch to new Activity.enableEdgeToEdge
...
Change-Id: I9bbb7b2d116099524525619714ef18448e707c4f
2 years ago
09441774f5
Update NavigationTest.kt
2 years ago
4f7874874d
Update NavigationTest.kt
2 years ago
86d3031d94
Remove hardcoded topic names in `NavigationTest.kt`
2 years ago
d5b6e4a71b
Fix Lint `RememberReturnType` issue with explicit type
2 years ago
d88e6f75d6
Merge pull request #809 from SimonMarquis/launcher-icon-dark-theme
...
Extract launcher icon tints and provide `-night` alternatives
2 years ago
f4a8056cde
changed from ListenableFuture.get() to ListenableFuture.await()
2 years ago
81dcbcf1e2
spotless fix
2 years ago
b83e941c73
Adds ProfileViewer to log the app's Baseline Profile Compilation Status
2 years ago
c327360aac
Extract launcher icon tints and provide `-night` alternatives
...
Implements #805
2 years ago
09a7b4bfda
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
2 years ago
f70a3d0ec6
Remove nested scaffold from the bookmarks screen
...
Change-Id: Ie8b6f160d341156a6f9c02c0ca7f530095fb2950
2 years ago
da09e124a7
Refactor icons
2 years ago
ba022c9e97
Refactor custom notificationDot modifier
...
Change-Id: Ife24492a495b111f111a8bd16f21b7ebd469e5aa
2 years ago
100cd47161
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
2 years ago
6fd1a429c1
Merge pull request #713 from android/jr/settings-dialog-state
...
Save the showSettingsDialog flag in instance state
2 years ago
5f5926dc73
Save the showSettingsDialog flag in instance state
...
This prevents the settings dialog from being dismissed when the device
is rotated.
2 years ago
7312b33e9e
Route notification deep link through for you screen
2 years ago
7d5d553923
Merge pull request #679 from SimonMarquis/patch-3
...
Simplify String resource loading in `NavigationTest.kt`
2 years ago
61db05b707
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
393d00c98b
Remove unused variables
2 years ago
55f62d8dad
Simplify String resource loading in NavigationTest.kt
2 years ago
08d87ecb1a
Rename getUserNewsResources to observeAll
2 years ago
317f47c3cf
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
3 years ago
b1286ca188
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
3 years ago
e5d7b6fa0c
Update to Compose Material 3 1.1.0-alpha06
...
Change-Id: I6399358ad85254243b5aff547e31e3abe92fb6ed
3 years ago
008494f796
Merge pull request #561 from SimonMarquis/update/androidx-lifecycle
...
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
3 years ago
769b5a5d12
Merge pull request #582 from yschimke/loaders
...
Improve network pooling and avoid startup image fetches.
3 years ago
bc5b7a90d3
Merge remote-tracking branch 'origin/main' into update/androidx-lifecycle
3 years ago
2e5c29c9e4
Improve network pooling and avoid startup image fetches.
...
Change-Id: If747fb0833d31ce7c9bedffd400160e979bc945e
3 years ago
09c70dafe1
Merge "Remove AD_ID permission" into main
3 years ago
a2987a128b
Remove AD_ID permission
...
Change-Id: Iaf691c8ff1e8fbbbcd39b068d8bfdc29c8f6a58c
3 years ago
3d6ca9b7d8
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
3 years ago
2f5de17634
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
3 years ago
6f8128070f
Merge "Add Firebase analytics. See go/nia-firebase-services." into main
3 years ago
a1bd4beadb
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
3 years ago
a9c8fca6f4
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
...
> `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map`
> Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`.
> The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424)
Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05
3 years ago
471a9d36ab
Fix settings dialog dismissed test on non-portrait phones
...
Change-Id: I15ed475915fdef198029db2713b6f619da374cc7
3 years ago
2728d899f0
Remove unused import
...
Change-Id: I426995db727995c7af6d34082593b078756a3f9d
3 years ago
6b122b1704
Use only width to determine navigation UI
...
Change-Id: Icad00b9a3eecac9762f6c6b7c3790e8cf1c161d6
3 years ago
56ecffbadd
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
3 years ago
463d7ac6e8
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
3 years ago
61c044a712
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
3 years ago
c97e7980c8
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
3 years ago
fcd54c1102
Coil refrence url fixed
3 years ago
448d6cd022
Revert "Add link of source code in app"
...
This reverts commit 197f4a5157
3 years ago
34dbf45384
Add link of source code in app
3 years ago
b6533606d5
Typo fix for compact
3 years ago
222da07c0d
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
3 years ago
d9e5948749
Rename to shouldShowGradientBackground
...
Change-Id: I79d4b43354f9da99d91fb21ee84fc084b374f4b8
3 years ago
8f89d3178a
Fix background composable
...
Change-Id: I548612191b0b99620777c3e2ad0ace56b228d27d
3 years ago
18d1259a79
Change variable name for 'not connected' message
3 years ago
31133a4c4e
Center title bar when nav rail is visible
...
Change-Id: I341833b71504462fdbfbe5073a2465be2af95fda
3 years ago
ae0996f707
Regenerate profile without people
...
Change-Id: Ia412617ac2e4212b7b9b3a3fa6f39541e53584c4
3 years ago
a09612ec80
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
3 years ago
d7f0e1e6e1
Merge pull request #468 from android/remove-stream-suffixes
...
Remove `Stream` suffixes
3 years ago
e7eca7a085
Update baseline profile
...
Change-Id: Ida83e612d5595ea1d43f9105ac7e76f7db2f6caa
3 years ago
8e5fc3e03e
Remove `Stream` suffixes
...
Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1
3 years ago
01d18396d9
Fix spotless
...
Change-Id: Ib46c68c765342d8c172cf2f224bb7f885803b483
3 years ago
9f85cc851a
Add accompanist/testharness
...
Adds a usage of accompanist/testharnness to force a given DpSize for its content, overriding the density if necessary to ensure that the size is achieved. This allows testing UI at arbitrary sizes on arbitrary emulators, lessening the need for using multiple emulators at different sizes (and filtering tests) when Android-specific window size has been hoisted appropriately.
The initial test using it is a test for checking whether or not the navigation bar or navigation rail is being shown, and these tests can run on any emulator.
Change-Id: I315384e5eafac23a3cd6d3818d9828f6d3c1acfc
3 years ago
7527146da1
Merge pull request #458 from android/tm/fix-benchmarks
...
Fix benchmarks
3 years ago
a8867de20e
Update BLP
3 years ago
c6e3551172
Make functions 'shouldUseDarkTheme' and 'shouldUseDarkTheme' private
3 years ago
0bbc4ba032
Merge pull request #420 from SimonMarquis/patch/kotlin-test
...
Migrate from JUnit assertions to Kotlin's test framework
3 years ago
b129e36202
Merge pull request #326 from MaximillianLeonov/redundant-label-on-activity
...
Remove redundant label on activity
3 years ago
6961fba0e2
Merge pull request #324 from MaximillianLeonov/unused-color-resources
...
Remove redundant unused color resources
3 years ago
a09ea875b8
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
3 years ago
7413e22377
Add data from the last 10 episodes
3 years ago
141a5dc2f3
Merge pull request #316 from android/bw/gradleCleanup
...
Update Baseline Profile generation
3 years ago
c859e42cfe
New baseline profile
...
Change-Id: I8a20ab2f44b198afaf57f26d1bee20054ed1ce6d
3 years ago
e24dcf40c6
Resolves #206 , enables predictive back navigation support
3 years ago
71fc07625c
Add workaround for top app bar overlapping nav rail
3 years ago
0d7bd9170d
Update app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
3 years ago
391bc1e900
Fix minor issues
3 years ago
8506958fb1
Resolve conflict with navigation changes from main
3 years ago
c3bcdd75e0
Address review feedback from Manu
3 years ago
bc17052c21
Fix getter for settings dialog state
3 years ago
91f77bf6ef
Remove Scaffold from top level screens
3 years ago
afa5c2eecd
Add comment about splashScreen.setKeepOnScreenCondition
3 years ago
eb721f8295
Add MainActivity view model
3 years ago
d6467ca16c
Fix spotless issues
3 years ago
6a4a01dcf5
Add tests
3 years ago
8cb5216d8e
Add settings module, refactor top bar
3 years ago
88e6581633
Fix typo
3 years ago
f1e15d6b83
Fix spotless issues
3 years ago
e596e76714
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
3 years ago
38670449ee
Updates Navigation approach with new guidance ( #347 )
3 years ago
b6204656b8
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
3 years ago
5315d2d957
Add more jank tracking
3 years ago
222f65e9e8
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
3 years ago
2230fb0259
Shorten navigation trace, fixes #271
...
Change-Id: I4b33800a538b13996fc68b48854be56251a9db2c
3 years ago
83cf30e792
Remove redundant label on activity
3 years ago
1fa840ac04
Remove redundant unused color resources
3 years ago
5d1fef2ac8
Apply spotless
...
Change-Id: I49eeb1984cb3e978a9cee5c1e4d53e856a10bb4e
3 years ago
0630159e2e
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
3 years ago
cdbcf54ba0
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
3 years ago
70ff3831a2
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
3 years ago
e54f3b1d17
Merge pull request #231 from android/jv/app-icon
...
Update app icon using Image Asset Studio
3 years ago
a958706946
Add round icon again for API 25.
3 years ago
f68af5d8c1
Add monochrome to v26 app icon, remove round icon (as per documentation: You may also define an icon drawable resource using the android:roundIcon attribute—but only if you require a different icon asset for circular masks, for example in a case where your branding relies on a circular shape.)
3 years ago
b2411367da
Fix dark mode system icons
...
Change-Id: I8af3435d2b83ebbd55b8adaa3f2066fbe2d22fa5
3 years ago
dbc74472e9
Add v33 launcher icon with support for adaptive icons
3 years ago
e23a8a8c6b
Update app icon using Image Asset Studio
...
Change-Id: I9eb8281abbb59da0b653dbe6c36786c90d330556
3 years ago
625a82f9d2
Merge pull request #217 from android/av/splash-screen
...
Removes non-Compose Material library and adds splash screen
3 years ago
58c22df2e3
Rename NightAdjusted.Splash to NightAdjusted.Theme.Splash
...
Change-Id: I2493c664945d3cfbe1c52397133fdc955265ac56
3 years ago
0c005f25fa
Merge pull request #219 from android/bw/metricsUpdate
...
Update JankStats to 1.0.0-alpha03
3 years ago
182482b64c
Update JankStats to 1.0.0-alpha03
...
Accomodating API changes along the way.
3 years ago
9e41a0ac82
Add splashscreen integration
...
Change-Id: I1fbc5b7e663497ae52759afb7bcd6169c5987ce6
3 years ago
d9c0b762ef
Remove non-Compose material
...
Change-Id: I62a639b6c12e7d523c3dc5ad0766f180120d9e92
3 years ago
715fc547b6
[NiA] Implement LazyVerticalGrid for Feed
...
Change-Id: I0fd51bdd4c64a3d9ceaba05244d384bb9b463315
3 years ago
6ef0355fc1
Merge remote-tracking branch 'github/main' into jul22automerger
...
Change-Id: Ic54190a9d825ae9649d34a4e2bd9c83855511b71
3 years ago
abe1507709
Add more KDocs and nav args encoding
3 years ago
13a5b8c5f9
Make the state holder stable
3 years ago
af7e2517f2
Add state holder for NiaApp composable
3 years ago
729dd4c3a2
Merge remote-tracking branch 'github/main'
...
* github/main: (21 commits)
Add stacktrace for test command
Add TODO comment with bug
Update Compose compiler to 1.2.0, Kotlin to 1.7.0
Consistent tags & named parameter usage
Address review comments
Remove redundant dependency
Fix spotless
Move JankStats metric gathering further down
Add ForYou TopicSelection scrolling state
Add ForYou feed scrolling state
Add JankMetricDisposableEffect
Add AuthorsCarousel scrolling state
Add JankMetricEffect
Remove InterestItem state
Use DisposableEffect + rememberMetricsStateHolder for Interests tab selection
Use rememberMetricsStateHolder for navigation
Add rememberMetricsStateHolder composable
Introduce view extension to track jank
Inject JankStats with Hilt
Add jankStats and rudamentary jank logging
...
Change-Id: I1ff0fb3ccb7d6082c17c6e69f5d9ea9cabe1d733
3 years ago
b769f07f22
[NiA] Add Saved functionality
...
Change-Id: I38320a16999d063a023bbe9d329a275af4e78b1e
3 years ago
c1603ccebc
Merge branch 'main' into bw/initialMetrics
3 years ago
567c993073
Address review comments
...
* Introduce gradle plugin for firebase perf
* Create TrackScrollJank composable to mask tracking code
3 years ago
f62ee8ae25
Merge branch 'main' into bw/initialMetrics
3 years ago
13a5ff8c4c
Update baseline profile
...
Contains CUJs:
- scrolling for you feed
- scrolling interests topics
- scrolling interests people
Change-Id: Iad124aafae9858b2922dcfa49302fe1f8aacae48
3 years ago
47a9034088
Add testTag to access composables from UiAutomator
...
Change-Id: I5125cae0778151b11868b72f74f74f979774625c
3 years ago
dbb75969a8
Merge pull request #68 from RivanParmar/main
...
Fix Navigation Bar in landscape mode.
3 years ago
1f984bef26
Improve design system usage and add lint checks
...
Change-Id: I05f9400a9410e31bdf1534e458d560fe793b809f
3 years ago
ecb41fbb96
Fix SpotlessApply.
3 years ago
efc60bf2cc
Merge branch 'main' into bw/initialMetrics
3 years ago
fbbc08cc73
Merge branch 'android:main' into main
3 years ago
e6b301a89b
Move JankStats metric gathering further down
...
This isn't the thing a developer should be focusing on when first
opening the file. So moving it further down in the composable.
3 years ago
f627eea6a7
Update baseline profile and generation logic ( #61 )
3 years ago
f9610786bc
Merge branch 'bw/initialMetrics' of github.com:android/nowinandroid into bw/initialMetrics
3 years ago
6e3192a72a
Fix Navigation Bar in landscape mode.
3 years ago
cd84100864
Fix Navigation Bar in landscape mode.
3 years ago
0d85dcefd2
Merge pull request #56 from sud007/fix/nia-naming-convention
...
Fix Bug #41 | Nia Naming conventions
3 years ago
9dd50480f4
Add JankMetricDisposableEffect
...
Change-Id: Idcab0faa2e9b4cc9986064f45217cab101843697
3 years ago
4db051b4a8
Use rememberMetricsStateHolder for navigation
...
Change-Id: I3b038a9bbc6eed9b21343aa0fd75c044049386a4
3 years ago
4282bf37f3
Merge branch 'github/main'
3 years ago
c07dba5e63
Fix Bug #41
...
Fix bug #41 Made Naming Convention symmetrical. as 'Nia' instead of 'NiA' as that sounds more subtle and easy to follow in camel-case notation based Naming
3 years ago
ba65429d1c
Remove ClearRippleTheme CompositionLocal from NavigationBar
...
Fixes #36
3 years ago
e5378b8edd
Introduce view extension to track jank
3 years ago
c6646b357f
Inject JankStats with Hilt
3 years ago
3bdb7a4c9f
Add jankStats and rudamentary jank logging
3 years ago
1676032cd1
Add tracing library and start using it
...
Currently tracing sync and main navigation.
3 years ago
f5e1efc191
Merge branch 'github/main'
3 years ago
90e8dfe80d
Merge pull request #44 from serbelga/fix_themed_app_icon_round
...
Fix themed app icon launcher roundIcon
3 years ago
4be907d0a0
Add cutout version of ic_launcher_foreground for drawable-v24 in app module in order to distinguish it from the nia-app-catalog version
3 years ago
6f48d52ad7
Add monochrome attribute to ic_launcher_round.xml in :app and :app-nia-catalog
3 years ago
7511941f56
Fix nested navigation graphs
...
Change-Id: I2c3ad0a0f6c132230b821d3621389913cf37247c
3 years ago
e9b47ee1fb
Update benchmarking & baseline profiles
...
Uses newest versions from I/O release
Also updates baseline profile to match latest changes
Change-Id: I83c709338ea37d2187d1e8437f5b5d8e98a42f22
3 years ago
5ca7b6c607
Refactor navigation
...
Change-Id: I3501446e73976f3872592038501fcef8c8324f74
3 years ago
6cfc521cad
Update baseline profile
...
Change-Id: I6b69df704e14ba9568494d773690a1121226273e
3 years ago
383b6d29d8
Add AuthorScreen and corresponding components
...
Change-Id: Iee5e8bd0932d1b68770aaa1e23fa660451109601
3 years ago
bea5ee7194
Rename following to interests
...
Change-Id: Iabcb8b495717e0cb3a993ecc0e09e3338fe5140f
3 years ago
ad57a93b64
Add gradient background to For You Screen
...
Change-Id: I6a85ee82a78b1897020f1737503611bd100764a1
3 years ago
7c52414724
Add multi-column support for cards on the for you feed
...
Fixes: 228074722
Change-Id: Id077b4dd93452b5f9399f94161c9b66594436975
3 years ago
403afba03f
Configure spotless for kts and xml files
...
Fixes: 230874524
Change-Id: I147b9f16d5424b3459435e3c5422867b40c480b7
3 years ago
47107e86be
Fix large screen insets handling
...
Bug: 228374243
Change-Id: I2a7af72e60450be3280872b46bd84eb1079b533d
3 years ago
68d146a7c7
Converted model ids from ints to strings
...
Change-Id: Iad07926e04113bcd2c6d9e06e5e2a4e802a79b80
3 years ago
Don Turner
Simon Marquis
Don Turner
lihenggui
Miłosz Moczkowski
mmoczkowski
Jose Alcérreca
rosariopf
TM
tunjid
Simon Marquis
kimdowoo
Alex Vanyo
Murat Yener
James Rose
TJ Dahunsi
Takeshi Hagikura
Caren
Yuri Schimke
Márton Braun
Angie Sasmita
mlykotom
Harshit Pandey
Muhammad Anas Shamsi
Jolanda Verhoef
Masood Fallahpoor
Ben Weiss
Ben Weiss
Yura Laguta
Manuel Vivo
Wojtek Kaliciński
Maximillian Leonov
Nick Rout
Rivan
Rivan Parmar
kbuilder
Sudhanshu
Sergio Belda
Simona Stojanovic