f3bf40afee
Fix #1595 navigation to topic detail screen causes crash
...
Change-Id: Ib5e764d47cbb810df5af12c2345f4f85baeac6b2
1 year ago
694960c08b
Merge branch 'main' into dt/nav-safe-args
1 year ago
291f02adb8
Merge pull request #1559 from android/av/dcowi-update
...
Update DeviceConfigurationOverride.WindowInsets to match upstream implementation
1 year ago
7586fff495
Fix spotless
...
Change-Id: Ib093c206809a470b7f6135933bd2a72046865684
1 year ago
908d07d809
Clean up deep link handling
...
Change-Id: I9d589cfe5c20a6b55708b99f5d79b10271af8ab4
1 year ago
c7fcd06a44
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
1 year ago
9bcaaec846
Tidy up top level destination handling
...
Change-Id: I385b6f49ba37801e40bb90254abe96e2350d48e8
1 year ago
738a698910
Fix minor issues
1 year ago
802fba6981
Update DeviceConfigurationOverride.WindowInsets to match upstream impl
...
Change-Id: Ibce5b499fc67305e12bb3862fc6aefc3647adb75
1 year ago
f282ccd891
Remove `TemporaryFolder` JUnit rule in instrumented test
1 year ago
85491e0f53
Remove implicit `TemporaryFolder` binding with InMemoryDataStore test module
1 year ago
0ed1d62c10
Merge pull request #1539 from android/dt/remove-ad-property
...
Remove Firebase AD_SERVICE_CONFIG property
1 year ago
9f2324d9f4
Instrumented tests for InterestsListDetailScreen ( #1518 )
...
* Instrumented tests for InterestsListDetailScreen
Change-Id: I0325cea93bf1e1dc0b8d1fc56434d5413caf6fea
* Use BackHandler instead of asserting an Espresso exception
Change-Id: I6246fcdd51d09a609733fd83223f6d7b8c0cb6c1
* Workaround to make adaptive info use size override
currentWindowAdaptiveInfo() is not affected by using the ForcedSize
override, so the list detail scaffold directve will be calculated with
non-overridden values. This work around hoists the WindowAdaptiveInfo
so that we can pass in an appropriate value in tests.
Change-Id: Ieef99f6d710ddb70243ac5105aa7805dd638ccf8
* Spotless fixes
Change-Id: I7d8a0b3e2667ced3d73fc4f028d11823cda15455
* Review fixes
Change-Id: Iffd288c9a927f13069580c66a6ee3150abb63682
* Helper function to get topics
Change-Id: If336c4b9dac82382daf96284533a277cc58984fa
1 year ago
4589506b7a
Remove Firebase AD_SERVICE_CONFIG property
...
Change-Id: I084f98af8f7eb739be1053428593a2b880ae33f9
1 year ago
c04ffa8673
Apply suggestions from code review
1 year ago
43cbbd3143
Update app/src/main/AndroidManifest.xml
1 year ago
1b364543c6
Merge branch 'main' into rpf-update-firebase-ktx
1 year ago
dfdf5589c4
Add DeviceConfigurationOverride for insets to allow screenshot testing insets
...
Change-Id: Idc781bf23021c1dba0d992bda0a3233e38e7c436
1 year ago
c777e49e30
Merge branch 'main' into dt/nav-safe-args
...
* main:
Kotlin 2.0.0 (#1036 )
Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
🤖 Updates screenshots
🤖 Updates baselines for Dependency Guard
Update material3-adaptive to beta01
🤖 Updates baselines for Dependency Guard
Bump androidxComposeAlpha from 1.7.0-alpha08 to 1.7.0-beta01
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.51 to 2.51.1
Add NavigationSuiteScaffold
Fix state loss with workaround
Change-Id: I14d7294fe93f68b9aca6df9bf7bf87ff95583581
1 year ago
2f6f3b4342
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
1 year ago
ee66ead1a9
Merge pull request #1419 from android/av/fix-state-loss-with-workaround
...
Fix state loss with workaround
1 year ago
70404bf24c
Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
1 year ago
2a00e7248d
🤖 Updates screenshots
1 year ago
64c4a25eb3
Fix tests, fix spotless
...
Change-Id: I55e779abe4ee49dc93916d9e1184ed81e1b2bbd0
1 year ago
cc50d7420a
Remove different deeplink destination, add route for nested nav host
...
Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad
1 year ago
299a352aa4
Update to adaptive alpha12, fix merge issues
...
Change-Id: I99703db37712abb46b844beb73bb14ddd5283165
1 year ago
226e893aff
Merge branch 'main' into dt/nav-safe-args (AnimatedPane broken)
...
* main:
Save nested nav key in instance state
🤖 Updates baselines for Dependency Guard
Recreate nested nav to work with AnimatedPane
Remove forgotten Trace.endSection()
Offload connectivity monitor to a background thread
Change-Id: I4002a07484a4d633c57406aedabf9f5d813a8592
1 year ago
ae5f002a1c
Add specific type for deeplinks
...
Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75
1 year ago
a41edeac21
Remove autoVerify from intent filter
...
Change-Id: Ia7460a618b2ddf8a25debce92308573bc18368a8
1 year ago
1a45eabcb1
Update ForYou destination to match current deeplink pattern
...
Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638
1 year ago
ef235cae1f
Fix issue where selected topic in list was not showing as selected. Minor tidy ups.
...
Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d
1 year ago
f03c06163e
Add NavigationSuiteScaffold
...
Change-Id: I36710d880bff381ed86c61632f2ab91902727775
1 year ago
c046c0cf5c
Fix state loss with workaround
...
Change-Id: I96025bd8b2f4f59019df95d1391b832249e7dc91
1 year ago
80676d55ff
Save nested nav key in instance state
...
Change-Id: If1155bfbe080eb4df3c59faaec0fb4cd4da3821d
1 year ago
d146e0128a
Recreate nested nav to work with AnimatedPane
...
Change-Id: I6b526331b7fc62b968ac39e91753a8a1e5343023
1 year ago
578c7f58a7
Use navigation argument topicId as default value to InterestListDetailScreen
...
Change-Id: I659f729191bce00683b1621c360c8f36f00595f9
1 year ago
6a4dd757e9
Change startDestination from KClass to default instance
...
Change-Id: Ia5bb0abd366653aff5cf5a772ac11a837e96b9b1
1 year ago
2cc0dab95f
🤖 Updates screenshots
1 year ago
c4aa2024f0
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
1 year ago
727015573d
Merge branch 'main' into dt/nav-safe-args
1 year ago
4cee9776cb
Add deeplink action to enable testing from terminal
...
Change-Id: Ia112f87c7f1bb7fa9ebe08b82d26e00b4ad17d05
1 year ago
a78e127c1d
Remove Interests2PaneViewModel as it was overkill for holding a single string value
...
Change-Id: I4767578028b55c2bc7b1763bdeef87345b9fbf06
1 year ago
2b40962f3d
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
1 year ago
977151ae19
Update to alpha08, use toRoute to obtain destination inside VM
...
Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a
1 year ago
9260ad6c84
Migrate Interests nested NavHost to safe args
...
Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74
1 year ago
c7a1486457
Merge pull request #1383 from android/av/navigation-2.7.7
...
Update to navigation 2.7.7
1 year ago
c5d0f25360
Add workaround for state loss bug
...
Change-Id: I7ac4495c8e3ada419358688c61214c33c0d4040e
1 year ago
be2dd57af2
Fixes flakiness in app's screenshot tests ( #1395 )
...
* Disables WM init in app's screenshot tests
Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed
* Spotless
Change-Id: Ic0212889354481433ce45ec4292ae7be9bd24b2e
* [CI] Uploads roborazzi reports if they fail
Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417
* Uses unused test module and enables LocalInspection
Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b
* Fixes timezone in snackbar screenshot tests
Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31
* Fixes conflict
Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c
* 🤖 Updates screenshots
1 year ago
815c471d24
Revert "Configure baseline profiles in the baselineProfile lambda" ( #1398 )
...
This reverts commit 7980c1d0df
1 year ago
32bdaad690
Configure baseline profiles in the baselineProfile lambda ( #1060 )
...
* Configure baseline profiles in the baselineProfile lambda
* This is the correct and easiest way to set up baseline profiles correctly.
* See b/313428246 for more context.
* Handle empty topics during baseline profile generation
* Revert to API 33 GMD and fail empty screen tests
* Rename withChildren to noChildren for better legibility
* Remove unused log tags
* Update benchmark and metrics versions
* 🤖 Updates baselines for Dependency Guard
---------
Co-authored-by: Tomáš Mlynarič <mlykotom@google.com>
Co-authored-by: Jaehwa Noh <shwoghk14@gmail.com>
1 year ago
83676800f0
Replace TestHarness with DeviceConfigurationOverride after merging main
...
Change-Id: Ie49b67981929fd3932ce3da68571a6305cf67aef
1 year ago
74fead944a
Merge branch 'main' into replace-testharness
1 year ago
45768621f5
Update to material3-adaptive alpha10
...
Change-Id: I810c36323a35c445c22dd3876c52df0360a5cb48
1 year ago
f28c598f76
Update usage of material3 adaptive to be edge-to-edge
...
Change-Id: I481c79db77bbdd657182f5355200f63e2355f40d
1 year ago
bfcea73e3c
Adds screenshot tests for snackbar ( #1343 )
...
* Adds screenshot tests for snackbar
Change-Id: I81566e3301fb17e3f31cbc408e6cc3325eab5a12
* Small tweaks, RFR
Change-Id: Ia16db6e6f5bec2714081b5ceaeeba36b2ee26105
* 🤖 Updates screenshots
* Update NiaApp.kt
Adds modifier to NiaApp
1 year ago
5b5f04a075
Fix format
...
Change-Id: I54c9a794cbb84ffba4378ccc901ceb603de4642c
1 year ago
075382e3aa
Fix default value
...
Change-Id: I6b77e1c23ad91c1c97f31a705161d444be7913c0
1 year ago
fa68c59069
Optimized handling of dark/light mode
...
- Activity handles uiMode config change to prevent re-creating the whole activity
- Wrap uiState logic into its classes
- Optimize startup to prevent recomposing twice on startup
- Optimize startup to call enableEdgeToEdge only once or when change occurs
Change-Id: I6f7a48b3b6ce9b55db4ab2ec1770583028e9bc50
1 year ago
f6f5bf04f6
Add niaEdgeToEdge trace tag
...
Change-Id: I8012c8b4544abc9488f96f6f01822fb15bb0775a
1 year ago
01cf2cfcd2
Fix spotless
...
Change-Id: I98a9b9fa1de5cc0bb3a3caa7d795053fd784b238
1 year ago
369c271b50
Merge branch 'main' into replace-testharness
1 year ago
2bdcbeb95b
Remove workaround for https://issuetracker.google.com/327149166
...
Change-Id: I335f9f5da1ff3f2574acca8e3fcb27b949a07c7a
1 year ago
8e9b39fa31
Remove unnecessary opt-in annotations
2 years ago
bca4e40a28
Topic detail pane placeholder ( #1280 )
...
* Topic detail pane placeholder
Change-Id: I92b84493a5406240285c0759b30aa10d29871f09
* Add modifier parameter
Change-Id: Ie363be83b44f26291030c04c1513cecb851a6899
2 years ago
3e4d9c1c5e
Update material3-adaptive to 1.0.0-alpha08
...
Change-Id: Ic218c6b061b5cea4e56b544073541421862bc1d0
2 years ago
19efc6c3ad
Merge branch 'android:main' into rename-test-function
2 years ago
3b11bcf725
Remove explicit type argument.
...
Change-Id: Id02756d780309af6638698de856b563d9e775cc3
2 years ago
2eb0318513
Rename test function name
...
- Given-when-then format.
Change-Id: I3305c5a7cc5a0f41be31292534a086034f642404
2 years ago
c750a3c4c1
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
2 years ago
7196156718
Merge branch 'main' into replace-testharness
...
* main: (37 commits)
Disable animations of instrumented tests (#1167 )
Bump gradle/wrapper-validation-action from 1 to 2
Remove unused release variable. Fixes #1231
Apply Composable Parameter Ordering Guidelines
Remove kotlinx-coroutines-guava dependency from :sync:work
Add explicit guava-android dependency for :sync:work
Extract ScreenshotHelper to separate testing module
Update AGP to 8.3.0
Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
🤖 Updates baselines for Dependency Guard
Bump the kotlin-ksp-compose group with 6 updates
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.50 to 2.51
Bump com.google.truth:truth from 1.1.5 to 1.4.2
Move java to kotlin folder.
Remove disk usage testing
Figuring out what is using 66Gb in the runner
Dpm
Improve converting to kotlin timezone
Use trySend multiple times
...
Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
2 years ago
18376f5f3d
Update app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
2 years ago
e2809d7871
Merge branch 'android:main' into java-to-kotlin
2 years ago
8f89ca6cbb
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
2 years ago
5c3c9dcd14
Move java to kotlin folder.
...
Change-Id: Iaf4723dea6169fbf3f9a8d3bf8779179ac56ab86
2 years ago
890307b056
🤖 Updates screenshots
2 years ago
20d57b1105
Workaround for new ForcedSize behaviour, bump ui-test version
...
Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46
2 years ago
e2dd43f635
Bump to ui-test:1.7.0-alpha03, add parameter name
...
Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d
2 years ago
ec8786e168
🤖 Updates screenshots
2 years ago
137a8a78a6
Replace Accompanist TestHarness with DeviceConfigurationOverride
...
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
2 years ago
b3ff8aa940
🤖 Updates screenshots
2 years ago
5c83771326
🤖 Updates screenshots
2 years ago
793bb6568e
Wrap NiaApp with NiaTheme for app screenshot tests
...
Change-Id: I8e298da139b19721b90ae778e7ab184f600d0bd7
2 years ago
7737a83eb9
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
2 years ago
4a1015287d
🤖 Updates screenshots
2 years ago
74175c1d1c
Revert fast initialization of Coil
...
As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0
Change-Id: I9085309780508137f10b25ff82deed3c62e5d159
2 years ago
efc6775053
Add braces
...
Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0
2 years ago
b208b8bfcd
Inline initialization
...
Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48
2 years ago
d8c538e0ed
Don't use runBlocking if async init completed
...
Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da
2 years ago
be4dcedc63
Launch loader directly without additional coroutine scope
...
Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a
2 years ago
27dcfe26c9
Fix comment
...
Co-authored-by: Yuri Schimke <yuri@schimke.ee>
2 years ago
41b576d294
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
2 years ago
77d4f5f57f
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
2 years ago
8f5c475aab
Rename currentTimezone variable
...
Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d
2 years ago
e208bd0bfd
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
2 years ago
e19d435317
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
2 years ago
c432f74054
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
2 years ago
c83ea9d24e
Merge pull request #951 from SimonMarquis/issue-945
...
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
2 years ago
ecd7b035c7
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
2 years ago
4858b8355a
🤖 Updates screenshots
2 years ago
ae55eb8e1a
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
2 years ago
Don Turner
Don Turner
Enrico Mazzucchelli
Alex Vanyo
Simon Marquis
Jonathan Koren
alexvanyo
Jose Alcérreca
Ben Weiss
Tomáš Mlynarič
yongsuk44
Jaehwa Noh
SimonMarquis