qamarelsafadi
3284eb68a3
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
qamarelsafadi
42b16bf7be
Merge remote-tracking branch 'origin/main'
1 year ago
Qamar Safadi
ee8b70003d
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
1 year ago
ahmedmadhoun1
3114b2eeaa
Allow localised date format
2 years ago
Tomáš Mlynarič
8e1e994bb1
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
2 years ago
Tomáš Mlynarič
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
2 years ago
Miłosz Moczkowski
479a2f00b0
Refactor icons
2 years ago
Miłosz Moczkowski
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
2 years ago
gururani-abhishek
f6bdba08d9
added comment to document what happens on tapping news resource card.
2 years ago
gururani-abhishek
bbc80bb0e2
added back launchCustomChromeTab()
2 years ago
gururani-abhishek
51379a249d
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
...
1. removed the unused onItemClick parameter
2. removed now redundant variables it used
3. removed its description from the comments.
2 years ago
Takeshi Hagikura
b3cdc172cd
Implement search feature ( #685 )
...
Implement search feature
- Add a feature module named "search"
- Add a SearchScreen that is navigated by tapping the search icon at the top left corner
- Add a data layer that takes care of populating the *Fts tables and querying them by a search query
- Add a SearchViewModel that wires up the data layer of the Fts tables with the SearchScreen
The SearchScreen has following features:
- The user is able to type the search query in the TextField
- The search result is displayed as the user types
- When the search result is clicked, it navigates to:
- The InterestsScreen when a topic is clicked
- Chrome custom tab with the URL of the clicked news resource
- When the search result is clicked or the IME is explicitly closed by the user, the current search query in the TextField is saved as recent searches
- Latest recent searches are displayed in the SearchScreen
2 years ago
James Rose
050db2cb72
Merge branch 'main' into jr/track-viewed
2 years ago
Milosz Moczkowski
feafb5fbed
Merge pull request #575 from takagimeow/fix/provide-true-to-local-inspection-mode
...
Provide true to LocalInspectionMode
2 years ago
Milosz Moczkowski
2b2f6d48ce
Merge pull request #600 from takagimeow/cleanup-unused-args
...
Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
2 years ago
Milosz Moczkowski
ba6a697844
Merge pull request #624 from SimonMarquis/gradle-sort
...
Sort and group Gradle dependencies
2 years ago
Chris Sinco
93c01ad184
Fix trailing commas based on spotless check
2 years ago
Chris Sinco
049750dd51
Merge branch 'main' into ui-polish
2 years ago
James Rose
57c13d84bd
Incorporate code review changes: Move UserNewsResourceRepository to data
...
module; move UserNewsResource to model module. Implement unread dot for
bookmarked articles. Keep the flows cold in UserNewsResourceRepository.
2 years ago
Simon Marquis
8ec54d19d8
Sort and group Gradle dependencies thanks to square/gradle-dependencies-sorter
2 years ago
James Rose
ebfbb5bafd
Display unread state on the news feed and bottom nav bar
...
When a news resource is unread, display a dot on its card in the news
feed. When the For You section has unread resources, display a dot on
its icon in the navigation bar.
Update the read status when a resource is opened.
2 years ago
James Rose
9ee2acf327
Add viewed status for news resources to data layer
2 years ago
Keisuke Takagi
072364e7f1
remove newsResourceTitle
2 years ago
Keisuke Takagi
8b51107d7a
Merge branch 'main' of github.com:takagimeow/nowinandroid into fix/provide-true-to-local-inspection-mode
...
Conflicts:
core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt
2 years ago
Don Turner
4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
2 years ago
Márton Braun
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
2 years ago
Don Turner
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
2 years ago
Keisuke Takagi
9091abf09e
Provide true to LocalInspectionMode
2 years ago
Miłosz Moczkowski
bcb4d7d592
Replace global variables with PreviewParameterProvider
2 years ago
Márton Braun
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
2 years ago
Don Turner
bad3ea60f5
Refactor Topics news feed, tidy a few other bits up
...
Change-Id: Id4c9d1bce484137b363ec4cd21a45ca9863a2e7f
2 years ago
magicalmeghan
45e3cfd989
fixed string issue for testTopicsChipColorBackground_matchesFollowedState test
2 years ago
magicalmeghan
de6a4ec6c7
Merge remote-tracking branch 'github/mm/chipcolor' into mm/chipcolor
2 years ago
magicalmeghan
5137cd7777
removed hardcoded strings
2 years ago
Don Turner
cafac8eb09
fix spotless, tidy test data
...
Change-Id: I4ceb7b85e5a8dd4d4f20088b2594c6b4030299bb
2 years ago
magicalmeghan
66046a86b0
Updated NewsResourceCardTest
2 years ago
Don Turner
355b0540aa
Move construction of UserNewsResource into separate function
...
Change-Id: I7c1f6427cd7d95c2016349fec301b88455b33cf2
2 years ago
Don Turner
99227b06b5
Spotless
2 years ago
Don Turner
32bc5c1590
Fix merge conflicts
2 years ago
magicalmeghan
ffb5aeba86
Added third draft of tests
2 years ago
magicalmeghan
8089866079
Added second draft of tests
2 years ago
Chris Sinco
2f454de21c
Spacing polish based on design spec
2 years ago
Don Turner
47bc4a7b88
Merge pull request #504 from android/dt/fix-build-warnings
...
Fix build warnings
2 years ago
Don Turner
cf053ade5a
Fix build warnings
2 years ago
magicalmeghan
9a900f9900
Added first draft of tests
2 years ago
magicalmeghan
a8f55d9d38
Renamed SaveableNewsResource to UserNewsResource
2 years ago
Don Turner
5638e253ae
Fix unit and UI tests. Apply spotless.
...
Change-Id: Iab75852a27a44309d349f84e65226911ab59fcd5
2 years ago
magicalmeghan
ec4bceead3
Renamed SaveableNewsResource to UserNewsResource
2 years ago
magicalmeghan
6941e2082b
Renamed SaveableNewsResource to UserNewsResource
2 years ago
ratobing
1e493c0bbc
Set visibility modifier of composable preview to private
2 years ago
Nick Rout
7903f87dcc
Merge pull request #485 from ricknout/main
...
Update :core-designsystem module based on Figma file
2 years ago
Nick Rout
c12fe1fbe5
Update :core-designsystem module based on Figma file
2 years ago
Caren
65fdb0c09c
Merge pull request #476 from android/caren/resource_type
...
Display resource type for each news resource
2 years ago
Caren
4ff9c039b3
Rename NewsResourceDataAndType -> NewsResourceMetaData
...
Change-Id: Ide67bb9adf740d9cf0bba58f369688f91e0eb85f
2 years ago
Caren
b05302fddd
Fix tests
...
Change-Id: Ie1e2408ea523e6ddc0941fe261fce7f2502e3416
2 years ago
Caren
7d42831ee9
Merge pull request #465 from android/caren/custom_chrome_tab
...
Use Chrome Custom tab for opening articles
2 years ago
Caren
352bac94fb
run spotless
...
Change-Id: Ieb751d960ade646dfe35ed7d2ca039e3b8f38ba7
2 years ago
Caren
3712ba8c2f
Add test and add string template in strings.xml for RTL purposes
...
Change-Id: I1bce9ac7534f376a9626cac2c50e1bcc7620cf61
2 years ago
Caren
f563862df3
Rename NewsResourceDateAndNewsType -> NewsResourceDateAndType
...
Change-Id: I535c62f3317d6ada882a08235c0c4465d9963201
2 years ago
Caren
f150516b3c
Display resource type for each news resource
...
Change-Id: Ib33ffd0e9b87ec91d2ee4316a4e3dbf70bb5cfc9
2 years ago
Caren
1280565466
Add ColorInt annotation
...
Change-Id: If6ea8e4c3a09c6de932797ddcb64bbfff1e52ede
2 years ago
Jolanda Verhoef
4ba63c0de8
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
2 years ago
Caren
94e2bb0ec2
Run spotless
...
Change-Id: I1deee3c9b38d352afca0f646366598e32710ffca
2 years ago
Caren
45f8e069c5
Implement custom chrome tabs in NewsResourceCardList as well
...
Change-Id: Ie5851666117a7c756b3d9ad02d6e17be0d3ba904
2 years ago
Caren
55c3ebd085
Use Chrome Custom tab for opening articles
...
Change-Id: I0024038f918a18d3c3e803587a7e1c159bfb9169
2 years ago
Saeed Noshadi
adeb06c5ac
replace StringBuilder with joinToString
2 years ago
Saeed Noshadi
dcce95ada6
remove unused import
2 years ago
Saeed Noshadi
e44811f265
show all authors in the news card
2 years ago
Simon Marquis
a680b14763
Fix typos
2 years ago
Milosz Moczkowski
398c399c1c
Merge pull request #297 from android/av/remove-dolphin-preview-todos
...
Remove Preview TODOs for Dolphin
2 years ago
Automerger
9435c1cd79
Merge branch 'github/main'
2 years ago
Ben Weiss
7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
2 years ago
Ben Weiss
ee2e3db928
Add more jank tracking
2 years ago
Don Turner
7ca17f68ed
Merge branch 'main' into av/remove-dolphin-preview-todos
2 years ago
Don Turner
f3debd0af1
Merge "Add domain layer. See go/nia-domain-layer for details." into main
2 years ago
Don Turner
4a4de7d6a4
Add domain layer. See go/nia-domain-layer for details.
...
Change-Id: I3f4684005e81fb9c4163bf59c7026dcff6e88dc4
2 years ago
Wojtek Kaliciński
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
Don Turner
6351a89545
Merge pull request #310 from android/documentation/dep_graphs
...
Add dependency graphs to every module
2 years ago
Adetunji Dahunsi
c4debb74e7
Give feedback when syncing on ForYouScreen
...
Change-Id: I10a646e8a17f81d96351e69d36f0cb6ccf28e05c
2 years ago
Milosz Moczkowski
06e60063b5
Add dependency graphs to every module
...
Change-Id: I629fef818f7521c13bb3069a3ff9ed9bc42e57f3
2 years ago
Milosz Moczkowski
f914d6a412
Merge pull request #299 from android/refactor/remove_episodes
...
Remove episodes related code
2 years ago
Milosz Moczkowski
cbdf6a2d3c
Remove episodes related code
2 years ago
Automerger
6765d79065
Merge branch 'github/main'
2 years ago
Alex Vanyo
bfedf75665
Remove Preview TODOs for Dolphin
...
Change-Id: I35219c7dd6a902c43cd310dcaf8d0e2c2dbdec45
2 years ago
Takeshi Hagikura
9ae03c3590
Fix the lint warnings
2 years ago
Takeshi Hagikura
74737cad49
Introduce Multipreview annotation to simplify the preview configurations
...
- Bump the AGP version to 7.3.0
- Introduce Multipreview annotation class that represents device
previews and theme previews
Fixes #282
2 years ago
Wojtek Kaliciński
4683918cc7
Move spotless to init script
...
Also adds automatic git hooks installation
Change-Id: I18debbee43af27db7b95a4202f824fa87e186713
2 years ago
Wojtek Kaliciński
d0cff2b11c
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
2 years ago
madroid
3bd81154b5
Move 'core-' module to core subfolder
2 years ago