928833fe5d
Merge pull request #889 from RivanParmar/main
...
Rename SearchResult.kt.kt to SearchResult.kt
3 years ago
6c0d6ad82e
Fixes icons size in onboarding and restores LocalInspection for images ( #909 )
...
* Fixes icons size in onboarding and restores LocalInspection for images
3 years ago
0ced769999
Widen `isNotEmpty` with `isNotBlank` to potentially catch blank values
3 years ago
4a5ec5bd82
Update `var` with fake default value to the more "correct" `lateinit var`
3 years ago
f1bc6f1226
Restore `Unknown` type as empty `String`
3 years ago
c831dc673c
Fix broken text
3 years ago
daa2228132
Restore original `type` labels
3 years ago
480d8e7d7c
Fix missing removal
3 years ago
553b01fcb6
spotlessApply
3 years ago
0377fd8712
Replace `NewsResourceType` enum with simpler String type
...
See this discussion for rationale: https://github.com/android/nowinandroid/discussions/901
3 years ago
153b34fd50
Merge pull request #850 from qamarelsafadi/loading-progress-for-image
...
Fix #849 : Loading progress for image
3 years ago
9e1d46e28c
Rename SearchResult.kt.kt to SearchResult.kt
3 years ago
492697ce6b
Merge pull request #873 from SimonMarquis/misc-warnings
...
Fix miscellaneous warnings
3 years ago
308f51f87d
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
3 years ago
2db3e0c804
Merge branch 'android:main' into loading-progress-for-image
3 years ago
5d7e33d905
fix formatting
3 years ago
8901e5932a
Merge pull request #872 from SimonMarquis/data-objects
...
Convert 'sealed' sub-object to 'data object'
3 years ago
0e13207a40
Merge pull request #874 from SimonMarquis/string-decoder
...
Replace StringDecoder injection with simpler API
3 years ago
f203e9a218
feat: replacing SubcomposeAsyncImage as its not recommended to use with lazyLayout
3 years ago
5abc69fb49
Merge branch 'android:main' into loading-progress-for-image
3 years ago
4d0efef3b4
Merge pull request #879 from tatsuyafujisaki/rename-constants
...
Rename constants
3 years ago
a23ffab602
fix: add label to animations for fixing lint issue
3 years ago
8aa0457ca9
Merge branch 'android:main' into loading-progress-for-image
3 years ago
4eeb045287
Rename constants
3 years ago
ec53d03854
Merge pull request #722 from android/tj/scrollbars
...
Add scrollbars to app
3 years ago
e8449112b4
Replace StringDecoder injection with simpler API
...
The initial reason for this `StringDecoder` was to make sure the AndroidX navigation route would not use incompatible chars in the resulting String.
For that, `Uri.encode(String)` was used, but this is an Android API (`android.net.Uri`).
Unit tests would fail because Uri is not mocked (since we are not using Robolectric).
Therefore, a `StringDecoder` interface was introduced with 2 implementations: `UriDecoder` and `FakeStringDecoder`, Hilt modules were added, etc.
FWIW, the naming of the API was misleading: `StringDecoder.decodeString(encodedString: String)` does not inform how encoded the input is, so `UriDecoder` could "decode" something that was not necessarily uri "encoded".
The solution to this problem was to simply use regular Java APIs:
- `URLDecoder.decode(urlEncodedTopicId, "UTF-8")`
- `URLEncoder.encode(topicId, "UTF-8")`
3 years ago
4bdc9705af
Fix miscellaneous warnings
...
- Remove unused namespace declaration
- Collapse empty manifest tags
- Remove redundant qualifier name
- Remove redundant suppression
3 years ago
b7799f0475
Convert 'sealed' sub-object to 'data object'
3 years ago
5bbcc904e9
feat: make painter in one line
3 years ago
3595d8dcb5
feat: move the placeholder default value to the method
3 years ago
9f3103c212
Merge branch 'android:main' into loading-progress-for-image
3 years ago
c779b4e8ca
Typo fix for topics
...
tocpis -> topics
3 years ago
e276212574
feat: remove check if placeholder null and put a default placeholder if its not passed.
3 years ago
9c1ec17a39
fix: modifier to Modifier
3 years ago
57025e7587
fix: review notes
3 years ago
8a197800c5
feat: fix format issue
3 years ago
f4859e0bcd
Merge remote-tracking branch 'origin/loading-progress-for-image' into loading-progress-for-image
3 years ago
06e91fd623
Merge branch 'android:main' into loading-progress-for-image
3 years ago
a294adb6b9
feat: fix format issue
3 years ago
48041fcaa4
Merge pull request #835 from blackbracken/avoid_retrieving_unnecessary_entity
...
Call getNewsResourceIds instead of getNewsResources
3 years ago
7a05f7db96
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
3 years ago
3284eb68a3
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
3 years ago
42b16bf7be
Merge remote-tracking branch 'origin/main'
3 years ago
ee8b70003d
feat: Show loading progress for Image Component as a solve for
...
//TODO b/228077205,
3 years ago
9babb50c58
Interact with scrollbar only if drag direction matches scrollbar orientation
...
Change-Id: I8fb5a64098ea83458d25fd2b7363a6b5dd3fef2f
3 years ago
e13e84c155
Replace usages of 'displacement' to 'moved' in parameter names
...
Change-Id: I5b3da60041b046454e848d187f6dd2bfadf22b9a
3 years ago
806726a7f0
PR feedback
...
Change-Id: I6e9f4a2ba53e81d32d07e229eb848541801eca18
3 years ago
eeb4973265
PR feedback
...
Change-Id: I48492e3c121ff8b2ee6bbbac08aa1829f6a6467f
3 years ago
2dba522663
Check if first item size == 0
...
Change-Id: I41acffad84d9db1cf407f77b04530643933f98bf
3 years ago
cb1d50e65e
Even better names
...
Change-Id: Ia699c3ce8fd1ce7a6e406b00c81dc196b487ed65
3 years ago
ce6eaa9d64
Fix spotless
3 years ago
4858167b24
Added clarifying comments to code and used better variable names
3 years ago
bda31e9d15
Default scrollbars to dormant
3 years ago
d6a265093d
Extract scrollbar values to constants
3 years ago
795c5e32a9
Add hoverable to scrollbar
3 years ago
31b4841cb2
Add scrollbars to app
3 years ago
56389cb760
Merge pull request #752 from SimonMarquis/kotlin-1.9.0
...
Kotlin 1.9.0
3 years ago
f7ed38182d
Add protobuf generated sources to the sourceSets
...
And update to version 3.23.4.
3 years ago
b570be2abb
reformat by spotless
3 years ago
e9a16e437d
add kdoc for getNewsResourceIds
3 years ago
805914dade
Call getNewsResourceIds instead of getNewsResources
3 years ago
7b6c3a16ca
Merge pull request #823 from ahmed-madhoun1/allow_localised_date_format
...
Allow localised date format
3 years ago
b2a74ba174
Merge pull request #812 from Askeri-Muhendis/main
...
Kotlin Coding conventions
3 years ago
c4686cfa54
Track when deep link notifications are opened
...
Change-Id: I223b1c8fbca36f9b7f2a35d9cb2fa901d6f5be91
3 years ago
3114b2eeaa
Allow localised date format
3 years ago
d136965a0d
Merge branch 'main' into lint/sarif
3 years ago
6271d1c4c0
Merge branch 'android:main' into main
3 years ago
56f8a27132
Kotlin coding conventions places companion object at the bottom of the class
3 years ago
8e1e994bb1
Add named arguments
...
Change-Id: Ic91ae4fc04bf8eb92c3e5845c7e984475526ec91
3 years ago
4a8a43551a
Add contentType to news feed
...
Before
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.9, P90 6.9, P95 7.6, P99 9.5
frameOverrunMs P50 -10.3, P90 -6.8, P95 -2.8, P99 -2.1
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
After
ScrollForYouFeedBenchmark_scrollFeedCompilationFull
frameDurationCpuMs P50 4.6, P90 6.3, P95 7.2, P99 9.2
frameOverrunMs P50 -10.6, P90 -8.7, P95 -7.8, P99 -4.7
Traces: Iteration 0 1 2 3 4 5 6 7 8 9
Change-Id: I5589776f9627c27154873529c9ca9dd055a8a8ef
3 years ago
8e708cca05
Merge branch 'main' into lint/sarif
3 years ago
7826b4f5f2
Merge pull request #748 from SimonMarquis/fix/permissions
...
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
3 years ago
890c0f5769
Merge pull request #776 from SimonMarquis/fix/714
...
Keep track of matching `Network`s inside `NetworkCallback`
3 years ago
27154ef38a
Apply changes from review comments
3 years ago
479a2f00b0
Refactor icons
3 years ago
1345764649
Merge pull request #770 from android/refactor/remove_unused_statements
...
Remove unused statements
3 years ago
fecab96e4c
Keep track of matching `Network`s inside `NetworkCallback`
...
This will ensure the connectivity state remains synchronized with the `ConnectivityManager`.
Fixes #714
3 years ago
99094199bc
Remove redundant suppressions
...
Change-Id: Iae08b6f284cf7a387922fdec34c8a0aa0da809ef
3 years ago
5bf66739bd
Remove redundant statements
...
Change-Id: Iaa25b7ba033d5e9c85cc2dc433197ed7b8b6cb89
3 years ago
9aba5cc0fe
Cleanup unused string resources
3 years ago
8ea9a8fa51
Android Lint improvements
...
- Create `LintConventionPlugin` to configure Lint on all compatible modules: Android applications, Android libraries and JVM modules.
- Run `lintProdRelease` in CI instead of the default `lintDemoDebug` which is less important compared to production code.
- Rearrange CI steps to make it more clear that Lint should is an additional step after build (build -> test -> lint).
- Enable SARIF support and upload results to GitHub's CodeQL to get inline feedback on PRs.
If we really need better perfs, we could restore `lint.checkDependencies = true` on the `:app` module and only execute `:app:lintProdRelease`.
But in practice, this does not change the total build time on this project.
3 years ago
f914254414
Merge pull request #749 from android/tj/reactive-only-dao
...
Ensure DAO exposes only reactive types
3 years ago
d319264ef0
Provide Default dispatcher for instrumented tests
...
Change-Id: I488a9b9d9d3864ce9496614ab35332ec19d06bcc
3 years ago
b245334a18
Updating TestDataStoreModule to use ApplicationScope
3 years ago
dcc36b0228
Fix tests
...
Change-Id: Ie6b62071d2023e3a7ffe1553ab606e3f6b386a5e
3 years ago
4cdb5963a0
Add top level application scope, use IO dispatcher for DataStore
...
Change-Id: I1512b1665587c73abd5e8a78aa9abd3eed24ab79
3 years ago
cd6ad7d575
Ensure DAO exposes only reactive types
...
Change-Id: I8992ccf6525cd4c5ea9503d532b500e4d310b7fb
3 years ago
823c4db201
Grant `POST_NOTIFICATIONS` permission in more instrumented tests
...
Continues the work initiated in #738 .
Extract the SDK version check inside a `GrantPostNotificationPermissionRule` class that delegates to a regular `GrantPermissionRule`.
3 years ago
f87e769b7d
Merge pull request #681 from SimonMarquis/di/coroutine-scope
...
Add Application-wide `CoroutineScope` in the DI graph
3 years ago
bbdc62cbf4
Merge pull request #706 from gururani-abhishek/remove-onItemClick-parameter
...
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
3 years ago
76b0b08121
Adjust JDK setup to remove toolchain
...
Change-Id: Ie0f43cb8f0fe504ed3e98ef35703949959688699
3 years ago
e38e24eee9
Merge pull request #583 from SimonMarquis/jvmToolchain
...
Configure jvmToolchain for Android and Kotlin projects
3 years ago
ba1d9e14df
Merge pull request #716 from SimonMarquis/SimonMarquis-patch-3
...
Simplify handling of nullability in `ConnectivityManagerNetworkMonitor`
3 years ago
a4eab289df
Merge pull request #719 from android/add-search-analytics
...
Add analytics for search queries
3 years ago
2f2dfb00a4
Mark all news resources read on first sync
...
Otherwise, there will be unread articles until the user clicks through
every article that has ever been published.
3 years ago
0e40e26f22
Add analytics for search queries
...
Change-Id: If5290a903afb928fc1c3aaa66a52d2f182aba118
3 years ago
ec9155fef9
Update ConnectivityManagerNetworkMonitor.kt
3 years ago
7819a0c6bc
Extract common code to update the Flow value
3 years ago
def5c4e881
Update ConnectivityManagerNetworkMonitor.kt
3 years ago
76c249a651
Update ConnectivityManagerNetworkMonitor.kt
3 years ago
Milosz Moczkowski
Jose Alcérreca
Simon Marquis
Adetunji Dahunsi
RivanParmar
Don Turner
qamarelsafadi
Qamar A. Safadi
AlirezaJoon
Tatsuya Fujisaki
prosixe
TJ Dahunsi
Márton Braun
blackbracken
ahmedmadhoun1
İbrahim Ethem Şen
İbrahim Ethem Şen
Tomáš Mlynarič
Simon Marquis
James Rose
Don Turner
Neelansh Sahai
Alex Vanyo