aa85a0500a
move clear actions to coroutine block
1 month ago
40805844d0
Refactor bookmark approach
1 month ago
d5d3a99e46
Fix undo bulk action
1 month ago
ca8682dffe
refactor: replace selection TopAppBar with bottom action bar (cancel, count, all, remove)
...
Co-Authored-By: Claude <noreply@anthropic.com>
1 month ago
83fe0bdc51
fix: move long-click to NewsResourceCardExpanded so it isn't consumed by Card's inner clickable
...
Co-Authored-By: Claude <noreply@anthropic.com>
1 month ago
ad557a39cf
feat: bulk remove bookmarks with undo snackbar restoring bookmarks and notes
...
Co-Authored-By: Claude <noreply@anthropic.com>
1 month ago
3bc15f9e25
feat: add selection mode UI to BookmarksScreen with checkboxes, counter, and cancel
...
Co-Authored-By: Claude <noreply@anthropic.com>
1 month ago
6727e89415
feat: add selection state to BookmarksViewModel with enter/exit/toggle/selectAll
...
Co-Authored-By: Claude <noreply@anthropic.com>
1 month ago
9955be921c
fix: clean up BookmarksGrid - use Success type directly, add Uri import
...
Co-Authored-By: Claude <noreply@anthropic.com>
1 month ago
ccd12a78d1
feat: display and edit bookmark notes on BookmarksScreen
...
Co-Authored-By: Claude <noreply@anthropic.com>
1 month ago
791898da60
fix: use correct test tag in BookmarksScreen LoadingState
4 months ago
5ba16edde9
Apply spotless by default ( #2055 )
...
* Apply spotless by default
- Upgrades to spotless 8.2.1
- Moves spotless setup from an init.gradle.kts to build-logic
- Narrows down the scope of `target` in spotless configuration to
be more precise to workaround https://github.com/diffplug/spotless/issues/2717
- Updates all references to init.gradle.kts
Ran gradle-profiler ./gradlew build --dry-run to validate performance
impact.
Before PR:
Mean 10,527.96 ms with 289.01 ms std dev
After PR:
Mean 11,251.78 ms with 530.29 ms std dev
Regression is there, but quite minor.
Test: ./gradlew spotlessCheck
* Address comments from AI overlords
* Fix usage of rootProject
* Enable spotless for build-logic via root project
5 months ago
eee94e4b7d
Finalize bump agp 9.0 (enable newDsl) ( #2054 )
...
* Bump protobufPlugin 0.9.6
Change-Id: I9f4174946f043c79bba9a669655f6654036b5679
* Change Android library to Jvm library.
Change-Id: I20ca1f71610f26a18d4573b3122994bc32c18723
* Enable newDsl.
Change-Id: Ifb855133593f64771e81f60b96c3e34d946dac8f
* Update README.
Change-Id: I3df518dd4a5f37ba7ca6e568914783b1ea417fce
6 months ago
8f269ff57a
Fix module graph generation.
7 months ago
92fd6f6605
Remove feature module READMEs (they will be replaced by submodule READMEs)
7 months ago
fb185ed7b2
Docs: Add dependency graphs for feature modules
...
Adds automatically generated dependency graphs to the README.md files for the following feature modules:
- `:feature:bookmarks:api`
- `:feature:bookmarks:impl`
- `:feature:foryou:api`
- `:feature:foryou:impl`
7 months ago
b9a80fc038
Refactor navigation routes to NavKeys
...
This commit refactors the navigation implementation by renaming all `...Route` classes to `...NavKey`. This change provides more descriptive and consistent naming for navigation keys across the codebase.
Key changes include:
* Renamed `BookmarksRoute` to `BookmarksNavKey`
* Renamed `ForYouRoute` to `ForYouNavKey`
* Renamed `InterestsRoute` to `InterestsNavKey`
* Renamed `TopicRoute` to `TopicNavKey`
* Renamed `SearchRoute` to `SearchNavKey`
* Updated all associated feature modules, tests, and UI components to use the new `NavKey` names.
* Removed obsolete test utilities and mock providers related to the old navigation setup.
* Deleted outdated dependency graph images and their corresponding `README.md` files from feature modules.
7 months ago
af504d2331
More NavigationState refactoring. Fix compilation errors.
7 months ago
f6824858c4
Refactor NavigationState and make tests pass
7 months ago
386d1a0a16
WIP remove DI 2
7 months ago
c9bba49957
WIP remove DI
7 months ago
dc29a5eb62
run spotless
8 months ago
b91a965ae2
Refactored NiaNavigator
...
Made NiaNavigator a stateless class only responsibly for navigating and pop (modifying backStack).
Navigation state now lives in a new class called NiaNavigatorState.
The state of this class is saved and restored by ViewModel.
8 months ago
e373828f5f
Update feature ViewModels and tests
8 months ago
4a8eaba408
Refactor Interests to ListDetailScene
8 months ago
d30083005e
Refactor feature modules to navigation3
8 months ago
068d8cc93c
Split feature modules into api and impl modules
...
Source code is still left in api module. impl module is empty at this point.
8 months ago
17162dab60
graphUpdate
10 months ago
1c61be7b7b
Update color mapping
...
| Type | Plugin ID | Color |
|-------------|------------------------------------|------------------------|
| Application | `nowinandroid.android.application` | `#CAFFBF` PastelGreen |
| Feature | `nowinandroid.android.feature` | `#FFD6A5` PastelOrange |
| Library | `nowinandroid.android.library` | `#9BF6FF` PastelBlue |
| Test | `nowinandroid.android.test` | `#A0C4FF` PastelMauve |
| JVM | `nowinandroid.jvm.library` | `#BDB2FF` PastelPurple |
| Unknown | `?` | `#FFADAD` PastelRed |
10 months ago
e8dc43b58b
graphUpdate
11 months ago
e079e68815
Delete old graphs
11 months ago
5b99313ae5
fix typo
...
Change-Id: I65dcde81c68c24bfd58f0b66c6ed826e802aff67
2 years ago
8bb823ede7
use backgroundScope
...
Change-Id: I78d5e53d343dac7e7d27896c95714a53a9a7229a
2 years ago
94f86b7975
fix test name and typo, and user assertion instead of check method
...
Change-Id: I45e04df676fe9f5e5e893a1fc6e8f54e9e7d7a1a
2 years ago
d372d6ecec
improve BookmarksViewModelTest coverage
...
Change-Id: Ide13abd9a125a337ba9c9fff2136221e16ebd46e
2 years ago
bf54ccc760
feat: use androidx.lifecycle.compose.LocalLifecycleOwner
...
Change-Id: If0a414ee4d5aab277fb90343ba7d5aa6a9dbd2e8
2 years ago
26dd4424f6
remove blank lines for resolve spotless error
2 years ago
0356b873e9
change collectJob to backgroundScope coroutine
2 years ago
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
2 years ago
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
2 years ago
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
2 years ago
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
2 years ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
2 years ago
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
2 years ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
2 years ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
2 years ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
2 years ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
2 years ago
2ad48843f6
Fix formatting
...
Change-Id: I674d32bc0f1921c431717dbf0f41a74f632322b3
2 years ago
254b464259
Update Lifecycle to 2.7.0. Use new LifecycleEventEffect.
...
Change-Id: I71e7aa521f22499fd3f3e9f3ac7c81658f3abc3a
2 years ago
Rohit Karadkar
Ishaq Hassan
Aurimas
Jaehwa Noh
Don Turner
Clara Fok
Simon Marquis
hiroaki404
blue928sky
saeedishayan76
Alex Vanyo