Rohit Karadkar
aa85a0500a
move clear actions to coroutine block
2 weeks ago
Rohit Karadkar
40805844d0
Refactor bookmark approach
2 weeks ago
Rohit Karadkar
d5d3a99e46
Fix undo bulk action
2 weeks ago
Rohit Karadkar
ca8682dffe
refactor: replace selection TopAppBar with bottom action bar (cancel, count, all, remove)
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
83fe0bdc51
fix: move long-click to NewsResourceCardExpanded so it isn't consumed by Card's inner clickable
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
ad557a39cf
feat: bulk remove bookmarks with undo snackbar restoring bookmarks and notes
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
3bc15f9e25
feat: add selection mode UI to BookmarksScreen with checkboxes, counter, and cancel
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
6727e89415
feat: add selection state to BookmarksViewModel with enter/exit/toggle/selectAll
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
f80446c3d6
fix: restore UserNewsResource flat-properties structure to preserve equals() semantics
...
Storing newsResource+userData directly as data class fields caused equals()
to compare userData.shouldHideOnboarding, breaking ForYouViewModelTest.
Restored the original internal primary constructor with flat computed fields,
adding bookmarkNote as an additional flat property.
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
9955be921c
fix: clean up BookmarksGrid - use Success type directly, add Uri import
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
ccd12a78d1
feat: display and edit bookmark notes on BookmarksScreen
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
9d6657449c
fix: move BookmarkNoteDialog import to correct group in SearchScreen
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
54e8f80183
feat: intercept bookmark action on Search screen to show note dialog
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
db1a8e9201
fix: move BookmarkNoteDialog import to correct group in ForYouScreen
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
cbb47d25ec
feat: intercept bookmark action on ForYou screen to show note dialog
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
06fbc6021e
fix: make UserNewsResource constructor public so core:ui can construct previews
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
b65312d7db
feat: add BookmarkNoteDialog composable
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
1540bbdca0
fix: auto-delete bookmark note in TestUserDataRepository on unbookmark
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
a37cc724f1
feat: expose bookmark notes through UserData, UserNewsResource, and UserDataRepository
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Rohit Karadkar
01ed90dcde
feat: add bookmark_notes to proto and DataSource with auto-delete on unbookmark
...
Co-Authored-By: Claude <noreply@anthropic.com>
2 weeks ago
Don Turner
7d45eae4f8
Merge pull request #2100 from FletchMcKee/graph-update
...
Update README graphs with correct datastore-proto plugin
2 months ago
FletchMcKee
64242194d1
Update README graphs with correct datastore-proto plugin
2 months ago
Don Turner
d6abd6d3e5
Merge pull request #2038 from android/adaptive-devices-try2
...
feat: updates `@DevicePreviews` to use the Devices object constants
3 months ago
Don Turner
357ec5ae02
Add phone in landscape
3 months ago
Don Turner
e74c06b73a
Merge pull request #2089 from ishaquehassan/fix/2086-bookmarks-loading-test-tag
...
fix: use correct test tag in BookmarksScreen LoadingState
3 months ago
Don Turner
496d210b22
Merge pull request #2041 from SimonMarquis/cleanup-graphs-readme
...
Update README files that contained old svg references
3 months ago
Ishaq Hassan
791898da60
fix: use correct test tag in BookmarksScreen LoadingState
3 months ago
Don Turner
fdb800abe8
Merge pull request #2082 from liutikas/spotless
...
Upgrade to spotless 8.3.0
4 months ago
Don Turner
025c0b497e
Merge pull request #2083 from liutikas/gradleupgrade
...
Upgrade to Gradle 9.4.0
4 months ago
Aurimas Liutikas
d00cf0f4cd
Upgrade to Gradle 9.4.0
...
Test: ./gradlew app:assembleDebug
4 months ago
Aurimas Liutikas
15cc536a44
Upgrade to spotless 8.3.0
...
This picks up a fix for Gradle project isolation
https://github.com/diffplug/spotless/issues/1979
This makes progress on https://github.com/android/nowinandroid/issues/1842
Test: ./gradlew build -Dorg.gradle.unsafe.isolated-projects=true --dry-run
4 months ago
Aurimas
4a5becfc88
Make isolated projects mode pass without issues ( #2073 )
...
- Enable KSP isolated projects support https://github.com/google/ksp/issues/1752
- Disable spotless in isolated projects mode https://github.com/diffplug/spotless/issues/1979
- Disable graph tasks in isolated projects mode
https://github.com/android/nowinandroid/issues/1842
Test: ./gradlew build -Dorg.gradle.unsafe.isolated-projects=true --dry-run
4 months ago
Eric Schmidt
3fda0e3290
undo a bunch of extra changes
4 months ago
Aurimas
5ba16edde9
Apply spotless by default ( #2055 )
...
* Apply spotless by default
- Upgrades to spotless 8.2.1
- Moves spotless setup from an init.gradle.kts to build-logic
- Narrows down the scope of `target` in spotless configuration to
be more precise to workaround https://github.com/diffplug/spotless/issues/2717
- Updates all references to init.gradle.kts
Ran gradle-profiler ./gradlew build --dry-run to validate performance
impact.
Before PR:
Mean 10,527.96 ms with 289.01 ms std dev
After PR:
Mean 11,251.78 ms with 530.29 ms std dev
Regression is there, but quite minor.
Test: ./gradlew spotlessCheck
* Address comments from AI overlords
* Fix usage of rootProject
* Enable spotless for build-logic via root project
5 months ago
Jaehwa Noh
eee94e4b7d
Finalize bump agp 9.0 (enable newDsl) ( #2054 )
...
* Bump protobufPlugin 0.9.6
Change-Id: I9f4174946f043c79bba9a669655f6654036b5679
* Change Android library to Jvm library.
Change-Id: I20ca1f71610f26a18d4573b3122994bc32c18723
* Enable newDsl.
Change-Id: Ifb855133593f64771e81f60b96c3e34d946dac8f
* Update README.
Change-Id: I3df518dd4a5f37ba7ca6e568914783b1ea417fce
5 months ago
Jaehwa Noh
379956cb30
Merge pull request #2045 from Jaehwa-Noh/rename-package
...
Rename package properly
5 months ago
Don Turner
66e9d159aa
Merge pull request #2051 from tjmtic/NIA-1x
...
Remove manual Protobuf source sets #2050
5 months ago
TM
69b7238b10
Update build.gradle.kts
5 months ago
Aurimas
d2445c934f
Merge pull request #2048 from liutikas/dagger-upgrade
...
Upgrade to Dagger 2.59
5 months ago
Aurimas Liutikas
ee1df5d0e8
Upgrade to Dagger 2.59
...
This pulls in a fix for android.newDsl.
Sadly, we are now hitting protobuf issue
https://github.com/google/protobuf-gradle-plugin/issues/787
5 months ago
Don Turner
b685727dd3
Merge pull request #2047 from liutikas/gradle930
...
Upgrade to Gradle 9.3.0
5 months ago
Aurimas Liutikas
82cdc6d0f8
Upgrade to Gradle 9.3.0
...
Test: None
5 months ago
Aurimas
2c56ce13bf
Merge pull request #1959 from SimonMarquis/agp-9
...
AGP 9
5 months ago
Simon Marquis
9e984e5be8
Fix Hilt error by forcing kotlin-metadata-jvm version to match kotlin version
...
```
[Hilt] Provided Metadata instance has version 2.3.0, while maximum supported version is 2.2.0. To support newer versions, update the kotlin-metadata-jvm library.: java.lang.IllegalArgumentException: Provided Metadata instance has version 2.3.0, while maximum supported version is 2.2.0. To support newer versions, update the kotlin-metadata-jvm library.
```
5 months ago
Simon Marquis
ad260fee79
rerun
5 months ago
SimonMarquis
3eb737b616
🤖 Updates baselines for Dependency Guard
5 months ago
Simon Marquis
718921fc67
Apply requested removal
5 months ago
Simon Marquis
1f729a896c
Update README files that contained old svg references
5 months ago
Simon Marquis
4cb24627a9
Update `androidx.baselineprofile` to `1.5.0-alpha01` to support AGP 9
...
and remove `android.disallowKotlinSourceSets=false`.
https://developer.android.com/jetpack/androidx/releases/benchmark#1.5.0-alpha01
5 months ago
Simon Marquis
27644a06d5
Update Roborazzi 1.56.0, compatible with AGP 9
...
https://github.com/takahirom/roborazzi/releases/tag/1.56.0
5 months ago