4284e6912e
Merge remote-tracking branch 'github/main' into feb9automerger
...
* github/main:
Bump version to 4
Remove unused DropdownMenu component
Route topic chip tap events up to NiaNavHost
Apply suggestions from code review
Migrate custom room configuration into a convention plugin
Update docs/ArchitectureLearningJourney.md - User action follow topic
Update docs/ArchitectureLearningJourney.md - Writing data
Change-Id: I417abcaba792bbf297a8156bb1c4cf677dcb8bea
2 years ago
322ff63dbc
Route topic chip tap events up to NiaNavHost
...
Change-Id: I228c486f5cde1bb47530e8f115a435bfa34381a7
2 years ago
e3e33d8497
Merge "Add Firebase analytics. See go/nia-firebase-services." into main
2 years ago
2a4d0434a5
Add Firebase analytics. See go/nia-firebase-services.
...
Change-Id: I0cbbda0bba761d8019241f6165db231fe94fb689
2 years ago
f9a3533df3
Updgrade androidx-lifecycle from 2.6.0-alpha03 to 2.6.0-alpha05
...
> `Transformations` is now written in Kotlin. This is a *source incompatible change* for those classes written in Kotlin that were directly using syntax such as `Transformations.map`
> Kotlin code *must* now use the Kotlin extension method syntax that was previously only available when using `lifecycle-livedata-ktx`.
> The `collectAsStateWithLifecycle()` APIs of `lifecycle-runtime-compose` are no longer in experimental status. (I09d42, b/258835424)
Changelog: https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.0-alpha05
2 years ago
b72d0fe1af
Fix settings dialog dismissed test on non-portrait phones
...
Change-Id: I15ed475915fdef198029db2713b6f619da374cc7
2 years ago
9b6695d8dd
Remove unused import
...
Change-Id: I426995db727995c7af6d34082593b078756a3f9d
2 years ago
b4de09d0b2
Use only width to determine navigation UI
...
Change-Id: Icad00b9a3eecac9762f6c6b7c3790e8cf1c161d6
2 years ago
819dd494ad
Run Spotless to add trailing commas (and apply other rule updates)
...
Change-Id: I5f8e49a3ef004c7e9e7dfe4bc55f0a35dc575209
2 years ago
cfbf782613
Merge pull request #542 from android/as/dynamic-color-option
...
Add dynamic color option in settings for API >=32
2 years ago
6b48b355cc
Merge branch 'main' into tm/fix-benchmarks-no-people
...
Change-Id: I94ca19fad5527c11a2f0f28cc43a23ab22f419a7
2 years ago
6046f6e943
Add dynamic color option in settings for API >=32
...
Change-Id: Ib42c1cbd0208e98ef7610a1c8aca5d721aa464e6
2 years ago
c96ff9e3c8
Coil refrence url fixed
2 years ago
43bb4359f5
Revert "Add link of source code in app"
...
This reverts commit 197f4a5157
2 years ago
197f4a5157
Add link of source code in app
2 years ago
f3f01c3d2f
Typo fix for compact
2 years ago
0917cdebec
Refactor NiaGradientBackground to accept GradientColors
...
Change-Id: I55840b22e123490097710570bf11554554df90f9
2 years ago
088a1de92e
Rename to shouldShowGradientBackground
...
Change-Id: I79d4b43354f9da99d91fb21ee84fc084b374f4b8
2 years ago
2fad9fd1e5
Fix background composable
...
Change-Id: I548612191b0b99620777c3e2ad0ace56b228d27d
2 years ago
4e4f48e88c
Change variable name for 'not connected' message
2 years ago
a1d47d5418
Center title bar when nav rail is visible
...
Change-Id: I341833b71504462fdbfbe5073a2465be2af95fda
2 years ago
1b9ed220be
Regenerate profile without people
...
Change-Id: Ia412617ac2e4212b7b9b3a3fa6f39541e53584c4
2 years ago
4ba63c0de8
Remove author concept from app
...
Change-Id: Icd03c0288ba5f3f23dbcbdbefbbe802db2815793
2 years ago
56b3c1d0b9
Merge pull request #468 from android/remove-stream-suffixes
...
Remove `Stream` suffixes
2 years ago
e6c53a8aaa
Update baseline profile
...
Change-Id: Ida83e612d5595ea1d43f9105ac7e76f7db2f6caa
2 years ago
9c22a7a4e7
Remove `Stream` suffixes
...
Change-Id: I45decae965d7e35289d3fa31fc58b8c463fbead1
2 years ago
465d9aae06
Fix spotless
...
Change-Id: Ib46c68c765342d8c172cf2f224bb7f885803b483
2 years ago
369cd33b7a
Add accompanist/testharness
...
Adds a usage of accompanist/testharnness to force a given DpSize for its content, overriding the density if necessary to ensure that the size is achieved. This allows testing UI at arbitrary sizes on arbitrary emulators, lessening the need for using multiple emulators at different sizes (and filtering tests) when Android-specific window size has been hoisted appropriately.
The initial test using it is a test for checking whether or not the navigation bar or navigation rail is being shown, and these tests can run on any emulator.
Change-Id: I315384e5eafac23a3cd6d3818d9828f6d3c1acfc
2 years ago
b425f9560d
Merge pull request #458 from android/tm/fix-benchmarks
...
Fix benchmarks
2 years ago
867cc549cd
Update BLP
2 years ago
22b8f782eb
Make functions 'shouldUseDarkTheme' and 'shouldUseDarkTheme' private
2 years ago
06dac236fe
Merge pull request #420 from SimonMarquis/patch/kotlin-test
...
Migrate from JUnit assertions to Kotlin's test framework
2 years ago
df6207122d
Merge pull request #326 from MaximillianLeonov/redundant-label-on-activity
...
Remove redundant label on activity
2 years ago
c7859d3c3c
Merge pull request #324 from MaximillianLeonov/unused-color-resources
...
Remove redundant unused color resources
2 years ago
90dc300783
Migrate from JUnit assertions to Kotlin's test framework
...
Fixes #419
2 years ago
a9aa3eafab
Add data from the last 10 episodes
2 years ago
0171971dc7
Merge pull request #316 from android/bw/gradleCleanup
...
Update Baseline Profile generation
2 years ago
3ab6002531
New baseline profile
...
Change-Id: I8a20ab2f44b198afaf57f26d1bee20054ed1ce6d
2 years ago
de893cbad7
Resolves #206 , enables predictive back navigation support
2 years ago
505187482b
Add workaround for top app bar overlapping nav rail
2 years ago
1c6c812b76
Update app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
2 years ago
dbff140b64
Fix minor issues
2 years ago
e5183e21e0
Resolve conflict with navigation changes from main
2 years ago
76daa393b1
Address review feedback from Manu
2 years ago
0d5dd944ea
Fix getter for settings dialog state
2 years ago
828242dbad
Remove Scaffold from top level screens
2 years ago
f59da72383
Add comment about splashScreen.setKeepOnScreenCondition
2 years ago
5e4100fafc
Add MainActivity view model
2 years ago
c3f7870412
Fix spotless issues
2 years ago
56c0645816
Add tests
2 years ago
8c30ab9f80
Add settings module, refactor top bar
2 years ago
b7500ea09b
Fix typo
2 years ago
add486a0ab
Fix spotless issues
2 years ago
7e3faad699
Add data logic for theme switcher
...
Change-Id: Ifffadb897de4f6e08f7115103f99c156a7098b70
2 years ago
a0b22d8ed2
Updates Navigation approach with new guidance ( #347 )
2 years ago
7e6cb46436
Merge pull request #328 from android/bw/moreJankstats
...
Add more jank tracking
2 years ago
ee2e3db928
Add more jank tracking
2 years ago
dcc23829d4
Migrate packages to namespaces in build files
...
Change-Id: I21e021caa0ea72a7097dfd9af04a3c07a0cc9aa5
2 years ago
348e2cc6f4
Shorten navigation trace, fixes #271
...
Change-Id: I4b33800a538b13996fc68b48854be56251a9db2c
2 years ago
f16b698ba6
Remove redundant label on activity
2 years ago
73a9960cbd
Remove redundant unused color resources
2 years ago
9be6e846d9
Apply spotless
...
Change-Id: I49eeb1984cb3e978a9cee5c1e4d53e856a10bb4e
2 years ago
738210166a
Refine backgrounds and navigation colors
...
Change-Id: I9fd863cc608f21078ab78c39c2c3d227aedbac7c
2 years ago
8c11769622
Update to material3 1.0.0-beta03 wih built-in insets support
...
Change-Id: I4d07f89d4faa6e3417468ad78acf3fbb161f0797
2 years ago
d0cff2b11c
Build cleanup
...
* Move Hilt setup to convention plugin
* Disable Hilt on modules where it's not needed
* Enable non-transitive R classes
* Fix `configuration` blocks called in wrong scope
* Move imperative Flavors code from build.gradle
* Disable unnecessary build features globally
* Disable configure-on-demand as it's not encouraged
* Don't use internal AGP packages in plugins
Change-Id: I1bee3e3fd0103054637b979a350f9fd2312ae8ba
2 years ago
a37c06db10
Merge pull request #231 from android/jv/app-icon
...
Update app icon using Image Asset Studio
2 years ago
bcdc906f3a
Add round icon again for API 25.
2 years ago
f00cae012f
Add monochrome to v26 app icon, remove round icon (as per documentation: You may also define an icon drawable resource using the android:roundIcon attribute—but only if you require a different icon asset for circular masks, for example in a case where your branding relies on a circular shape.)
2 years ago
73cd535695
Fix dark mode system icons
...
Change-Id: I8af3435d2b83ebbd55b8adaa3f2066fbe2d22fa5
2 years ago
f851141b0d
Add v33 launcher icon with support for adaptive icons
2 years ago
152d571847
Update app icon using Image Asset Studio
...
Change-Id: I9eb8281abbb59da0b653dbe6c36786c90d330556
2 years ago
e0687e9aae
Merge pull request #217 from android/av/splash-screen
...
Removes non-Compose Material library and adds splash screen
2 years ago
200aede1c7
Rename NightAdjusted.Splash to NightAdjusted.Theme.Splash
...
Change-Id: I2493c664945d3cfbe1c52397133fdc955265ac56
2 years ago
8587ae8ee6
Merge pull request #219 from android/bw/metricsUpdate
...
Update JankStats to 1.0.0-alpha03
2 years ago
6dc17126da
Update JankStats to 1.0.0-alpha03
...
Accomodating API changes along the way.
2 years ago
063965c9cd
Add splashscreen integration
...
Change-Id: I1fbc5b7e663497ae52759afb7bcd6169c5987ce6
2 years ago
4523129fd4
Remove non-Compose material
...
Change-Id: I62a639b6c12e7d523c3dc5ad0766f180120d9e92
2 years ago
40cf1b8171
[NiA] Implement LazyVerticalGrid for Feed
...
Change-Id: I0fd51bdd4c64a3d9ceaba05244d384bb9b463315
2 years ago
37ad3e6299
Merge remote-tracking branch 'github/main' into jul22automerger
...
Change-Id: Ic54190a9d825ae9649d34a4e2bd9c83855511b71
2 years ago
ea07e97a07
Add more KDocs and nav args encoding
2 years ago
872a7a6523
Make the state holder stable
2 years ago
0eee3620b8
Add state holder for NiaApp composable
2 years ago
34411e3f70
Merge remote-tracking branch 'github/main'
...
* github/main: (21 commits)
Add stacktrace for test command
Add TODO comment with bug
Update Compose compiler to 1.2.0, Kotlin to 1.7.0
Consistent tags & named parameter usage
Address review comments
Remove redundant dependency
Fix spotless
Move JankStats metric gathering further down
Add ForYou TopicSelection scrolling state
Add ForYou feed scrolling state
Add JankMetricDisposableEffect
Add AuthorsCarousel scrolling state
Add JankMetricEffect
Remove InterestItem state
Use DisposableEffect + rememberMetricsStateHolder for Interests tab selection
Use rememberMetricsStateHolder for navigation
Add rememberMetricsStateHolder composable
Introduce view extension to track jank
Inject JankStats with Hilt
Add jankStats and rudamentary jank logging
...
Change-Id: I1ff0fb3ccb7d6082c17c6e69f5d9ea9cabe1d733
2 years ago
c4110e33c6
[NiA] Add Saved functionality
...
Change-Id: I38320a16999d063a023bbe9d329a275af4e78b1e
2 years ago
efb76d4941
Merge branch 'main' into bw/initialMetrics
2 years ago
9f929944d0
Address review comments
...
* Introduce gradle plugin for firebase perf
* Create TrackScrollJank composable to mask tracking code
2 years ago
6509b6ac9d
Merge branch 'main' into bw/initialMetrics
3 years ago
a4e7488888
Update baseline profile
...
Contains CUJs:
- scrolling for you feed
- scrolling interests topics
- scrolling interests people
Change-Id: Iad124aafae9858b2922dcfa49302fe1f8aacae48
3 years ago
b2569c1576
Add testTag to access composables from UiAutomator
...
Change-Id: I5125cae0778151b11868b72f74f74f979774625c
3 years ago
90480286c9
Merge pull request #68 from RivanParmar/main
...
Fix Navigation Bar in landscape mode.
3 years ago
d05b573f52
Improve design system usage and add lint checks
...
Change-Id: I05f9400a9410e31bdf1534e458d560fe793b809f
3 years ago
334a6d07b3
Fix SpotlessApply.
3 years ago
fa16a25ac8
Merge branch 'main' into bw/initialMetrics
3 years ago
09e0aed124
Merge branch 'android:main' into main
3 years ago
42878c5e86
Move JankStats metric gathering further down
...
This isn't the thing a developer should be focusing on when first
opening the file. So moving it further down in the composable.
3 years ago
da79a98876
Update baseline profile and generation logic ( #61 )
3 years ago
e949749073
Merge branch 'bw/initialMetrics' of github.com:android/nowinandroid into bw/initialMetrics
3 years ago
747416ad84
Fix Navigation Bar in landscape mode.
3 years ago
5032136784
Fix Navigation Bar in landscape mode.
3 years ago
b602abc263
Merge pull request #56 from sud007/fix/nia-naming-convention
...
Fix Bug #41 | Nia Naming conventions
3 years ago
bc7270d6c4
Add JankMetricDisposableEffect
...
Change-Id: Idcab0faa2e9b4cc9986064f45217cab101843697
3 years ago
a076a50010
Use rememberMetricsStateHolder for navigation
...
Change-Id: I3b038a9bbc6eed9b21343aa0fd75c044049386a4
3 years ago
58fd7dcec0
Merge branch 'github/main'
3 years ago
ea1114a337
Fix Bug #41
...
Fix bug #41 Made Naming Convention symmetrical. as 'Nia' instead of 'NiA' as that sounds more subtle and easy to follow in camel-case notation based Naming
3 years ago
7813757393
Remove ClearRippleTheme CompositionLocal from NavigationBar
...
Fixes #36
3 years ago
a37c932898
Introduce view extension to track jank
3 years ago
895ec4c337
Inject JankStats with Hilt
3 years ago
4f57975657
Add jankStats and rudamentary jank logging
3 years ago
103398682a
Add tracing library and start using it
...
Currently tracing sync and main navigation.
3 years ago
3a43928ef1
Merge branch 'github/main'
3 years ago
f74103c804
Merge pull request #44 from serbelga/fix_themed_app_icon_round
...
Fix themed app icon launcher roundIcon
3 years ago
9f10b5c4c6
Add cutout version of ic_launcher_foreground for drawable-v24 in app module in order to distinguish it from the nia-app-catalog version
3 years ago
72278b8cef
Add monochrome attribute to ic_launcher_round.xml in :app and :app-nia-catalog
3 years ago
1475e3e8f9
Fix nested navigation graphs
...
Change-Id: I2c3ad0a0f6c132230b821d3621389913cf37247c
3 years ago
0651d9dde6
Update benchmarking & baseline profiles
...
Uses newest versions from I/O release
Also updates baseline profile to match latest changes
Change-Id: I83c709338ea37d2187d1e8437f5b5d8e98a42f22
3 years ago
febbd26261
Refactor navigation
...
Change-Id: I3501446e73976f3872592038501fcef8c8324f74
3 years ago
52b771a8b5
Update baseline profile
...
Change-Id: I6b69df704e14ba9568494d773690a1121226273e
3 years ago
d945a007c6
Add AuthorScreen and corresponding components
...
Change-Id: Iee5e8bd0932d1b68770aaa1e23fa660451109601
3 years ago
dc4af7e6f7
Rename following to interests
...
Change-Id: Iabcb8b495717e0cb3a993ecc0e09e3338fe5140f
3 years ago
ce0142b98a
Add gradient background to For You Screen
...
Change-Id: I6a85ee82a78b1897020f1737503611bd100764a1
3 years ago
cce9402b04
Add multi-column support for cards on the for you feed
...
Fixes: 228074722
Change-Id: Id077b4dd93452b5f9399f94161c9b66594436975
3 years ago
203c8e1ceb
Configure spotless for kts and xml files
...
Fixes: 230874524
Change-Id: I147b9f16d5424b3459435e3c5422867b40c480b7
3 years ago
f84320e9a9
Fix large screen insets handling
...
Bug: 228374243
Change-Id: I2a7af72e60450be3280872b46bd84eb1079b533d
3 years ago
643b230187
Converted model ids from ints to strings
...
Change-Id: Iad07926e04113bcd2c6d9e06e5e2a4e802a79b80
3 years ago
7ac15771b3
Update to Kotlin 1.6.20 and using material3-window-size-class
...
Change-Id: I30bc9f729ab91f007de530af3a12b281430ac1cb
3 years ago
bcf05f5502
Remove material non-3 components
...
Bug: 228974929
Change-Id: Ie74189bd6ce1a4a2ece36962e0ad1627ac9c71dd
3 years ago
3558a6931e
Add People to interests screen
...
Screenshot: https://screenshot.googleplex.com/3XqkTwJQwgfoPsT
Change-Id: Iac7dc06c84523b4db8d05f538b74a08741d2c347
3 years ago
553d152844
Adds topic screen
...
Bug: 213876743
Tests: Local + UI tests + Navigation test
Change-Id: I6c521695d6b777084a6255c6d62623a4def83063
3 years ago
9ebea8ad29
Improving For You onboaring [ http://b/223204846 ]
...
Test: updated tests that were failing in firebase testlab due to the UI change.
Change-Id: If892a7a81eecc69bf71f41d75c11af363903f962
3 years ago
ab7b25ef6a
Add new fields to Topic and display SVG icon.
...
This CL makes the following changes to the Topic model:
Renamed description -> shortDescription
Added longDescription, url and imageUrl (this is the URL of the icon)
This makes the model of Topic in the app match the model in the back end.
The icon (an SVG file) for each topic is displayed in the Topic list UI.
Change-Id: Ibbb35c8be879ae4d6e45b69fa0eafa88f3537052
3 years ago
2b2bd496e0
Added launcher icons
...
Change-Id: I2c7fbfd36d91866956d7787e547affe1b90f4fbc
3 years ago
ccb822286f
Integrate WorkManager (WIP)
...
Change-Id: Iedf81220336911ab3ed6ea4ca71b10f07e645bc9
3 years ago
57f478b7c1
Remove episodes and saved destinations
...
Bug: 223215076
Change-Id: If71b9190c145f9fc298f33fe2145a87886419d68
3 years ago
5b54858642
Add baseline profile
...
Create proguard-rules.pro, disabling obfuscation.
The BaselineProfileGenerator needs to run on an AOSP emulator.
Classes in StartupBenchmark should run on a physical device to produce
reliable data.
The baseline-prof.txt file should be re-generated for each release.
Change-Id: Iaceb4e5c6d2f927dc545454a44dea43951dfaf6d
3 years ago
668d6cc91c
Merge "Adding device class breakopints ( http://b/216019537 )" into main
3 years ago
89f54c23d6
Add Internet permission
...
Change-Id: I3b7e042a6fac971597f554049895dbc1cc38fba7
3 years ago
ea9fbad058
Adding device class breakopints ( http://b/216019537 )
...
Adding NavRail for MEDIUM / EXPANDED classes (http://b/216019759 )
Change-Id: I19a8888de558e1466d186a48f2ea293bb1b8ba4b
3 years ago
506c98cc90
Add test dispatchers
...
This adds a test implementation of dispatchers with an injected TestDispatcher.
The normal IO dispatcher is automatically swapped out via a TestInstallsIn in core-testing.
This update also updates DataStore to use an injected dispatcher, which allows removing the waitUntil in the navigation tests because we can eagerly read from disk with runTest.
Change-Id: I82abb8c8a57c2beed5ef37bf1e252acf379278cd
3 years ago
1411b1576b
Modularise the app
...
Change-Id: I63791eaf27d08a837598d774df53c96bb01b5864
3 years ago
1b06dc97ea
Fixing UI tests
...
Change-Id: Iaa0ce3ae92e0c736aef5809c1e471c9cbff695a9
3 years ago
53248e6dac
Merge "Add Following - Topics feature base" into main
3 years ago
4f3776406c
Merge "NewsResourceCard: Display Title, Bookmark Icon and Description" into main
3 years ago
d355a70292
Add Following - Topics feature base
...
Acceptance criteria: https://b.corp.google.com/issues/213886281
Change-Id: I129fb3d076b831aa00c16533090cb03b2bdebdd7
3 years ago
e089012a8d
Replace module interfaces with objects
...
Change-Id: Ieab7533120e7b8d5a770963e37b9db405e229630
3 years ago
8b1852cf5e
Merge "Add DAOs for Room and provisions for their Hilt injections" into main
3 years ago
8d8e72667b
NewsResourceCard: Display Title, Bookmark Icon and Description
...
Screenshot of change: https://screenshot.googleplex.com/957TAnWp96uX8Ea
Bug: 216019530
Change-Id: I58fd1b4fda06b0fb8cc5df2ba5baf7e8ddcd5a1d
3 years ago
cbcb24c08f
Add DAOs for Room and provisions for their Hilt injections
...
Change-Id: Ia14c225cc1632ded38abffc201b673a6a60f4451
3 years ago
a36c0da93a
Replace accompanist/insets
...
Replaces the insets support from accompanist with the in-progress support from Compose itself.
This is a pretty simple change on the usage side, since we only used it in one place.
Change-Id: I05ce768d13fcdeb6471012dde774636526cf35f3
3 years ago
9f11f6ae8b
Update copyright accross all files
...
Change-Id: I3d30bf58ded466f936772958bebcd7b7817ad809
3 years ago
c75f7ed025
Add entity relationships and defined network deserialization strategy
...
Change-Id: I239cdc28237a87a0ed6599892e8ac7c61776a46d
3 years ago
Don Turner
Márton Braun
Simon Marquis
Alex Vanyo
Angie Sasmita
mlykotom
Harshit Pandey
Muhammad Anas Shamsi
Jolanda Verhoef
Masood Fallahpoor
Milosz Moczkowski
Don Turner
Ben Weiss
Ben Weiss
Yura Laguta
Manuel Vivo
Wojtek Kaliciński
Maximillian Leonov
Nick Rout
Rivan
Rivan Parmar
kbuilder
Sudhanshu
Sergio Belda
Simona Stojanovic
Adetunji Dahunsi
Jose Alcérreca
Ran Nachmany
Caren Chang