19f6f9e09a
2 pane support in Interests screen ( #1234 )
...
* Add dependency on material3 adaptive
Change-Id: Ic49934112a4bdbf15a68c694fbc6b0f23de960a6
* Add InterestsListDetailScreen composable
Change-Id: I27e1f6d2e0eeac781baf2b671fa51a864ea5a971
* Store selectedTopicId in InterestsViewModel
Change-Id: Id93704335686f171fbf80bdb54865d0f32dc36ce
* Pass detail pane composable down
Change-Id: I82752d8cfbb3519395f37748fb5f64b769c0c293
* Navigate to initial topic if provided
Change-Id: I8998a55a29cdaf90577fa730d55c4ac2f54d6e5b
* Lift LDPS up to app module
Change-Id: Ibc6e8e598cd0cb62f804f11b2e48d8ae3a81df85
* Fix some navigation behavior
Change-Id: Ib6c16aff692b9ce997747a30f2863303cc82fd8b
* Navigate to initial topic if provided
Change-Id: Iaafe4f876655d51243d7b99be985e9440fe2d4ed
* Remove dependency in interests feature module
Change-Id: Id517c95e11f93e1c7e17d749a7af0cfdf6085a1f
* Hide back arrow when the topics list is visible
Change-Id: I8901c3f79b11d35568f0ae779f97fab90e574aa8
* Update interests tests
Change-Id: Ie5daf55985fdb53570397cb652abe31bad78f5cd
* Highlight selected topic when displaying 2 panes
Change-Id: Ifef9fb599f828f58390374b11eacc8be6c280415
* update dependency baselines
Change-Id: I90dc21df3337865f4c5368634d3d45fcb0eccc00
* run spotless apply
Change-Id: Ib5fb1b7fc26a62bd5e271c2a3721f1c13173f7f8
* Convert isListPaneHidden to isListPaneVisible
Change-Id: I6e54f710df7db5ed6f3ec1cb284bc29f2763a657
* Set semantics for selected state
Change-Id: I31f27d5036d07c9607909c09ac52a72391f899ca
* Use scaffold roles when determining visibility
Change-Id: Ib5fe236f182a5eeab20b61692a1cd53c17b68648
* Update multipleBackStackInterests test
Change-Id: I1e372f7989817151a6765205291b13b561187fa8
10 months ago
1ca0085423
Merge branch 'android:main' into java-to-kotlin
10 months ago
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
10 months ago
9b488bf70a
Move java to kotlin folder.
...
Change-Id: Iaf4723dea6169fbf3f9a8d3bf8779179ac56ab86
10 months ago
27fd4e544a
🤖 Updates screenshots
10 months ago
02d4fea615
🤖 Updates screenshots
10 months ago
a507ff6d8e
Wrap NiaApp with NiaTheme for app screenshot tests
...
Change-Id: I8e298da139b19721b90ae778e7ab184f600d0bd7
10 months ago
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
10 months ago
6b2b01ed82
🤖 Updates screenshots
10 months ago
58483b6166
Revert fast initialization of Coil
...
As discussed in https://github.com/coil-kt/coil/issues/2097 the problem is caused by regitering system services, which will be fixed in 2.6.0
Change-Id: I9085309780508137f10b25ff82deed3c62e5d159
11 months ago
f3e89bad4a
Add braces
...
Change-Id: I859babab7278137a4a2e49e5a085c65632888dd0
11 months ago
d1211f15e7
Inline initialization
...
Change-Id: I0a77eb6457cac27c1a4d604c8efdcbbdce95bc48
11 months ago
e853748cf7
Don't use runBlocking if async init completed
...
Change-Id: I641187ce277f434c6fca49a11b3cfccd50ecf5da
11 months ago
7c33946ce1
Launch loader directly without additional coroutine scope
...
Change-Id: Icbbdbcbcac1a6275857ebe998509f1e09109db7a
11 months ago
8e3903e90c
Fix comment
...
Co-authored-by: Yuri Schimke <yuri@schimke.ee>
11 months ago
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
11 months ago
12a3a6edde
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
11 months ago
f8e797fd26
Rename currentTimezone variable
...
Change-Id: I92630f6851b0253294a8d3ec2e5b3cbe7db74b4d
11 months ago
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
11 months ago
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
11 months ago
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
11 months ago
f5b3ae56dc
Merge pull request #951 from SimonMarquis/issue-945
...
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
1 year ago
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
1 year ago
afdfd8acc5
🤖 Updates screenshots
1 year ago
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
1 year ago
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
0699efc592
Merge branch 'main' into issue-945
1 year ago
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
1 year ago
a5c030f740
Merge pull request #956 from KDW03/add_saved_test
...
Add Test for Saved Top Level Destination
1 year ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
ad15f0137e
Merge pull request #1094 from lihenggui/main
...
Upgrade Spotless and Ktlint and remove code convention violations
1 year ago
8d5ef578c6
Merge pull request #1103 from android/add_icon_comment
...
Add comment explaining why the launcher icon colors differ per build
1 year ago
b6d82e24df
Merge branch 'main' into kotlinify
1 year ago
b801a7deea
Moving comments to _after_ first XML element
...
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
1 year ago
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
1 year ago
d018e57f52
Fix spotless
...
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
1 year ago
e6b5560f07
Revert "Move app screenshot tests to match dependencies declaration"
1 year ago
28bb3f1b2f
Add comment explaining why the launcher icon colors differ per build variant
...
Change-Id: I30126402370162ccbe53e177652583e4472f2030
1 year ago
83764082ff
Move app screenshot tests to match dependencies declaration
...
Fixes #990
1 year ago
32e1ec0447
Remove violations: property-naming
1 year ago
fb5bd225be
Spotless
1 year ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
988002e692
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
1 year ago
9c89e98e5b
Revert "Merge pull request #942 from android/feature/navigation-suite-scaffold"
...
This reverts commit 335a7ec68caa8ce0e1f6
1 year ago
f365e8b782
🤖 Updates screenshots
1 year ago
816a7b60c1
Replace manual navigation component switching with new NavigationSuiteScaffold
...
Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723
1 year ago
3f22248cb7
[CI] Better caching and fewer jobs run
...
* [CI] Runs build in macos to generate a cache for androidTest runs
* Build projects before running emulator
* Fixes flaky coroutines test
* Moves spotless up in local tests job
* Enables config cache by setting problems to warn. Fixes #1022
1 year ago
d3d5b02428
Inline color values for app icons
1 year ago
9b83237bfd
Removed Comments
1 year ago
Jonathan Koren
Jaehwa Noh
Tomáš Mlynarič
dturner
Don Turner
SimonMarquis
Simon Marquis
lihenggui
Miłosz Moczkowski
mmoczkowski
Jose Alcérreca
TM